From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3870DC3601E for ; Fri, 11 Apr 2025 03:31:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E83EB28014F; Thu, 10 Apr 2025 23:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3B5D28014C; Thu, 10 Apr 2025 23:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFA1B28014F; Thu, 10 Apr 2025 23:31:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B2F1528014C for ; Thu, 10 Apr 2025 23:31:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D1B7B161A1F for ; Fri, 11 Apr 2025 03:31:36 +0000 (UTC) X-FDA: 83320338192.15.6650A4F Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 1EB59160005 for ; Fri, 11 Apr 2025 03:31:34 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N55M+MK1; spf=pass (imf08.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744342295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v6KMYioGwvZqzqvNLntsUxx7k0qHY5fAJEFbvhfiymk=; b=Oh6PcAwj9FJ9zk3exf6X5PSpsYxldnFz72ChHuSpRWROR+Uw5vQ7jalrJVMwTd1NvHhHVA 5TBG8fSzj6gI4Q0sTFUKlaaerg9dQp5Txlf+NXRqz/bnTsbplNsBHK8MkCZO5zOXuVNwIk PcyfdaL656nj+CrJOTjpPfxElHOW6Wo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744342295; a=rsa-sha256; cv=none; b=4ygJihPY3AK84NBlmfbZm8QteMkxb82dUJG+Vh/XMarf3zLXa/bIlv2N+haC5n8rfRiWMI 9bVzQoGQ4pIW0X3pdq3KDashBeNKmzyNvEqQ5OvprPve61aMFjFnxvrVCKbs4kZH8+Wm1f ICumKZqnjyESQHfO3VLTN9JXVY68cdE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N55M+MK1; spf=pass (imf08.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2243803b776so22357055ad.0 for ; Thu, 10 Apr 2025 20:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744342294; x=1744947094; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v6KMYioGwvZqzqvNLntsUxx7k0qHY5fAJEFbvhfiymk=; b=N55M+MK1rZa7uUGMGhVNjFCGS6NnsijpV7/nF0+grYNWWksdfxA9G0+sWm4pZs3G3x TVkBmVJ/JEM1VveavZqKiRvND8b4KeZvF32Ufzbue6v+RAAZe8C0i5EpHm3COffcsIsX oOmVcavtRHzPXqsOHn291Yzlopcx3rHReKzama4Hxw4mYCej2rUXi6PKLNzh1E19V3EG 2QbZHlU3jm8BZyFoaNNzQkPmR0V4xF6xmBwXNZ8lYyBxEx7ZggAohMW0AqWCHUj1MG6i 5qNEhgHU1H/mtTr90CzvGTym+GitJCv7ZPCYS3Vs8QqRs1jL+y6ZgZoW2DAaTxk4+bse Jlbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744342294; x=1744947094; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v6KMYioGwvZqzqvNLntsUxx7k0qHY5fAJEFbvhfiymk=; b=CbmXkHc/sl/hdbKBCHOj1oUx+k9jyueCTsl5RCjkYRwhj1lCZXf5sUYxEZMo9cwcEb Lf44S7XCJACtpwhHY43Eq0gHnyqKPT8ON3Udj5yTKtwvXS6Rp1C1g/IB9oZOPEb5v51w rsmJlKN4XPvrUK901mEZEN+y7gCBkFdd+Zl/kJvJnQYz8PQn8lephHxI7jEuV4H4xWd7 vfbh2+SsGyT0BoobSerVIMmaJYek8Eaf1GtXrxmmdgqA4Uzov8tWZ5mlYPJxhvMfUHlt RhboZYay3PKvNrXl3fw2G4+uYGyDmz1lHxsvdMR2U/FIxDglQ97uc5v7IYFSegWFTTwn vxlw== X-Forwarded-Encrypted: i=1; AJvYcCXOvuqa8whsw/ExBnhy0lKcOK+5EhWpBTGT0326djR7S2o1+Y67jFr1h8PnB5AbFU7bOcx7/y4P4w==@kvack.org X-Gm-Message-State: AOJu0YxkEyw16Qdejv1dugXvma5juWrRhnU+F1rUKqtQUVGiFlgCNk4m Bp8wtJBAlbyz+p7bJjTpirOxAXogR1gY4BJYKwzPR1IYaKbfuIkO X-Gm-Gg: ASbGncsVKyopzgXLhkDG6OviS1y7SmlK4+ccEjaXgRD8Z0j7pFNxrE5jsyIk1spMHQQ 80MujqpzVu64Yhfb144C2xf4S09KpkHop5kaCHA00v/uAi60Tgy9fjH+uPNu2+wy+mAi1dJLteg /E8U9lqHABHQ7RPoDYlt1SLvXlZKoVYV7GnyojKHNqroQr8IYOOps127wYrjiBHDX3CAkqwNNOd NoXGJ/zmrdzXuRVS9ubk1Zapicz6X86VS/h3a+EbtOslRIXxBIRRHteEvQuJ6KTVgkgbVLGwFt1 6fn5dvUhRCtTEQch0Dzu5p5EJ0kq2CKT4cjr8aIyJWzlc2oVhqseKBq9qnDXshmJQArNLG43PDj WeZ+TNANo4w== X-Google-Smtp-Source: AGHT+IEjgeFqbmzv/qsJfxVeaJrC9P6gUgiU8XFC2/wT7D1SXFzvlvZfurFfP6FU7HnbUEf/eiGZhw== X-Received: by 2002:a17:902:e84e:b0:224:584:6f04 with SMTP id d9443c01a7336-22bea4ab6b7mr14734875ad.18.1744342293924; Thu, 10 Apr 2025 20:31:33 -0700 (PDT) Received: from [192.168.2.10] (c-67-188-127-15.hsd1.ca.comcast.net. [67.188.127.15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7c95c62sm38838595ad.125.2025.04.10.20.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Apr 2025 20:31:32 -0700 (PDT) Message-ID: Date: Thu, 10 Apr 2025 20:31:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] cgroup: use subsystem-specific rstat locks to avoid contention To: Tejun Heo Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-6-inwardvessel@gmail.com> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 68ibckwwpee76kbt5unko71g9tcyf5yq X-Rspam-User: X-Rspamd-Queue-Id: 1EB59160005 X-Rspamd-Server: rspam08 X-HE-Tag: 1744342294-722108 X-HE-Meta: U2FsdGVkX19qyxY2airVjPxAbJRLl9XSZVAfnZZ1c6qn3QaId9J7Jh+aUk6mvrvi9ZS5TNcXFQ0Lfumve9WZbMMimgrmaaiTnFFKwdGxpESuA4xTez+hDwvCpfH/qG1j0XJcwmS6tm0eUVsh9DIbG8W3GmWR6XsrhHKRnfjte84my00EGO+IOSIqjxDCxB6snJ7MdzJmJZFCpD4AJfze/TURw2ImQtXmSok+/NplLOI5thUxj1JikLVeO4M/5pHqdlDwHZJg8osl9hz/5edoekb8x8gnvSJmtgSyliEdFAX2bEDEOqgtXgeseUfPhnv5zIhWdcGDHCD7a3qNeM0433SahyLCzJoYcciM2eGCBcTzLK6Syv5zqp56M+N4gX0MULiePQR9tcSJ6/UsFwt6oQZfBAe5SvUEZHc5TWwntBUGZ0EmoZ3L6vpiiJF6B8Om9JkpD2NFZX13M/adRkOC9q7WMbqj9yhyDHRc1U3cmpT1gAHi90eFfDQnspD4+baq873D+Pr+F1Zr4nK78Lk2y4zW7NC1NFCPcJLfaDCyf59fwiEULSnj1U68CL0jLMaJrZfNaaCkHC/eCbbA4X0huukq9vbUUBDl0fAyIq6Kh7R5/2KE0rw3w2gnVnW3VkdJJTHYW9KQwgE3Yx6a5QQRubPsJrTKa8T8mR6lNTUVrMkoY2s54FDn8OJt66CSCeN+qeUI4sp/p+a42wJU2qaRMR1sLdwQNHRQBgc4kt80i/1s6iGjC5q003DE0ul5dNm2tjs1ntpbbwSe1TbWdBlibrJ+JdnCSMbDMwEz5KYoqDrwgZJIEDA1XejkwUeWd+OQFPlHFYRmDeY4fHk42iqMB81rMaRW3jEKR/7aGdd1ugm7P708atWBYeq2cumYgzOEG7i/QGIgDBxAHvNmTcujfvXr0M4MNxD1bheDP6nxHwahIzcxTXQjR63e/+QYxgCrne6tsvTupVfxiJXRH42 m+zIgOmR 1gWvXGIeWvXypQds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/25 1:28 PM, Tejun Heo wrote: > On Thu, Apr 03, 2025 at 06:10:50PM -0700, JP Kobryn wrote: >> It is possible to eliminate contention between subsystems when >> updating/flushing stats by using subsystem-specific locks. Let the existing >> rstat locks be dedicated to the cgroup base stats and rename them to >> reflect that. Add similar locks to the cgroup_subsys struct for use with >> individual subsystems. >> >> Lock initialization is done in the new function ss_rstat_init(ss) which >> replaces cgroup_rstat_boot(void). If NULL is passed to this function, the >> global base stat locks will be initialized. Otherwise, the subsystem locks >> will be initialized. >> >> Change the existing lock helper functions to accept a reference to a css. >> Then within these functions, conditionally select the appropriate locks >> based on the subsystem affiliation of the given css. Add helper functions >> for this selection routine to avoid repeated code. >> >> Signed-off-by: JP Kobryn > 4-5 look fine to me. I'll wait for others to chime in before applying. > > Thanks. > Michal, Yosry, can you give patches 4 and 5 a look? I think the changes requested up to this point have been worked into the series.