From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7111BC02181 for ; Mon, 20 Jan 2025 19:23:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4A106B0089; Mon, 20 Jan 2025 14:23:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFA95280002; Mon, 20 Jan 2025 14:23:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4CE3280001; Mon, 20 Jan 2025 14:23:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A11AC6B0089 for ; Mon, 20 Jan 2025 14:23:29 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 500311402EC for ; Mon, 20 Jan 2025 19:23:29 +0000 (UTC) X-FDA: 83028804138.19.EB03E9C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id BC26D1C0013 for ; Mon, 20 Jan 2025 19:23:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FjYepndu; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737401007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g/Kot/CGWXdBkOcgzfuSXppZ8O3rmTLRkGTl8V+8sPE=; b=yHKtfiSUAVTxisoVYZhLSa/ix30bKvoANhAG2YQe9l9Vc8Ek0Z2FINqkTEghaonSUPD0UH +PY1Gh5zkwo0/Tah88lB6qPtMwYc1/vabKVj97A+SQtkOaMhVSHUKwwcTvTngArDJ/fT05 ySGoiUoKfRTBJ/lhyC5iX7u1evm2hKA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FjYepndu; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737401007; a=rsa-sha256; cv=none; b=NI1P231/EysXZUHWzNAQ7xfTRb0zefiPtvR6rvmo0aZ2tbc55iiiXv5tev6i0N0U6IDR0z bKlNxhBB2vuZMLgly2zwrIFnRDbNKytrnYYrH2jNOLCT7QHBlhKpxaSIaEzRHEZH+yh1Ql sDUg6WHPg5uwZyBaLIxcMg6UrO/NE3Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737401006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g/Kot/CGWXdBkOcgzfuSXppZ8O3rmTLRkGTl8V+8sPE=; b=FjYepnduV16ArbTL5ic1KtaelSr5TPO6fSv+/K1YYDEAA1NxbmWdPnhNVtfX55elZWf+Pq 5TiJyHPs+OU1U/yqEFJx5r95+j1QnxyhoOCxZn3gWeiPOEKb7uEosskFJNcKOxIhNA9qo5 etR3Lp8UohNBqNLlVJnQqcE+adTyIV4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-IMM6Iy6iOpKXCKGfqS3J4Q-1; Mon, 20 Jan 2025 14:23:24 -0500 X-MC-Unique: IMM6Iy6iOpKXCKGfqS3J4Q-1 X-Mimecast-MFC-AGG-ID: IMM6Iy6iOpKXCKGfqS3J4Q Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3860bc1d4f1so3066838f8f.2 for ; Mon, 20 Jan 2025 11:23:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737401003; x=1738005803; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=g/Kot/CGWXdBkOcgzfuSXppZ8O3rmTLRkGTl8V+8sPE=; b=VN1apILlK3DMc/enEdZ15ySrodM/TwANdB+WhdCzwlVrqBBH2dI9MKL0BKDgLso37+ vCrWEN2lgHEkDTidXZNtXK362xFJ7IjK2prH/5dmzs5OMoE2s8PRflygSpnkZTdoFwAo ger80pBJulsoTq4fAsxMVZmrGnm/ynfj0gu8QbGcC8ZtlTpy2JcPv/1iGIR6Bnk57RWK W1lF/AJTtEgsHrvKBJTJpDeRGSeLNmAg2YBUj3BpVV4rrJiCW2Gl7eZYvnhIeauohcZW b8vZ9K3EMg2k/oG6osMxFQMFLSw/DZr3I1pPxonzZDrAQlfBkXEQS8Z4q71rIkGG1uOi 1r7g== X-Forwarded-Encrypted: i=1; AJvYcCUknaWPlxvOjdCIcrmHTNrb3HIHWVlp/my2pAh0g1vKrsjL+492SUicZxMfJqo6prFTGPRbe+k+lg==@kvack.org X-Gm-Message-State: AOJu0YyWOxu5m7tXIyjS6FtEXIALT5X/3L2lFkN000fVqrh8YoBNgTuw klISBCRR8Dp60XbGUW7YCKIdg7WPY2aWFwBvkQsxcVzthhgkohW+gISm677/OEy27kF/5Rkg7eV kfG19otUfp5rBMCbs0VP+Zpq3/wYdNrvJ2TcrAeJhbvnXYj/f X-Gm-Gg: ASbGncvSk7LJfbduZ+R2iVA+ZPivadTdKBRVeAwt6MYKrWRa9UvCgAfaewBbRywd1FF wXYE7A2dUFaKje8mZmzSNGqcOGYrPHmRH/f4wMaIabVrwqTXigKLrq7pY/OaO3cNupDXXDoACLw WoYx+qS6APh6B4txYcs7gg9l/QFKz8tXFS/6nrOwznUFBsnR2ecP44ByNPwn/gWXk5zArpkvPf0 OwP/JbxhYxQHJ9T1Hz3fyrsOxMGmq5YrIHiLyMb1NwZKIImnnIfpP2jDlTojm1n961uLjJtFlaE rHOMR4IaVLiuFYe2V7qHofEM44EY8riaxI+Gylz0OBOyVGoJUO/R3eJ3ATnI5o+SlscxSt0M02W H5ACRwX+z6wJ8IxRdrHmpEw== X-Received: by 2002:a5d:5f8c:0:b0:38a:873f:e31f with SMTP id ffacd0b85a97d-38bf5677ca4mr11799274f8f.1.1737401003563; Mon, 20 Jan 2025 11:23:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQYuFKcdC9xIlhDBXl6f5gjSAKXxEvjwcJY1WwcbTeTdkTYQiMJYO8oYApnw9Z8X+IB29t7A== X-Received: by 2002:a5d:5f8c:0:b0:38a:873f:e31f with SMTP id ffacd0b85a97d-38bf5677ca4mr11799256f8f.1.1737401003014; Mon, 20 Jan 2025 11:23:23 -0800 (PST) Received: from ?IPV6:2003:cb:c72e:e400:431d:9c08:5611:693c? (p200300cbc72ee400431d9c085611693c.dip0.t-ipconnect.de. [2003:cb:c72e:e400:431d:9c08:5611:693c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bfeb391ffsm8963906f8f.63.2025.01.20.11.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 11:23:21 -0800 (PST) Message-ID: Date: Mon, 20 Jan 2025 20:23:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm/damon: introduce DAMOS filter type hugepage To: SeongJae Park Cc: Usama Arif , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org References: <20250120191654.38420-1-sj@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250120191654.38420-1-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6_O2yDjTv1b3bzbSE9r276ehjndiaqXD5hTjClj82PE_1737401004 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BC26D1C0013 X-Stat-Signature: iidbzmr8g6dpu3k4krd78axptcbzb4fy X-HE-Tag: 1737401006-303728 X-HE-Meta: U2FsdGVkX1/s/yT/0eo5qCEC3Wsg1OUTa3kW7VhJUP0by68ZkqokJosh+Cd56UbVLC5fsXrdpcsmHa5pPjm+435EMi05pysQF9XnEE5a8ruz/Yu0eI6rT3D/RI4RY94jV4EMztBQ4GcnoRSJZZHbDRYZpZ9VjPQb8HIR+bA6YA94cyS3Hdt7xOBdjBYUvzS7HWaXjtaj75IrQ+y6U3eW9ItEv8XeGO5mBbhVLQp1J8xuy+PSpxMzn5nVFPYHzb3vuP1Z/qhphMxuEAd5Ho80KN4OrI1YapnvCcwzyig6X6HfcrT/QE5JSJyrrJ5/+iKCBz+LaU4jrwNN8Fxtl6Udy9n+aOhDe2YpRr/dYVPGmHsuRf3GvXZzJLKobaXn/fk+ycepRxp2S2sgiFxrXV63Af27VDRo+wlqcsYMhlgxdoX6TLLsvnV7D+q7RhRnl/dP6YRe7z4IjReUxmEDdAxcFhYiVMglXb19PGEZfcqvo4Naw2noJc0kIvmS5BVpD9ZmKpGfUsxq8Lz2fM4F1vc4U+IK+uHatang63mRpdIfuzyL/p0nHpZ3hom/GUJUnYoC2iGBvHysvFasu++6H/uxnbq0rlcuPaoVn06c/tzSJU+ep1DZvb+KdOxlNxACbpYTuu2SJja1/nvwFpzhjETlZTWiWHtMReWYe+jlUge4uW1s/Q6lUdnCUtBcPq/Uy+paBttVpYdJHKx+9MoBEBCQzTEWu+4Pq5/UmMORlSDcr8Hsz+9VBFe3ZjVdpLak1MhsFyf54JrG2A9lbCS1C19x/Htr1ayp6VAcRu6DCfFk+6E+EWRiOUgQOQ4pA+MVfhFh0NJMV54qUsx8+VOQLT37LkuSqEpM3CDpQlGqxQUlF98Dzg2cwdare4K+jau0gPJLfNLH4uQwgHHjGX01JkKrhEt+q37OHi0oMgRh5VhAbkFjr3AHljABJq3nZexu3MwwMiV8gL13GmyiL903aS0 V4GH+Gl/ IejVwGHoEd5nlVOGEuDB8rX/R8qvBnneIid0SnKe/POGfDgP8qJvUo6rXjd429GBj+Yu89qW6hi9Tylr6i6zg+tTkPjvvzoYG9l3lsPdTE+8IYsj1h0dvM7TEZH+RmgsiW39PjAUDsErvi32Pch9Qxa0qa21dKAfdaciPwduISUWd+bwFXmNhlui6rcLn/foxH7TV86pl9sFNGIg5pJMCiuUtzcg1Xwv51FPrQ0OIdScwe7FO0w/WIPLBptsBqlf8Is/wwtaMc3varxRNpu1y2V3n2c98Vo1/HHKk0a7NYLXpr847tseW9T8ZWIdtnau+oLNBFL2MeEcPwgRp/dQGMjMGGZ9OONYJfn8d6/E3ZfwyoxU/pDiSomRuG69XSd/mxnaK06RWgNZK3wSXSl93kyT6Bml1mbVqjK/KQKAA9wy1qipJjjqKihTrIti1UabsRKHf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 20:16, SeongJae Park wrote: > On Mon, 20 Jan 2025 19:57:10 +0100 David Hildenbrand wrote: > >> On 20.01.25 19:19, Usama Arif wrote: >>> This is to gather statistics to check if memory regions of specific >>> access tempratures are backed by hugepages. This includes both THPs >>> and hugetlbfs. >>> This filter can help to observe and prove the effectivenes of >>> different schemes for shrinking/collapsing hugepages. >>> >>> Signed-off-by: Usama Arif >>> --- >>> v2 -> v3: >>> - expose hugepage via sysfs even if the kernel is >>> built without hugepage support. DAMON will just >>> just return 0. (SJ Park) >>> >>> v1 -> v2: >>> - Wrap DAMOS_FILTER_TYPE_HUGEPAGE case with >>> CONFIG_PGTABLE_HAS_HUGE_LEAVES (SJ Park) >>> --- >>> include/linux/damon.h | 2 ++ >>> mm/damon/paddr.c | 5 +++++ >>> mm/damon/sysfs-schemes.c | 1 + >>> 3 files changed, 8 insertions(+) >>> >>> diff --git a/include/linux/damon.h b/include/linux/damon.h >>> index af525252b853..1d94d7d88b36 100644 >>> --- a/include/linux/damon.h >>> +++ b/include/linux/damon.h >>> @@ -326,6 +326,7 @@ struct damos_stat { >>> * @DAMOS_FILTER_TYPE_ANON: Anonymous pages. >>> * @DAMOS_FILTER_TYPE_MEMCG: Specific memcg's pages. >>> * @DAMOS_FILTER_TYPE_YOUNG: Recently accessed pages. >>> + * @DAMOS_FILTER_TYPE_HUGEPAGE: Page is part of a hugepage. >>> * @DAMOS_FILTER_TYPE_ADDR: Address range. >>> * @DAMOS_FILTER_TYPE_TARGET: Data Access Monitoring target. >>> * @NR_DAMOS_FILTER_TYPES: Number of filter types. >>> @@ -345,6 +346,7 @@ enum damos_filter_type { >>> DAMOS_FILTER_TYPE_ANON, >>> DAMOS_FILTER_TYPE_MEMCG, >>> DAMOS_FILTER_TYPE_YOUNG, >>> + DAMOS_FILTER_TYPE_HUGEPAGE, >>> DAMOS_FILTER_TYPE_ADDR, >>> DAMOS_FILTER_TYPE_TARGET, >>> NR_DAMOS_FILTER_TYPES, >>> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c >>> index c0ccf4fade24..224308140441 100644 >>> --- a/mm/damon/paddr.c >>> +++ b/mm/damon/paddr.c >>> @@ -222,6 +222,11 @@ static bool damos_pa_filter_match(struct damos_filter *filter, >>> if (matched) >>> damon_folio_mkold(folio); >>> break; >>> +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) >>> + case DAMOS_FILTER_TYPE_HUGEPAGE: >>> + matched = folio_size(folio) == HPAGE_PMD_SIZE; >> >> >> Can we directly embed in the name and the comments/docs that we are only >> talking about PMD size (both, THP and hugetlb)? >> >> DAMOS_FILTER_TYPE_PMD_HUGEPAGE or sth. like that. > > Nice suggestion, thank you! And we might later add more filter types for > different size huge pages. What about extending this to handle more general > case, though? That is, we can let the filter receives a range of the folio > size to match, like DAMOS_FILTER_TYPE_ADDR does. Then, the filter could be > used for any size of interest. That would probably be future proof: either a range or explicitly specified sizes (ranges?). -- Cheers, David / dhildenb