From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F06DEC021AA for ; Thu, 20 Feb 2025 02:51:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 724C24401C0; Wed, 19 Feb 2025 21:51:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6863D4401AE; Wed, 19 Feb 2025 21:51:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 501094401C0; Wed, 19 Feb 2025 21:51:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2E9954401AE for ; Wed, 19 Feb 2025 21:51:12 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C1657C080C for ; Thu, 20 Feb 2025 02:51:11 +0000 (UTC) X-FDA: 83138796342.22.DB078BD Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf29.hostedemail.com (Postfix) with ESMTP id 0C5B012000D for ; Thu, 20 Feb 2025 02:51:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740019870; a=rsa-sha256; cv=none; b=nnrq3Om6dJYZsdLcF+RMzTijGQ6ITd1Tb1A8PTh1cHp+1zNh1rOp4qd0SKhSwPXjWMJzer 1KUIULMU8DpVXx1gZ3hoH235GBY5kQQmsQbXT7/CXlxoxPIw7WZc4zSaJQIAzAppmYedD0 M1u4yym/4UmTn18F6dzOPTVXYF7/dME= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740019870; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fZTIEWqj/P9RTjUaQU07nFDPIovbeAZyf+YZ+TKKu/o=; b=qdQ597+v9/Mcqv+46agbb5S5j/0VxOkCpJmiEES62s+DvoSdPWiM9tLAvtSvjdWadXQ7ny Pegw+cbU137TCmMXby3eGGB3I6u/FYdrqZZy+aqtDHa33/RO2duzCTZCgu3whb31q76hiJ 3QdTfRbCPpPhJyAgSoYWFsfibWE8WmE= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tkwcX-000000005PU-477Y; Wed, 19 Feb 2025 21:49:01 -0500 Message-ID: Subject: Re: [PATCH v11 05/12] x86/mm: add INVLPGB support code From: Rik van Riel To: Borislav Petkov , Dave Hansen Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Wed, 19 Feb 2025 21:49:01 -0500 In-Reply-To: <20250219191519.GDZ7YtxzBiMxz3wwlr@fat_crate.local> References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-6-riel@surriel.com> <20250219120441.GNZ7XI2aWWUmXh2H2m@fat_crate.local> <2930024a88be186faa6a0338fc003e8ffefb710b.camel@surriel.com> <20250219191519.GDZ7YtxzBiMxz3wwlr@fat_crate.local> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0C5B012000D X-Stat-Signature: z7cp5nkdcitok3byd5xom5rkjik444ga X-Rspam-User: X-HE-Tag: 1740019869-935887 X-HE-Meta: U2FsdGVkX1/923T97eK+wXTbmOMX0pv45ThGbykL4OzlQ30Yc73CAMhIEkCei8zbNTd2wk8g/IkPVRmzmFlx/T4Wlo/hTS+H/biE+dPFtR0OBWhLh0q9uUJy+Ky6dzacHE4qSaLPoMTtVQXU8tiX6yhoypORCWeHv9tthsEN6q17aRKY5aHVwqSKELmtlDHxkVJPKOjaWTQEI+j5rlz9ofaSNL2LPmUdAi+DUwwByjfEOoce2H6eZ21Wmysw+jEw+1OZpL5ngRnPT9v8olBPSda+MYb2Tmz/fyBH3tOf8xkPBRreKnvCKf8/CkatLChtg8vxOskL1rxv5KAlB0Jay3Hr+oTkMmJMlc5OAR62eMn3JkwHaoQbzjRKPghSIVY7wqo0EPp8ZI9fbBVq1QZil7ganvfQVn44H7olFcMVPrGVVe6f18oEreNPJeTrbWgsXn758fU6BZXUDwKmCDeUyIsPDUCm6xkmYzJkMaUeVFf+k9EwEakQNrkUp0hDkPFpuqHuKfqBU3gECCemhWdnGevVxcSF04yJsEHmYeJbjgublAeZGFQoty+qWFNs1X0LFviT8rCvS5xyMepGEglktX1bzaVG8pohQOImi1om12rnN9rtM1m8H+FghUn616eSw3W4tO1oXiorciuv/PFJpGu9rY+5Y7QRS7VEB83yv8bEMJ/pLJfz4aQuzxLK1nzv/ErjInj0XSjRrmoONHHC/aFzFrW+qZIqKWkLMUUq4ynvnREYpg0iMdd+uV9T1PBIuA0xJSbCBRGkwgPnzYE6DEkID3dAUoCWA3FFthmchTItrQRQ/LJL+/vfF5TmcdF+8qBKucngXpOCW1ThAULFMWtMMUpc6GzUsVf05wwDcnHFjKej1SxIw87ftJ+WPKGmaL+FhhsRRSAAR0wwjrkmyBfgMfBLH8C2udcVYcd/CQUl7INmnnU/0YpkxQTAorwc5VvF9Fg/DdHgn5gFIo/ w/GlpZX5 uTg7L6m62/VFY2mfmp1Lb7mpOvPgvic0NGUywcw140tOAuR9mrC87gGpWk4T2SOjOuLznzPDe1JT13hFXIsEdNRafrpuGUSmGlFLJopK6M2fUTGO60MANxeld0PD9g8RMODD4wz352/K5KziTtSIQps+rJmW768syYu73xRCCr5cKi0RWXgYA3cjFXaFiB9dFqk/gz7583cbFgYgxrIseofSyCSV92asPYC3D1NFF0VqCrJf8qeX1q3bszsrYgObbxtXPhlpLXrfRe/pU518L1YXCS2lJwHBMVIuN1sypQKyEM85oCVGBFSI6oT5Sn27NNmYQIqTgn1KJEn5JQv3LSN7ISQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2025-02-19 at 20:15 +0100, Borislav Petkov wrote: > On Wed, Feb 19, 2025 at 11:01:17AM -0800, Dave Hansen wrote: > > But, either way, #ifdefs are a sign of weakness. Less so in a > > header and > > more so in a .c file. >=20 > ... and, as we just discussed and agreed on chat, we don't need the > Kconfig > option either. >=20 I'll re-do the series without ifdefs, except for the one masking out X86_FEATURE_INVLPGB (on 32 bit systems). Then the compiler should be able to get rid of the other code, when the feature is hard-disabled. --=20 All Rights Reversed.