From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D483DE7719A for ; Sun, 12 Jan 2025 02:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F06D86B0089; Sat, 11 Jan 2025 21:39:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB69B6B0092; Sat, 11 Jan 2025 21:39:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA5E06B0093; Sat, 11 Jan 2025 21:39:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BD1496B0089 for ; Sat, 11 Jan 2025 21:39:02 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2DDB04271B for ; Sun, 12 Jan 2025 02:39:02 +0000 (UTC) X-FDA: 82997242524.15.ABF83A9 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf25.hostedemail.com (Postfix) with ESMTP id 63ECAA0003 for ; Sun, 12 Jan 2025 02:39:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736649540; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GOGBVO66meGW3v4RGj5ZS/9NLKHggw4PliwpfSxJiko=; b=os4GUJshH8Nu+0JcjcGx8isW0dcPJNqTfQHR4qN+6vnZc4tC0pn7lcf0EC8SoSMipCa6Kx LhDdpI9xeljiS/D3hcrR8DJDbL9RfDdd3fIuuQrYyvxAEYX/DNcG2F5lqi+bFi8EtVApwd muwIdLJSM7ntF4SB18bWHPCJWvXuR1Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736649540; a=rsa-sha256; cv=none; b=XZAQxWm8+VEEFGRJmAAoQbHaM6Dk835OCKcLNlCydQIzsv7LWRssYl+2zoLL4hXzrmyuNt JTqjJOwN2EhVJCa7s4HPhRosdKhXDx6hD3ZaEZKQNz/ZXs4+hNLbMNXMwyzwqoZrLa2wSY cC76dTmlPVFJYgjD83PiF9ey+XM+2yo= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tWnqQ-000000000W9-2h7W; Sat, 11 Jan 2025 21:36:54 -0500 Message-ID: Subject: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes From: Rik van Riel To: Dave Hansen , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Sat, 11 Jan 2025 21:36:54 -0500 In-Reply-To: References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-10-riel@surriel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Stat-Signature: r15s97qk4b79zdw1g8nc4uoidodaeufi X-Rspamd-Queue-Id: 63ECAA0003 X-Rspam-User: X-HE-Tag: 1736649540-415352 X-HE-Meta: U2FsdGVkX1/kKaDST9WLOqPSq/imlHaxFUf3GCMHegW3VHZ6nTG5XhiE5br5mraq5svOg+vCdUm5TYPXvSYQMn6wzv63jcrti8NDFsIcwA5okMexKQHZgkv4RDgDnOMGB9SU/oOssGY6/MVqIaddI31TpuAfPGzj+QbPdF4GoR4EmRQZLq3jqdEKfc1d67R7QvOWkVpM4R1HoOpgEEU8Brx1tNa0t5b4m5QUun9JZ8mgKismeuG0Mrv3QHap9UX6YQ9FGDEocLzbdBWskxThWqIp52xkelfJlpLIofJ+qJzykf5OyH6Mm5IT581bi6hmizWZ6Gr7O1qMlXnr5bAkDKHeG0iHDOD/Ctq7rj3wMGgFLaxSi1bM/5r90uZPyqgBIpycoVHYNT7GbnDfgzq9AchSsUE1YWSRR0ubROchb4lsrTU+BYqJLX8Qavv4DLD8UBCAo5jy+RDVkD8crP1uV0RhKxMq2VtfRhQ6nz400uFLHyeWe198CT/c1+HJNql45opxBvgUwRFdTzBNLUihulezb/F5IQ9NxeWHMqhmH9HzSpeKGwfLDnfQM/1YqCb+EwlIvF63khuo9x3gXpQaiD8jDEEUVsHWsn3CekugT0aY9q/Jnv6l2lxsBgpeT5dT7PtB+X66LCOmj1RMsUGgqcWtD6rRP6OCeXCEFahzqlJI0ns6/QV18H+o1dyEovLAHldZeAlBuRqLRT6i7N+VuPKcsjmn8Xe3cADmUYWoRmHZwhjWat/mksrWUpjLJpnS3n+n6tsOKl8ANd1l/JjleSIugEStPI7CCXXtvdX1i+J01LPxpEPLLOrTpt6EOmfaO7NUZzslXTtLmrBwEIGy3EwmuJAui+Dadd7eQD5u33On5WVrOWXJFvyUmzhUx1gQgXv8UcYAWJdyUfWoYWC1e9QoBSFr+0pQBkRGaorvxoHebR1igYrOAKiJSjQZipND632MXP73zE0jy+DaPnE D6bVgzW5 7J8zFBUbI7Nb6TLXzVMieoBokzhGEKPZxqte3xAAZY9AChDttc6LoYhMy4BSv9LZXapI8SwgElYTZi7zC6WIsn5slQbEfXwGUY1hK3wLhkFQwnq/3eJ/5BTyA5VzB4d6Awd3NT5s0ZwopWFPB2LMwI3TMx9rnvngBUpDBew0JrXg6TpPY/qahc4cL8bNMFhxLnMQoI7Mlzbxi4SwjwvXsVvlLSke6oZi3tZKgCOsx2sIvfE6fNS76KRyW5KuXHItMdGL/4pt2eioQdeNoZl0uvRgLVtXqSRDkK6TB1wF2AtnBnTmbC1PG0pTRHYPENLu65rfZ9s/OEP2PeY6uPGd1b1AvaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2025-01-06 at 10:40 -0800, Dave Hansen wrote: > On 12/30/24 09:53, Rik van Riel wrote: > ... > > +#ifdef CONFIG_CPU_SUP_AMD > > + struct list_head broadcast_asid_list; > > + u16 broadcast_asid; > > + bool asid_transition; > > +#endif >=20 > Could we either do: >=20 > config X86_TLB_FLUSH_BROADCAST_HW > bool > depends on CONFIG_CPU_SUP_AMD I went with this option. I also got rid of the list_head (thanks Nadav), and moved the remaining two items into the same word as the protection key bits. I think I have everybody's comments addressed in my code base now. I'll post a new version soon-ish :) --=20 All Rights Reversed.