From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C71FC3DA45 for ; Thu, 11 Jul 2024 20:59:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 316646B008A; Thu, 11 Jul 2024 16:59:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C5DF6B00A1; Thu, 11 Jul 2024 16:59:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 119356B00A2; Thu, 11 Jul 2024 16:59:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E55D06B008A for ; Thu, 11 Jul 2024 16:59:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8BD051607FD for ; Thu, 11 Jul 2024 20:59:25 +0000 (UTC) X-FDA: 82328687490.12.54976A2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 545C714000F for ; Thu, 11 Jul 2024 20:59:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CiebzYfJ; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720731547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LZQ+a9DmpNAaUKr5Arm0el2gXwdPADPIa0ljBv25PlY=; b=SJP9pwQFSOEHL2Jz/OmHBbUa2DQnfjJLvKSQiiZ/vhpPMReN0sni4fhPPnW6hdwUQobINJ V5tFUKm9ixDO6tFXBJgKMCrHSF0jPZpYvVxvDuxvyVK0Rysf3BqxlSjU7ptSyfnVjXBh22 9uT8p8ihybJB3bBNfm4FzIsGY85CpV8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CiebzYfJ; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720731547; a=rsa-sha256; cv=none; b=Na3b0Rcwy1exTmaLIUmZPSAU3zJ1yCyvhRUJqYlaYGX/eaxVaTU+CKokEOOpqc5CA23Kbx UeVoC6uLp4qZkNu8JM871JDdcumejqxaqDDZej+LzaYW0RG6cqqhMAMqWemrm0hkB9l8Mw yAXQ4+akGmj2v/97y4DAJsgvYplVeio= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720731562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LZQ+a9DmpNAaUKr5Arm0el2gXwdPADPIa0ljBv25PlY=; b=CiebzYfJzn4VfbHCGrsTCeHZjdZKEo9M/2xLBsL8G5gOKYeMgQ4CAGHrPV5QTyk+Op05M8 u/KudJi6AOd1w3bqccjKycaNudLqQ/6RMFa0pROaL/HbVd1OvBwcttg4c6L2IetOlN4NBG ehZdiXbq8GB1HEKfzEEYmGX0AyPW17g= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-hfmqhBujPvCjekNbNn27Dw-1; Thu, 11 Jul 2024 16:59:21 -0400 X-MC-Unique: hfmqhBujPvCjekNbNn27Dw-1 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7036c416655so1153866a34.3 for ; Thu, 11 Jul 2024 13:59:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720731561; x=1721336361; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LZQ+a9DmpNAaUKr5Arm0el2gXwdPADPIa0ljBv25PlY=; b=Huu3cX2g/ZHDl2qCfZuKGnDBobgqH9jrn3cLnA15Jehso+J2hvn+Ayyed4xtCHUBCw PwdZouTfaZ0sAIARivBaltyfn3lddRV1LGCIo1V+nZobdP8Dw+0nlZF+2+hFk5wlZm1Y 4QDH51vKGX3GWAbs/xJUUX+MfYzEZWWy39zYQjIFfdA8k3VxbqE3iKgyV8CpNI+rcRGJ UCaqh2+8WRJYVtdCxxjLiRPlJ4B445AiLi0hAxbm9EkdURZaYIv+2clZy+rIlCwqEjfS FR6ZtOH0KqNCjUD9SDvpb4S1B3xDi3nH52VeKSNs708xLCIv5TSQU67C/VztoGRk6wnR 6rKw== X-Forwarded-Encrypted: i=1; AJvYcCXvsvyMDbvYqElFGBy3FrM17Dl80Lj1XKtSK9DcecRaUM4XL3NQE+j+Z3Lb5bBnuDEPxhaKMidxEWDutoZPW5kMekY= X-Gm-Message-State: AOJu0YwRorF9O3Bxs3uRKuh+IoYhrICbrZDrJRDZoX7WdlbSQQEunqj0 atZJ/DLihGeUvHAJHPuQj9SrnRsUcL1R/Br+gJXq4qwDSsiEfMB+6jQmXugG6PU8f8nRNpn+zj3 tuHTh8PlPaWM3unCSh7bFO/yn/FdSoG/wNHf3HrwXjmeXyYnv X-Received: by 2002:a05:6359:459f:b0:1ab:f2b3:f018 with SMTP id e5c5f4694b2df-1abf2b3f356mr829569555d.0.1720731560651; Thu, 11 Jul 2024 13:59:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IES9jTxXw9aqKIz5yO9tX4m+yDeq6TI47YACdc8XKO2Tsd7kHzFe6TfXf8OAFM3rZSFS7A7pQ== X-Received: by 2002:a05:6359:459f:b0:1ab:f2b3:f018 with SMTP id e5c5f4694b2df-1abf2b3f356mr829567355d.0.1720731560266; Thu, 11 Jul 2024 13:59:20 -0700 (PDT) Received: from [172.20.2.228] ([4.28.11.157]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-77d60117addsm4705877a12.20.2024.07.11.13.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 13:59:19 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 22:59:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v22 1/4] mm: add MAP_DROPPABLE for designating always lazily freeable mappings To: "Jason A. Donenfeld" , Yu Zhao Cc: Linus Torvalds , linux-kernel@vger.kernel.org, patches@lists.linux.dev, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell , Florian Weimer , Arnd Bergmann , Jann Horn , Christian Brauner , David Hildenbrand , linux-mm@kvack.org References: <54b6de32-f127-4928-9f4a-acb8653e5c81@redhat.com> <8586b19c-2e14-4164-888f-8c3b86f3f963@redhat.com> <443146f4-9db8-4a19-91f1-b6822fad8ce8@redhat.com> <1c8632b4-06a5-49da-be0c-6fc7ac2b3257@redhat.com> <2c464271-1c61-4cd8-bd4e-4bd8aa01fa00@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 545C714000F X-Stat-Signature: jqr8f5xt6wwraeg6oorzu6hi3hqyyspf X-HE-Tag: 1720731563-542399 X-HE-Meta: U2FsdGVkX1+88cXiAbHYkhVPkb3vsUf7msD24YkTLQdp5ktAgHMExm9zF9E/yliHAW2VC1MzqOdzYbmRvJI36pNjB8RnIJrWZgxbD0hlY4nCPciJzeuXxiuhIRjN+Yqcu9ge+nUvC3uu9N0Q5AXIxA90Q6SlWQUEwmaQq7thjTndD/DZO/UicWFxfUONSZ48D1z0PD6T+09jxEVaRO1EbmP/UT3gl49hS7KNBOwrpCQ72QoFi0L+hUJGP+oCa6IYwtUV/b70mghguoGtT3YHFy1PvdIW/iSilPrk/w5r9131NeCBdsziJizlAkZb5PcaAg7hJ+sx2D1iqf3YrnCpym71v2yGYStHwW99fEaAgzuDm8U1Ack8ekQEcbd5c7PpsMPOh+FY7QJIrfmXs9CuV7zxHlL1wVJ3gB7rVIZtxaLo8z2k4RLqjlLVgKf45rQkXUAF6joJTqxLgyo67gZHaAioxBDXQu51u1PLfMZMn8WQGpK+MePcbBDHzYHiEga4+5sfyBvR33SgUbhSIPJuNWAuDPFXHHjFskmVxjhz1FOIu07O0feyr8JwVE0Kw5VPOEfyxnCXwrXqTWmjrJ/F1PjBUkGITpsYnW3bGiBFaUXBXb9cgP6+GWDlyqTrm9avoIbxlua5gtiEHYtoT8geYJBRtGkOuy/wEZDEs3GeBB51dJqR8+T6FMN3yAT2ai+vJ8Eg1wAcrU384Kectrb/cqj07DuhQMWiqbT09qo3jIvES2RPDBMmpHlVvjPB/VYTEN/QajJBNPxDR/D/66ryvoca6R4xe8nEYm8vUg+JPoMaCAAQuC1982FMljznwKY1VcEOEiJfVRjxBCshZ0EMvc5dilFSs2dtj8+/CS3P22BUYDX6xtlxbwV1FnoK6mjYXin/1eYpAzg5K6SclgRnSHkyVDAuF6kfbUfu39HDZV7L+xR57+35IgPEFgrpXS5vdIXuxjUjpCbFi68ZuIA XL6i1RTw mi8ZyYlQgVTh2WnKE9Andi1ulkZVgffB2YgjA5kRMVbgZbfSJ+JEcwUFGgR7O69vGgOvknKFul7ZZRI24z2X9gruT3P9KGY7XRRhs0QpUD++HLtBJwDGPEik3lmkelXP+qXNyUmvFcZu0/h41V//su+pX1HawzsULRIcLQpguL9i91LZMxZ0C3cmnqpw6U+sXkZvsV73Dhtt+UuuzuyzbD8Krk6OMI/4RnepapcBEGFsphLYqWdhPYSUiyEXty7+RzY1YfmWjQzqv7yEodcLzy5GLXXX100DCGMr06+5gEln2FcWGGw6B0W+vTeXq/oGpNvOrhynEo2B4xcwl9CkcEltKJnVp8PZFt6gkmdr7uQqlbxPqA+0ozWQcevbfeF6obxXxkZ+Ss7y+ZgT13HE8mYUyaoVy7XqpFbkU4tUaa1EOJbDp4RSUNSewERraBF5C+xnExL1VSOQU4O0BZ7w4qnI8TKMZD8fBTuccPfhcKj2lGHEbODznwaXZXixUiLaPiWOunLEjPoRcUBjc1T/hNLNPSB9xZBSQXk4l3WVDD/pr93bVEepN0KmsMLUAtqcFR8tjInZQUOcPPE9bCM1K6bAl2FAxntRonodCkbfND+WV/Wat0GtVEILKXDw1X0O9FAZo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.07.24 22:20, Jason A. Donenfeld wrote: > Hi David, > > On Thu, Jul 11, 2024 at 01:49:42PM -0600, Yu Zhao wrote: >> On Thu, Jul 11, 2024 at 1:20 PM David Hildenbrand wrote: >>>> - /* dirty lazyfree */ >>>> - if (type == LRU_GEN_FILE && folio_test_anon(folio) && folio_test_dirty(folio)) { >>>> - success = lru_gen_del_folio(lruvec, folio, true); >>>> - VM_WARN_ON_ONCE_FOLIO(!success, folio); >>>> - folio_set_swapbacked(folio); >>>> - lruvec_add_folio_tail(lruvec, folio); >>>> - return true; >>>> - } > >> This is an optimization to avoid an unnecessary trip to >> shrink_folio_list(), so it's safe to delete the entire 'if' block, and >> that would be preferable than leaving a dangling 'if'. > > Alright, I'll just remove that entire chunk then, for v+1 of this patch? > That sounds prettttty okay. Yes! -- Cheers, David / dhildenb