From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9644AC27C4F for ; Tue, 18 Jun 2024 06:57:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B0608D0017; Tue, 18 Jun 2024 02:57:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2600E8D0001; Tue, 18 Jun 2024 02:57:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 102A48D0017; Tue, 18 Jun 2024 02:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E00888D0001 for ; Tue, 18 Jun 2024 02:57:00 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9F84F140338 for ; Tue, 18 Jun 2024 06:57:00 +0000 (UTC) X-FDA: 82243102200.21.F06300F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf27.hostedemail.com (Postfix) with ESMTP id 63A6A40016 for ; Tue, 18 Jun 2024 06:56:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hmiQTA09; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="4H4/l+xW"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=GYfee203; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6QDwu9Ll; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718693815; a=rsa-sha256; cv=none; b=YSBPrlnH8WT9mf7FNwmwWlEet4AJRzJ0bzJU/L7uCSVyLTngJ2bFiU55Kg+PCQr9Hb1Ag5 P+hlXSPeFm3RyUtdqB+UwAnYXPeWt7tbah4LJ/sRhEUOghQz85flc9AYX5gXStutHEUJUO Ui9uyNC7BC/P9l16ZskSzgie/l283hI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hmiQTA09; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="4H4/l+xW"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=GYfee203; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6QDwu9Ll; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718693815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Y4IEo+0BCAfVtmTwp25/ON1j1FWc+fWfSBByJ2vQjU=; b=G5cUbCvR2Y5VUMfjx09EksTKEMQ5VvsZ7am967hNqJhTfx3Yd/Efsq/YOUA6GevGlvHYZF AxuNt5L6lXS1mynca2penmsjWoarfzrDqyJyY6BYuqYGGj3Ggx8HyH+roOCdu2c7ANwm+J cGSx1FCUNVDCAI/HuCj4mjfk/hqB9JU= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E6B22219F9; Tue, 18 Jun 2024 06:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718693817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Y4IEo+0BCAfVtmTwp25/ON1j1FWc+fWfSBByJ2vQjU=; b=hmiQTA09n3cjaBFLpn/ZRRx3oGVIx7UdjssLQcVB20EKrWkusAxqjGg9IbGxjH//4fkFZs GH140FavkAqsJi7teviWWE2LN8KJ5kQIWP0XsXGctvz5q/Q8/3pobSs21yQpw/HnJMfWBU 5RxyeWKFvhZf6tF9BwNyIt35Gu6pbVo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718693817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Y4IEo+0BCAfVtmTwp25/ON1j1FWc+fWfSBByJ2vQjU=; b=4H4/l+xW9WhOEXRF6mJYGd9jB8Gf31NpLoa0FQl22moEXIniPo+3Vlxm635xaO22YHuiI0 jXAbRGOrVlNoJmAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718693816; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Y4IEo+0BCAfVtmTwp25/ON1j1FWc+fWfSBByJ2vQjU=; b=GYfee203pZGXTDaQzZHRoNPY84ww+D+XWRXmQZwQ5vgpTuE351IY61rZY+qDhYR6uDARDX u55z7Ehmxlw3GZwBUD3H9kxvXTNcun5jPlsYyWOqYkrKIK4uCIDeSLFPrOcxAZUQF67e30 zTGH9IztNSQspvWTRS1zIGl/injeQFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718693816; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Y4IEo+0BCAfVtmTwp25/ON1j1FWc+fWfSBByJ2vQjU=; b=6QDwu9LlFFj2jgPxC30eYLJ051WOxJxCkpB/Os2nsgaxHGwvasASmmL1LRk1gzlEcjeMQd JrUGPKxxpn4ypvAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DCB291369F; Tue, 18 Jun 2024 06:56:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cKsXM7cvcWY/ZwAAD6G6ig (envelope-from ); Tue, 18 Jun 2024 06:56:55 +0000 Message-ID: Date: Tue, 18 Jun 2024 08:56:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 04/11] readahead: allocate folios with mapping_min_order in readahead Content-Language: en-US To: "Pankaj Raghav (Samsung)" , Matthew Wilcox Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, mcgrof@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-5-kernel@pankajraghav.com> <20240614092602.jc5qeoxy24xj6kl7@quentin> <20240617160420.ifwlqsm5yth4g7eo@quentin> <20240617163931.wvxgqdxdbwsbqtrx@quentin> From: Hannes Reinecke In-Reply-To: <20240617163931.wvxgqdxdbwsbqtrx@quentin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ak7fzns6hto5d9qawge8ap563zugjxrb X-Rspamd-Queue-Id: 63A6A40016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718693818-584190 X-HE-Meta: U2FsdGVkX1+mqg21Q90JdXEcYFb4qX+RCkKmBHviOE8i5bm6F4qJOBoyoWnLbPQbqawL7fy44cviHiuhQ2jlAksAWj6g6VYagyiRRoK/6DuWy/qYqLJ5wxGcNwcCWj0aI1wOS1XBAXNJ6pnjn4qVTVMNthLMnmTTcDGb5S8+arpqMY3AXQQfrqGxspnDWdhh3PT/ceipmpeTgilHYSKQChaiwuAgMchTiIBf/DBE5rxTuY4y9uM1JO3ojg3hjsXyLG0g5k7F06w/xLyrP0t82rczidperzmGIhQB5wpLCViD0O9EIaoCq4EGddkiVT1Z5bx45rx4SlCROXdtOoM5y4wxj2f+JL3mSEcgSspiotSJvSIeNKnPJG3GHJendOYfrYQ6HO2tedjT+VwszHv3bY0aFA8V1P7+/7meaFO8ymh/pIV6Hk50KPApWFxZWUgx8uDN2ZJ8IPZb6C8nJl7CE9fm49C/fDv8nrrwxhCpk/ojgJv+Wu9hNTBhC/lgRKyNjin8RUFenn4WMoM9CiBT99K+KUEtrV8lGJlan0o3mQAmCwGt9eF5Ex8Qt69vzY88CPHNhnp1wo6u3tPyXbkgOWUDm7Mh41N+NmFycZ6YmAphaBKvqdcYtRd7B7R7tneY6/VV01obJQs6csS1OS4uvooGtgah5Ai5tAWbzrd4b+EbOPq3KMXpRnTgEE4LXrwD0sZlsXAQE4IB5Dyd3PX4BIEqVUmiKJCiSGFs2UH0+5wT2eYK6jyj2YODxHWKcJfKraMRqJJ9I9KzLPr8VUaHGE2RoTMdQtYjCCKuljsJYJn2ub9ZRhqzFxpqW00dTgGxty04hJPi7Lh4jkg1WRddVQrLYhhn81wkJQhM3t8os9vgeyeI2Kgrqh/ic2hbJ+RUGkgeJhEzQcyHmThy50OUKHzK7sf/ivTPIcRU/eFy15zoiYsrgA3I1DaqZm4LFtWBDypvWmJKL6OVqeoFvHg KJcstqL6 amyI2VbkPRLkZyMaEm5Z7RuwiNBpzX0fV3iT05y33LKjyj6YDtNRr1W0ETrPAMeaOwmJK8btqcWC2FSd81MxT7IhMg5cHZ6PE0VpfgX/So24UDsr9cw+tHAEJk8O+1I2zG7nL5Td+PFCKa86edRreexuyHigY/fEEgdoZ68iiSpvYwWU9RdJREjB5rsvu1vHCwPg2rZXMr0Hu3md9w1TuBRBocMTtdr5eaF032W1cUKMgwvgIXEAKFbgTQRL7tVdLMylV3igIpCpVuEs5ix1tGvoJDnOo9n6FWYZUzd0hqSx5GMgef24mciPQbqJrkkPr1pSbGQNiAP/AFg3TqCy2Kx8eTaqs/t5N0rkwox6rHNYvXrg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/17/24 18:39, Pankaj Raghav (Samsung) wrote: > On Mon, Jun 17, 2024 at 05:10:15PM +0100, Matthew Wilcox wrote: >> On Mon, Jun 17, 2024 at 04:04:20PM +0000, Pankaj Raghav (Samsung) wrote: >>> On Mon, Jun 17, 2024 at 01:32:42PM +0100, Matthew Wilcox wrote: >>> So the following can still be there from Hannes patch as we have a >>> stable reference: >>> >>> ractl->_workingset |= folio_test_workingset(folio); >>> - ractl->_nr_pages++; >>> + ractl->_nr_pages += folio_nr_pages(folio); >>> + i += folio_nr_pages(folio); >>> } >> >> We _can_, but we just allocated it, so we know what size it is already. > Yes. > >> I'm starting to feel that Hannes' patch should be combined with this >> one. > > Fine by me. @Hannes, is that ok with you? Sure. I was about to re-send my patchset anyway, so feel free to wrap it in. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich