From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E348CD1284 for ; Fri, 5 Apr 2024 06:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B4A36B0102; Fri, 5 Apr 2024 02:29:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 964B26B0103; Fri, 5 Apr 2024 02:29:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DE866B0104; Fri, 5 Apr 2024 02:29:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5E0326B0102 for ; Fri, 5 Apr 2024 02:29:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 06C5BC109D for ; Fri, 5 Apr 2024 06:29:37 +0000 (UTC) X-FDA: 81974501994.21.D72AD3F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id A8B8A180013 for ; Fri, 5 Apr 2024 06:29:34 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JPNsiJ6t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712298574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BjBHeErWk+j5gxPbRrMDf2q5dQkDSNhfFYSYLxlAj/I=; b=KIJYPSobzB66fC85C0NyU7CD5HON8IJBDTZAeI7ZSqqG51AJqRfQeuHsZ8jW27GcDBogaZ cW4XxHWaQtiH6pNtD0jhXOWhOIh8atxLOD2sYyf7lzCl0gOAeEZn+uL0eubUbUCcTL0kxs 1UuaXMl7uGdY8YcJ7K+XjPLiH0jJ45g= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JPNsiJ6t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712298574; a=rsa-sha256; cv=none; b=GjYsUjT2T9xvv/XIbbz398Qxr78VlwZQ/FN2JDz6LsBReVZ9Wyk99Ih2lQ5yay6qLUD4o0 h0z59S4qPkwgn+LY5CADnXpDeGl681HZo3sYt7zKyd1sitQB7tommjYSvEJSD2iSIEDeqV 3XI3Sla2O5tLSwa8EeVUIXv0yiSnIgo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712298574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BjBHeErWk+j5gxPbRrMDf2q5dQkDSNhfFYSYLxlAj/I=; b=JPNsiJ6tJ/PTmwkBpmkKD3xH+XBGyq5ce7GN8q7hyPm+Y21QONl+0TXBnqB9M6p2qjrcue nV97AhEIP4RP2H/B9nQ14t/thaqf125chBRhYna/bU+50m296sDWyN43AorQQEjUp6up96 Dj1fUNe4EwCBHWrvpG+7qIzG7dkqlw4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-qfOBySAoPBipSp5ZhmvnLQ-1; Fri, 05 Apr 2024 02:29:30 -0400 X-MC-Unique: qfOBySAoPBipSp5ZhmvnLQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3419f517aceso967475f8f.3 for ; Thu, 04 Apr 2024 23:29:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712298569; x=1712903369; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BjBHeErWk+j5gxPbRrMDf2q5dQkDSNhfFYSYLxlAj/I=; b=itvU1mSq8WCV9+xJLPTe7xPuxep/fTUo2h3nOsmVzI/xGI4sYfBnWdIoFaujpvtnMV lVM0WuKFj6BcKNUMW1ETO1Ro0gnydTdGiEY6PJead4wAUnhU0rDG+Nj2Ay9+hJ75QS4B pbGIoSzuy2YdQBBniH14j9KWQVeGDTVhQ3TBfhUnXSWJoIHF521FWzdjVmDUpPykFsAE cYMcmQAmOmttnUd583HE/SbsTGv8bKyBkgwq+haijPw/h7PI/2hvm82SK03/SKeqq30A lLu0Z23AeEw0zc6zseFQtFLVKbqnR6GpV0NASNBu7ENlvGY8z8EDNj3se3badMg0qMWg ZBAw== X-Forwarded-Encrypted: i=1; AJvYcCVIAnCsSbnMXh81tITx6s+1e3/836nplPROSnOgnAtR1O8J5QvDYiSL3qvVkRgOiUETQ5AoCf0s+VztZvNeaHi3rrg= X-Gm-Message-State: AOJu0YwPJvG/feU8T616Rd8RoeE049OWomwOb+BD077yOE/VodEXTprA Jbkb92PrvlUJSZDcYfuJvakglCTphv26Q8vbYX+OQrz4fsPFt/zcyOkE+n/+w7Zrs2MFWnPo+Mt EZGQL9mrffRbN5NuBXDCDxCpKY3dpVEh1dyqMThg6ER1y1xad X-Received: by 2002:a5d:5687:0:b0:33e:38f1:77f6 with SMTP id f7-20020a5d5687000000b0033e38f177f6mr365181wrv.39.1712298569385; Thu, 04 Apr 2024 23:29:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlqYRxdjTjuTUex33i0IJHS1iHwKTbfGrReyzE4CTg/MMTxumsoeeE0GVm1SkqvFNQZOFxvQ== X-Received: by 2002:a5d:5687:0:b0:33e:38f1:77f6 with SMTP id f7-20020a5d5687000000b0033e38f177f6mr365168wrv.39.1712298568882; Thu, 04 Apr 2024 23:29:28 -0700 (PDT) Received: from [192.168.3.108] (p4ff2306b.dip0.t-ipconnect.de. [79.242.48.107]) by smtp.gmail.com with ESMTPSA id j27-20020adfb31b000000b00341d84f641asm1207285wrd.8.2024.04.04.23.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 23:29:28 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 08:29:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: add per-order mTHP alloc_success and alloc_fail counters To: Barry Song <21cnbao@gmail.com>, Ryan Roberts Cc: akpm@linux-foundation.org, linux-mm@kvack.org, cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, peterx@redhat.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com References: <20240403035502.71356-1-21cnbao@gmail.com> <30392471-71f9-4eb1-8855-d9c12499346f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: c3gywg1fuib4541bith9kxjmakoo93x8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A8B8A180013 X-HE-Tag: 1712298574-589569 X-HE-Meta: U2FsdGVkX19j0OGTuDTnCxmVwX5bNS13KvdZ5W7SR+pUtdhqM5R8A9an5Y62qFSsMpSoqZEQP0pYWlMm4kCE4/+3UxsCC3r105tNK3rpLY5akR5vZD+fKvlurlJxmECp/ZJiFBNVar9cuQa7gbnWNkJOuh9T2gwR/TrMmj8V2Yv4wBg8leuntPGu4PQmRp4flP1uQhGudj/ym4glbZQCe1zWI5hqKGlci3iZw5yF15QqkPk5qPHI2y5Sg+W60ecKbkGbrZIdIMSdEpoXVZ+XqdWFQcKV2xzefE2H3D0XWbmXHehVVy1XOMXnTH1ZfW1Wl0J6JwxBeDy8hfdXvcXENsq7qlMLpq3CIzYrfYscFuKgqIlU07IhFLH/Rb32D6BQHpsi6R8zf7LhfPvgAdUMnQUDSbnC0jpWMIlgEHa/A9Dq4CsRtETPBcBYfVxweO62xEsrzRRWmU3Eq1J/vqbujVxCAPQRgLwrVNMzMC5PxBdKUl9FhVkeAfWSvvVTHDI42++Dy6ZmpGfvSDGDWzpfJDoMw5SBC+Mq7TWQ5QOeOo465pr5CbNDkaxvucbHFh8vz04vBAsjBooniOUwn+mOI4USCm9tDxwIBJ1VjetZHoMcOF2HElcCVGDp83vW05MA0pNXLPvimnLOC4OYrxksYNSxsM4oUdc7ECEXSGLuhlz86xLnZ2QKqpX//1Sqm7PW9unPrkJtVFl9uDooxjPeTlHqD7mEOVZRpKTUiihsvyj55EzdlMMkSMSiqhJuBOynU+49rL9/Cnj/qDmGlutLNMph3W/3S6POc+OxE5eMlkcslqyUbs4fxt17HcApth58/xgSaXhIK2KYfUqQZYO1UehmXhH6jgvlMeFC3tY42V9q6BDOku7u4E5tkHP+2IPKDAuLk+DtRDMnNnjZbbFA03IRie8S6DGCnb/CI0v+eAo1+qkRZFvB4I0Clq7ZjyK9hzWWzqjHZfqt9FwJ6U0 1h/OgLs1 LxyXK7/YpY3Phdn7DNihCiupNC0qGtYE4uUKe8c/+/lXYF5XX9iHCXzFt0heER0jT2yMbTqtn2zFgPns9T1c+P8jCntczXbyk1ZsLhEYRhPLMsIoxdNfcDlTKmkpoIdoHJXgwkVnrZ0KrvEIrRHLM0M3fzyA0mEdhCWdAXXvo0tE14enALZT86k5/RFvx1oFirRm1vIeiwVh8JFEqcl5h20stmyh0Ew0OcxRImtOmX4fyce1hwee4I1STh0z01vcoUREDLFDmJvu2MVAi/xkplHpAMu62qB/5u7CAQ/btama1kS2LYUwGI97qsklzqaqhuNRlC9VzIqtCnSlzCMs2kFxeOB6zKaH8Fw7qGUD19j6gNHq8Jo9/csEKUmvkwFzMizB3PeoREJZLFmc002a8TxX5PKhZse+grGFu+UyIIH3EFX0FBRBfGRJ0NYlduy8nEeTTjA6QmMiU4Lx7zpLQnmrbD2JlhNEHveX9IdvzEKiTnj2d5MCOfYzDUF0orqTX+YOMu2Mv3TrYZR9jG8NaR+aV7hYdSF0rr76ucg7g9DnoXvmAiNkSDPATpIdTn+/5fRXYBW10FZhsCo9xj5vhs2ove/6y4JERWhgs+zpk39nUqZ3qV2hWCzowaH0qPCkVVdN2yFQ9TudZR8VkzZHQbjn+FR7J+U3Abdcr+jux85Mtpm8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.04.24 06:01, Barry Song wrote: > On Fri, Apr 5, 2024 at 3:57 PM Barry Song <21cnbao@gmail.com> wrote: >> >> On Fri, Apr 5, 2024 at 4:31 AM David Hildenbrand wrote: >>> >>> On 04.04.24 09:21, Ryan Roberts wrote: >>>> On 03/04/2024 22:00, Barry Song wrote: >>>>> On Thu, Apr 4, 2024 at 12:48 AM Ryan Roberts wrote: >>>>>> >>>>>> On 03/04/2024 09:22, David Hildenbrand wrote: >>>>>>> On 03.04.24 05:55, Barry Song wrote: >>>>>>>> From: Barry Song >>>>>>>> >>>>>>>> Profiling a system blindly with mTHP has become challenging due >>>>>>>> to the lack of visibility into its operations. Presenting the >>>>>>>> success rate of mTHP allocations appears to be pressing need. >>>>>>>> >>>>>>>> Recently, I've been experiencing significant difficulty debugging >>>>>>>> performance improvements and regressions without these figures. >>>>>>>> It's crucial for us to understand the true effectiveness of >>>>>>>> mTHP in real-world scenarios, especially in systems with >>>>>>>> fragmented memory. >>>>>>>> >>>>>>>> This patch sets up the framework for per-order mTHP counters, >>>>>>>> starting with the introduction of anon_alloc_success and >>>>>>>> anon_alloc_fail counters. Incorporating additional counters >>>>>>>> should now be straightforward as well. >>>>>>>> >>>>>>>> Signed-off-by: Barry Song >>>>>>>> --- >>>>>>>> -v3: >>>>>>>> * save some memory as order-0 and order-1 can't be THP, Ryan; >>>>>>>> * rename to anon_alloc as right now we only support anon to address >>>>>>>> David's comment; >>>>>>>> * drop a redundant "else", Ryan >>>>>>>> >>>>>>>> include/linux/huge_mm.h | 18 ++++++++++++++ >>>>>>>> mm/huge_memory.c | 54 +++++++++++++++++++++++++++++++++++++++++ >>>>>>>> mm/memory.c | 2 ++ >>>>>>>> 3 files changed, 74 insertions(+) >>>>>>>> >>>>>>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>>>>>> index e896ca4760f6..5e9af6be9537 100644 >>>>>>>> --- a/include/linux/huge_mm.h >>>>>>>> +++ b/include/linux/huge_mm.h >>>>>>>> @@ -70,6 +70,7 @@ extern struct kobj_attribute shmem_enabled_attr; >>>>>>>> * (which is a limitation of the THP implementation). >>>>>>>> */ >>>>>>>> #define THP_ORDERS_ALL_ANON ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) | BIT(1))) >>>>>>>> +#define THP_MIN_ORDER 2 >>>>>>>> /* >>>>>>>> * Mask of all large folio orders supported for file THP. >>>>>>>> @@ -264,6 +265,23 @@ unsigned long thp_vma_allowable_orders(struct >>>>>>>> vm_area_struct *vma, >>>>>>>> enforce_sysfs, orders); >>>>>>>> } >>>>>>>> +enum thp_event_item { >>>>>>>> + THP_ANON_ALLOC_SUCCESS, >>>>>>>> + THP_ANON_ALLOC_FAIL, >>>>>>>> + NR_THP_EVENT_ITEMS >>>>>>>> +}; >>>>>>> >>>>>>> Maybe use a prefix that resembles matches the enum name and is "obviously" >>>>>>> different to the ones in vm_event_item.h, like >>>>>>> >>>>>>> enum thp_event { >>>>>>> THP_EVENT_ANON_ALLOC_SUCCESS, >>>>>>> THP_EVENT_ANON_ALLOC_FAIL, >>>>>>> __THP_EVENT_COUNT, >>>>>>> }; >>>>>> >>>>>> FWIW, I'd personally replace "event" with "stat". For me "event" only ever >>>>>> increments, but "stat" can increment and decrement. An event is a type of stat. >>>>>> >>>>>> You are only adding events for now, but we have identified a need for inc/dec >>>>>> stats that will be added in future. >>>>> >>>>> What about the below? >>>>> >>>>> enum thp_stat { >> >> It seems we still need to use enum thp_stat_item rather than thp_stat. >> This follows >> enum zone_stat_item >> enum numa_stat_item >> enum node_stat_item Right, we can do that. [...] >> ok. > > Hi David, Ryan, > > I've named everything as follows. Please let me know if you have any further > suggestions before I send the updated version :-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index e896ca4760f6..cc13fa14aa32 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -264,6 +264,23 @@ unsigned long thp_vma_allowable_orders(struct > vm_area_struct *vma, > enforce_sysfs, orders); > } > > +enum thp_stat_item { > + THP_STAT_ANON_ALLOC, > + THP_STAT_ANON_ALLOC_FALLBACK, > + __THP_STAT_COUNT > +}; > + Final bikeshedding: so we want to call all of that MTHP_, mthp_ etc, to make it clearer that this is per mTHP size? -- Cheers, David / dhildenb