Re: [PATCH v2 5/7] mm: list_lru: introduce caller locking for additions and deletions

Johannes Weiner
2026-03-17T14:34:19Z

On Tue, Mar 17, 2026 at 10:03:08AM -0400, Johannes Weiner wrote:
> On Tue, Mar 17, 2026 at 11:00:59AM +0100, David Hildenbrand (Arm) wrote:
> > On 3/12/26 21:51, Johannes Weiner wrote:
> > > +void list_lru_unlock(struct list_lru_one *l)
> > > +{
> > > + unlock_list_lru(l, false, NULL);
> > > +}
> > > +
> > > +struct list_lru_one *list_lru_lock_irqsave(struct list_lru *lru, int nid,
> > > + struct mem_cgroup *memcg,
> > > + unsigned long *flags)
> > > +{
> > > + return lock_list_lru_of_memcg(lru, nid, memcg, true, flags, false);
> >
> > And here it gets really confusing. true false false ... am I reading
> > binary code?
> >
> > I guess the second "false" should actually be "NULL" :)
>
> Good catch, I'll fix that.

That's actually "flags" haha. But it supports your point.