From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0652AC4332F for ; Fri, 10 Nov 2023 21:02:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73E1F8D00F9; Fri, 10 Nov 2023 16:02:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EE218D0005; Fri, 10 Nov 2023 16:02:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B59C8D00F9; Fri, 10 Nov 2023 16:02:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B5158D0005 for ; Fri, 10 Nov 2023 16:02:25 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 05C83120F3A for ; Fri, 10 Nov 2023 21:02:25 +0000 (UTC) X-FDA: 81443267850.06.34CDE55 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id F2DF51C0007 for ; Fri, 10 Nov 2023 21:02:22 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SbVTDBXE; spf=none (imf21.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699650143; a=rsa-sha256; cv=none; b=MqH/WYQaF7C8qXJvgiLMU38so+tadIfStnpEvs4X8b3pu5mAC8rFzexMa0aN/NMz1gFk0n 00jaJqOw55UzPjAe0C8CQm11pCvBBR9b1x+hCnjRXbQgqJHi34Ls5s4OZ4xMS4jO13bAuA 3Y7kW3/oNqAQzM3TYDoOMDiQontNSvw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SbVTDBXE; spf=none (imf21.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699650143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ciYCEHiStEhiV9bzFF69iuJLlDU5uempC1NU0f76Ntc=; b=zztHCKv0dcGDQOTPHBItFtrArl8aHFlX4QoHw7yBwwZNzw0eEWwqxMu6W2urdFv9i5X3i1 qKn3d9JMUpfqkNRytOt5iQw6YD28XzC2rafQMSpak4RImdzf0SgXiaiPiXrSVFLl58hCuV w8kQkYPHAkw5YCLgHd9g6VnzrAoHpuA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=ciYCEHiStEhiV9bzFF69iuJLlDU5uempC1NU0f76Ntc=; b=SbVTDBXEpdDKR34RZ9GglRImS0 fR01/rYEiniFGMXNRyWd4qTa2uOkHW5nEr+OQ7XJ9veY5GfVFGr4mgELoHlIA8lugGGBwxxhJ9j/T k901DX4UztXnSemAzTFct9RFZIB0WT40JwmniThSmjUCO3hsTmJDtnLr/ZK8WXYG3z+p3HmKC+Cng rWq1/27zTCC1oayECyni8O0C9ObbJVE8Sefos4kmGvvwdWLLZY+o1cEjn2PH+SycvXbkrGdqeF4ZB W92sUrMC0VZbfciJaHZI8RcxBvXBfdPjP/l7x5p9eKiNMGq+1s5oSritU4VD5/C1EEgHa4/jRV8xV VfWm4yWA==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r1Ydt-009RVi-0g; Fri, 10 Nov 2023 21:02:17 +0000 Message-ID: Date: Fri, 10 Nov 2023 13:02:15 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm:hugetlb_cgroup: Optimize variable initialization Content-Language: en-US To: zhaimingbing Cc: James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <785e7f99-ccb9-4640-b554-825061f73ee1@infradead.org> <20231107211307.14279-1-zhaimingbing@cmss.chinamobile.com> From: Randy Dunlap In-Reply-To: <20231107211307.14279-1-zhaimingbing@cmss.chinamobile.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F2DF51C0007 X-Stat-Signature: cwm6gqup8ppxbrxu3abgdh8ymmm5tpwj X-Rspam-User: X-HE-Tag: 1699650142-512786 X-HE-Meta: U2FsdGVkX19zEHNQpu43mNHa+OIymWjlg6SuapjnjXORV41qRv+JM7GLFE2a/kBifTe3k5VExHDh8UfgNG4yPD55CrmIK8n2+mX0Baci1qiSH9PEEeiAiEcZoJecs8mo5YMb8LwU8vvBntXqjE/8mIzB7/HZRxRib8NglTIBKkapopNBH/XvIYJRWAmy3dAEctkl5wo/mDwVkeuOLWHo5nNrkP2FzROXTd+4Z+DsZjzIAUL1f/aY7Kli/8HR5996zaEuz52eri4I2fPgQEMfELkjA7WP7jFEpNiModxMZA6LBA8jxyFlYOjkX+JHaqnNDhWy3MZ5rLTMtTvXHx02FTRYqJVzZUNRvbj+sDhNrVtr0+ZYVxj9evAq3CEC0rXctsVL7LO7xtUm55W7QyLpb9gLwx+rg0XxHOaTXA8Esb+DiMkopV223DevSLhkIXmqqg5yIVO8KsD7jYJxVBBhd9nM5EPoYfiCHrjGbS+TcQQQgdI6e5nrJ9TJxPiXPqARgieX+aJktLlQuBhxXohfEpNQM4ae46mnjIDm60Z2tYpWWTrCaOuDy4+8hG9gRvVs0AGAk9jTmVCNNTXrZVGmS9d+imfvdppSx9q1D5F5NVrOtXbxGX3ERaZye4QSqAXoasMtKT2BTb6e+YttABgdL0gqgxRF6do/Ujs75drscaY00TFv4/+C4VDmPcnWsSrNvak0Ea7bSchIdG0Ovn2mYXgKpq6oda3J2DOnBr9/zalRqbCeI4xEzXFXFWjyUgEfNEgWHR9hPjX+X634Y+4rEhgIxmbmgMyW3/Cdc6JXoJouV7wwpfiA7mDaiFXDmcpihjnf0+BW7T9JVaX45HDWwqcPgzKaRci6h07vho3zQ47ob8SqJCXMZqovq3jx20f87bV1L1GJvXDdhqL8xCZTuvdtNA/QqtLHaML99tgSyRK3woZaMdHTwEZFzYx5GjV804GLTYLvxDkoGLwt7XB adoIaFSO 8kMsLadYAYqAaaXWCTW06FqCRQU8K+2pOvbx1O3t1dWZtk2kS8rxPBRnrGk/PQYtafI4jaSyI+9jJY+m/JoUQ7CQbFLGT8SbCzVl754/GsHvLiFC7O8FkAO+2fBvtFGR9saBibEs4xAHWRzLX8DiQ+z6RT3WC1kquR06i5FBvqr6J1TVTtURIh+/8TJK4R0NU3cQhkSR8C3U/EOZriKLuMlX77bXPSOUcWBgxyUOO1z5LqRE7u06qOdKUS+OhnDcIWST6bPssNj4B3tJOk2wqU9nkD8hlBm4y3DVW1cyncJUhSnQ+kOi9tiqHk/27i2i4MaH3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/7/23 13:13, zhaimingbing wrote: > Initialize 'max' with 'unsigned long' instead of 'long'. > There is no variable initialization here, so the $Subject does not match what is being changed. Also there is no description of Why this change is needed. > Signed-off-by: zhaimingbing > --- > mm/hugetlb_cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > index dedd2edb0..d4ca2ac55 100644 > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -685,7 +685,7 @@ static char *mem_fmt(char *buf, int size, unsigned long hsize) > static int __hugetlb_events_show(struct seq_file *seq, bool local) > { > int idx; > - long max; > + unsigned long max; > struct cftype *cft = seq_cft(seq); > struct hugetlb_cgroup *h_cg = hugetlb_cgroup_from_css(seq_css(seq)); > -- ~Randy