linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Pedro Falcato" <pfalcato@suse.de>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Hildenbrand" <david@redhat.com>,
	amd-gfx@lists.freedesktop.org, linux-mm@kvack.org,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Jann Horn" <jannh@google.com>
Subject: Re: [PATCH v4 2/2] amdgpu: delete the "Failed to register MMU notifier" message
Date: Thu, 8 Jan 2026 15:20:29 +0000	[thread overview]
Message-ID: <abf1bd1e-22f6-4cc4-b6e5-61fad2a82901@lucifer.local> (raw)
In-Reply-To: <20260107203230.880324802@debian4.vm>

On Wed, Jan 07, 2026 at 09:31:15PM +0100, Mikulas Patocka wrote:
> This error may happen if mm_take_all_locks was interrupted by a signal -
> the userspace will retry an ioctl that returned -EINTR, so there is no
> need to report it to the syslog.
>
> Christian König suggested to remove this message at all, so let's do it.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

I don't really see the point in this being part of the series here... seems
to me a patch that could be applied any time, so why not send that
separately to the amd driver people?

I mean maybe it's not al that important but still.

>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> Index: mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> ===================================================================
> --- mm.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-07 20:09:51.000000000 +0100
> +++ mm/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c	2026-01-07 20:12:11.000000000 +0100
> @@ -1069,11 +1069,8 @@ static int init_user_pages(struct kgd_me
>  	}
>
>  	ret = amdgpu_hmm_register(bo, user_addr);
> -	if (ret) {
> -		pr_err("%s: Failed to register MMU notifier: %d\n",
> -		       __func__, ret);
> +	if (ret)
>  		goto out;
> -	}
>
>  	if (criu_resume) {
>  		/*
>
>


  reply	other threads:[~2026-01-08 15:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 20:31 [PATCH v4 0/2] Fix failures with signals and AMD OpenCL Mikulas Patocka
2026-01-07 20:31 ` [PATCH v4 1/2] mm_take_all_locks: change -EINTR to -ERESTARTSYS Mikulas Patocka
2026-01-07 20:55   ` Matthew Wilcox
2026-01-07 21:29     ` Mikulas Patocka
2026-01-08 15:25       ` Lorenzo Stoakes
2026-01-08 15:33   ` Liam R. Howlett
2026-01-07 20:31 ` [PATCH v4 2/2] amdgpu: delete the "Failed to register MMU notifier" message Mikulas Patocka
2026-01-08 15:20   ` Lorenzo Stoakes [this message]
2026-01-08 15:30     ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abf1bd1e-22f6-4cc4-b6e5-61fad2a82901@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=david@redhat.com \
    --cc=jannh@google.com \
    --cc=linux-mm@kvack.org \
    --cc=mpatocka@redhat.com \
    --cc=pfalcato@suse.de \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox