Re: [PATCH v2 1/5] selftests/mm/guard-regions: skip collapse test when thp not enabled

Mike Rapoport
2026-03-16T06:19:10Z

On Mon, Mar 16, 2026 at 12:43:31PM +0800, Chunyu Hu wrote:
> When thp is not available, just skip the collape tests to avoid the false
> positive.

... to avoid the false negative

> Without the change, run with a thp disabled kernel:
> ./run_vmtests.sh -t madv_guard
> <snip/>
> # # RUN guard_regions.file.multi_vma ...
> # # OK guard_regions.file.multi_vma
> # ok 89 guard_regions.file.multi_vma
> # # RUN guard_regions.file.basic ...
> # # OK guard_regions.file.basic
> # ok 90 guard_regions.file.basic

It would be useful to include output of two failing THP tests rather
then just the output of the last two test.
You can also add '-n' option to run_vmtest.sh to reduce amount of leading
#, but for that I don't feel strongly.

With that updated

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

--
Sincerely yours,
Mike.