From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5CBD6D255 for ; Thu, 28 Nov 2024 02:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C558E6B0083; Wed, 27 Nov 2024 21:32:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C05FE6B0085; Wed, 27 Nov 2024 21:32:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF42F6B0088; Wed, 27 Nov 2024 21:32:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 919296B0083 for ; Wed, 27 Nov 2024 21:32:29 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 00E0DAEF4B for ; Thu, 28 Nov 2024 02:32:28 +0000 (UTC) X-FDA: 82833929598.27.BB6BF82 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf17.hostedemail.com (Postfix) with ESMTP id B54E240009 for ; Thu, 28 Nov 2024 02:32:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Z9yFp5Il; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732761144; a=rsa-sha256; cv=none; b=m3zs79myBLCEX/cWzEKEsI75bxsjylJIbtqoCUgj+DPMIuETndGKxYy0S7egcvIBYAEw/U wGbMAY+9nwMapDW5NW3QuvHy8RhhZ9HtphoBUbFCTUZ/5oJzjJjTZGuwdAkyc8JVapQXNw 2a/wITjiSYE6aFUCEZ4YcjEWfYUuKVc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Z9yFp5Il; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732761144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EnffHKnBprsXvLH02UkVO9BmPdsjg3eRtoSxQDZ8h+s=; b=YxXblIFD8ypF7oZMpLsKKdgsAxpyefjm2KCqixK8ehXgzdK0os/Sp93QxPZx234YqBN+uq r+h/CBS7AZdKboCjC0VrwgeNL2FsWk25DfcAeqPXHND+iGnoeu+y//Zkjlbre8JFRwLSax UmCi18a9fUrwp4ruz3Salay8UPKZHzo= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732761141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EnffHKnBprsXvLH02UkVO9BmPdsjg3eRtoSxQDZ8h+s=; b=Z9yFp5Ilf+kf2Qx8CfWNnxrfu9HwMxI95bknJLcvEqnv7thAViIxQu8PJV74nP4zWtLXPV t4CWSACLrZH5wm/SNmRrhyDTU8x7KZ5ttOIpCuL63eKDqyRqVpoTrvGYLMGrmHZo9hDtDo CK9Ad7gNRlhfpRVwzWfGUtHIxBZthiQ= Date: Thu, 28 Nov 2024 10:32:09 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm/zswap: add LRU_STOP to comment about dropping the lru lock To: Alice Ryhl , Johannes Weiner , Yosry Ahmed , Nhat Pham , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241127-lru-stop-comment-v1-1-f54a7cba9429@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20241127-lru-stop-comment-v1-1-f54a7cba9429@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B54E240009 X-Stat-Signature: o9b59q6f9cukbs9oxkxtnzju3d71fef7 X-HE-Tag: 1732761140-450617 X-HE-Meta: U2FsdGVkX19zjYizG79IwGLu7xhh+4g9AXQNLd8bpPGA+P4abZsImPOPAy4Kd0pcNH8/UfPalzFtEhGNXZimUqxPvuaBIK3f6yhuHUbg4H0aqD4LoYlMn7Rkjk5LQW5Mqbis+f2v9U1tgfMoNQalWRK1YufpJ2Q+4xVcYf0ouehqEtPnvJaKT8ECHD6UvkM0eZy7vB0AAok04HFyb9s1oVQix/Rb7WfhMP1pTTdVQjTPG9p5ITIbgpRS8TwyFOm9fqleBvY8rXHzKdzEzR0FrTgjC4y0DPQ5faCO9wSNBuydXfO4+A7aSoLqA6NSrsHou42Yt/F5HF7ICLmXM0sAObqL90fqtKEupWwuhYgrvWBSZNcSNEL5Oyyv+uxCXtdAXhEHhOXsCJF+Fca5g9MI12sxABRNr53SZcNVoYakslyhSaY6jojRJM93jwnN2ZH79iNZo59KWHFRUu/92DIaljmC10QdVnA2kShZgds02s24DDw1hrBmb/a07AjEylJlRaWonCDgcRUGCAAXiLEoFc6OeB8f2Ibc+B37UcyoWfA3v6+ddHY7fV5TO9FkrmXC9wLjfkM23djfPLn/VDobAFPWfeEDnpb2z+NZwJER0QJ8k29g1vq6TOXoWVY9iLc3sPl6M5wUNbIK7Q1+4Qi9KvRJEMD7wrUuKKAF3dzGRjCaqECb2EYu5H94QDwahYluYj1kCbluMTTVqBuT3WsLyjzYGKUh+gHryTrT4QiLE9xxWZ4YTE6tyttzCAi4q+4ShLJGes+ZLEIBpmGAzw1Dzj9V0ZMlQNHFiLXzCs6FmByg+tem7rLOfjMDRAzE6Q6uiAoZiMzEFPIN8V3u70seqyBkFzCzjnEnCoMoaNdBhOpdNcFIy1b0TsVQtEjN1weptHSHQMlzc1UrJ2qlhcRSgP9kHGTqJC+xf98X6vjOQvzHO6AxicYTc/foe+PM8psmtwOnH5nROEm1aNvDbkF QRdx5WOJ j/b9upucSlNclxCIxpax2xCe0z5dUHf16VG/8DPZubv2oLfuROAOsGR2n/CZH/DQKlV1LQcAblfjvNXZnkAqZwFMAt1EYGDP8ghf0C+z+TL/aqou3O/V5ekZnv38fjqc5p3AcpHD2kmt8zNWlqZJSpNptwV/lSATCg4oUhHEFnnQQ/oyGbxo4N+Fq7VTrdvX0LBGsPbFbBQDVkzRDIEtqHyFErP1beUq2nCTI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/11/27 21:53, Alice Ryhl wrote: > This function has been able to return LRU_STOP since commit b49547ade38a > ("mm/zswap: stop lru list shrinking when encounter warm region"). To > reduce confusion, update the comment to also list LRU_STOP as an option. > > Signed-off-by: Alice Ryhl Reviewed-by: Chengming Zhou Thanks! > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index f6316b66fb23..9718c33f8192 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1156,7 +1156,7 @@ static enum lru_status shrink_memcg_cb(struct list_head *item, struct list_lru_o > > /* > * It's safe to drop the lock here because we return either > - * LRU_REMOVED_RETRY or LRU_RETRY. > + * LRU_REMOVED_RETRY, LRU_RETRY or LRU_STOP. > */ > spin_unlock(&l->lock); > > > --- > base-commit: aaf20f870da056752f6386693cc0d8e25421ef35 > change-id: 20241127-lru-stop-comment-09dab2427b6e > > Best regards,