From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BDAFC19F2D for ; Tue, 9 Aug 2022 08:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 558796B0071; Tue, 9 Aug 2022 04:32:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 506DC6B0072; Tue, 9 Aug 2022 04:32:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F5A68E0001; Tue, 9 Aug 2022 04:32:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 304936B0071 for ; Tue, 9 Aug 2022 04:32:54 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CD6C640317 for ; Tue, 9 Aug 2022 08:32:53 +0000 (UTC) X-FDA: 79779388626.19.608EB3D Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf10.hostedemail.com (Postfix) with ESMTP id E747EC0054 for ; Tue, 9 Aug 2022 08:32:51 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M25qm4dsvzmVJS; Tue, 9 Aug 2022 16:30:44 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 9 Aug 2022 16:32:47 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 9 Aug 2022 16:32:47 +0800 Message-ID: Date: Tue, 9 Aug 2022 16:32:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] mm: add warning if __vm_enough_memory fails Content-Language: en-US To: Andrew Morton , , CC: David Hildenbrand , Yongqiang Liu References: <20220726145428.8030-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: <20220726145428.8030-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660033972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IBxHY7rMJWNEq+B/876Rw/n35o+ISRotZQmrXwHhI+c=; b=07cbzZFVSElN/I2oVFc/R/Rubi6HQ5vqgF8aTmR6tLvgDwl9j+gpZWdEktXBNBAFOqlE/A aOs8Gaq0GAR0C/x1nzwmmkWLmCGc4VWPiSBM106dwYqdYih9mQT4D5Zm/kJ/Lj6tIvsfOn 4oJf4Dm2wVnazl1D4MytF9dU5KCWYiY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660033972; a=rsa-sha256; cv=none; b=cJd+Vqo45Re8mklBFhzhQaMKnhQnmx4J1SBsJ6aPZKNd4hoN5G+jYGt3Pnrx3qG49z/TgV Ea4QWVZX/goOTLQXHz0mf8xNxjD08VE+HvcH7jsEh2vAC9yCN7BQZDT38rXjZdSPnF5yJB Giz1lqyKuThC+Z0aqKDgiDNj8TlJYKo= Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Rspamd-Server: rspam02 X-Stat-Signature: q3mjf9y77pzdr3et3q7waumzzukdbeuo X-Rspamd-Queue-Id: E747EC0054 X-Rspam-User: X-HE-Tag: 1660033971-303950 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi maintainer, any comments, thanks On 2022/7/26 22:54, Kefeng Wang wrote: > If a process has no enough memory to allocate a new virtual mapping, we > may meet kinds of error, eg, fork cannot allocate memory, SIGBUS error > in shmem, but it is difficult to confirm them, let's add some debug > information to easy to check this scenario if __vm_enough_memory fails. > > Reported-by: Yongqiang Liu > Signed-off-by: Kefeng Wang > --- > v2: use pr_warn_ratelimited, suggested by David Hildenbrand > > mm/util.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/util.c b/mm/util.c > index 1266a33a49ea..c786e21c6051 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -1020,6 +1020,8 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > if (percpu_counter_read_positive(&vm_committed_as) < allowed) > return 0; > error: > + pr_warn_ratelimited("%s: pid: %d, comm: %s, no enough memory for the allocation\n", > + __func__, current->pid, current->comm); > vm_unacct_memory(pages); > > return -ENOMEM;