From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3DBE7716E for ; Fri, 6 Dec 2024 02:08:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 716026B0161; Thu, 5 Dec 2024 21:08:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C60D6B0162; Thu, 5 Dec 2024 21:08:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58E3B6B0165; Thu, 5 Dec 2024 21:08:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A6476B0161 for ; Thu, 5 Dec 2024 21:08:29 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E43251217EE for ; Fri, 6 Dec 2024 02:08:28 +0000 (UTC) X-FDA: 82862899560.05.30AAEB0 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf08.hostedemail.com (Postfix) with ESMTP id B0016160007 for ; Fri, 6 Dec 2024 02:08:14 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733450896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jp1UldtQg/sxnjp95rqB+nqKGiul0NUJcNyDqulKvw0=; b=Ff2RAIqetWQk6VaBaKvrLU0JGxGx/Zp9HigvKfGy+/MsVwKXD6EbK2iYCnTWzUliyDk+Qc gIHnWTjA+dGq8QFOeGj9iXZexSepjzZMt846Alu9Or94/Zl3LmnFFPsRDzu0c0K1BGBu90 AH4qDUsVreGYHgbq2UX5meF6J0cLeq8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733450896; a=rsa-sha256; cv=none; b=oq9vXLT5t2OzNUeGrGyux697l4b/CZZR26V52yO7xmwcIONPn5z4z++mQMbH/OdkmP3cbK 8Lt8kJGzRmYdauC6D9+DhnNY+agkCQfhxb0RTPswYyyXKFIkL11ovKyCZFzNo/L/CyqnYS xD4SPur6iGYt+iWmYS9nUldPwIYUJWo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Y4F4L6SHSzRhnj; Fri, 6 Dec 2024 10:06:42 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 3692414022D; Fri, 6 Dec 2024 10:08:22 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 6 Dec 2024 10:08:21 +0800 Message-ID: Date: Fri, 6 Dec 2024 10:08:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() To: Andrew Morton CC: "Huang, Ying" , David Hildenbrand , Matthew Wilcox , Muchun Song , , Zi Yan References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> <54f5f3ee-8442-4c49-ab4e-c46e8db73576@huawei.com> <4219a788-52ad-4d80-82e6-35a64c980d50@redhat.com> <127d4a00-29cc-4b45-aa96-eea4e0adaed2@huawei.com> <9b06805b-4f4f-4b37-861f-681e3ab9d470@huawei.com> <113d3cb9-0391-48ab-9389-f2fd1773ab73@redhat.com> <878qu6wgcm.fsf@yhuang6-desk2.ccr.corp.intel.com> <87sese9sy9.fsf@yhuang6-desk2.ccr.corp.intel.com> <64f1c69d-3706-41c5-a29f-929413e3dfa2@huawei.com> <87v7x88y3q.fsf@yhuang6-desk2.ccr.corp.intel.com> <20241130181546.0d4d95e2ad9c0be707f54a50@linux-foundation.org> <87ser8c6ai.fsf@DESKTOP-5N7EMDA> <95c61e7d-2572-46b8-89f7-abab8ea1b7c7@huawei.com> <20241205174705.99acb4e658cf8f3f19c0fa77@linux-foundation.org> Content-Language: en-US From: Kefeng Wang In-Reply-To: <20241205174705.99acb4e658cf8f3f19c0fa77@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B0016160007 X-Stat-Signature: wj6zcx78eeft1punfcdap8xxeao36apk X-Rspam-User: X-HE-Tag: 1733450894-214164 X-HE-Meta: U2FsdGVkX184F6q+/4jIK3TkKnQTJDXTgyTllizcKvWU/dqhGcu5y5P93bID+OEk43q/jPrDdopFSSW1zqXiM43XfV1do0KAcTdoeuZhQ3VreP2GtK6ZPYGIEgS8jq/mD1anKtmRrBR78gQCH6NYHcp5jQf7EwkwBg7SJ7WdrCaoby1mkgvrCOCwh11xj1bR0AkF98ip8Sqn+D/vzDjptYibNtgCTpPCAgwJzDxv2ady24JvIKOrHSsXtwgYz3mjjKRIyqYsr4SFg+O0QiIWXeepOqfXUD2XYoWxozmjTKCsdwt0uZx8cwP6+q1uCZ4EXdO92SHr9esE5+gTZ2I/VYWx5dcKOx9mY4ZGH+iZT8JdSnhTz5NEHsXoDPlyAPI8exkXID+5MKCxBRkeqYmcBwYjZ1/iyh0z96cHzLpUhzD3mtQOkNrpqszfrjudK5JHtoDT4Qi6lGPkUgbGVWu/npsFUdqJ8ypIOi5W5JzdhDr48QxXBNOzjP/VcL3Dy3yLpLaNnW/O+1FA/rQe2Of6/QG5bFpyjqUC4RbmjlzidSbgm10H5pqHITD9Ai1SLqrgvS8K2Vy0Fu0qmBo227qDTVIPOQO+/4Q+jZAYdVfJECpWpFhF9LKbwX2q0/tr2yQnURp7m4K+6kOvqM95m1Lo5PBDhTcTXF/f4iearBvoNdYpRcxkaS3Y3uXf09cnt79KNLjE6HYfE78uoBKJ1rS5gm9Uh6wRBUXCiQbOarcsMSZdX3FLyDukx3LwJQqH8PK+8MmZh8BG86+ApLyAo8VU0O07/wkXXua3S6+OZUklsw+2tnaDgjvGYxkbL4+b1PRJTFDROrLM+JcBte7t2R2PBGSgaMkPqpowcYNQ+9IK1mh3WO1EzNadwhmM80k/TJCUTLNRLH4DRj8oFy3309U4i633Zvt6TgQI/W0a3+UxIRiIhXozS22vnmr3YJ3SevSaM8PU3x7nlpPgnXMi906 5c25TsJw 8iKk43Ix51FhLHb/RXeQLB+/23VvTaMsx2AGUzj9uh3l6G+yZKxImOX0EfBjFHiz8/tFJ68U6nyRIJkvqJ2Uue80Vz00gnOLRKNkDZNo4EI859ntPRvbHVBjlBpozTBDEUPq1PGzzwnp1KLU9jbGJiV1X1gCqYZumeqzNs/CsK3fVN9z8CpXSaMCAsoZRKnnxTK9dmZHl6H9aOV3X0P9z+ztgv4cz1sF5e0Wo4OIHDCYelGyshf+iya2aRIjAjNnEEemF/sQvB7fx4Oc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/6 9:47, Andrew Morton wrote: > On Mon, 2 Dec 2024 09:03:45 +0800 Kefeng Wang wrote: > >>>>> WARNING: the patch is only build tested. >>>> >>>> I'm holding this patch in mm-unstable because it's unclear (to me) that >>>> this regression has been adequately addressed? >>> >>> Yes. This patch isn't ready to be merged yet. More works are needed to >>> root cause the problem and implement the proper fix. I guess that >>> Kefeng will continue to work on this. >> >> Sorry for the late, I've been buried in other tasks. >> >> The two bugfix patches in the next should be merged firstly, which is >> not related about the performance issue. >> >> 84ddd1450383 mm: use aligned address in copy_user_gigantic_page() >> 9fbd869b19b8 mm: use aligned address in clear_gigantic_page() >> >> >> and according to the suggestion of Ying, I am trying to fix the >> performance issue on arm64(will in new series), but I need to check no >> regression on other arm64's machine, will send the new patches once >> the test is complete. >> >> So Andrew, please help to pick up the above two bugfix patches to >> v6.13-rcX if no objection. > > I added cc:stable to both and moved them into mm-hotfixes-unstable, > targeting an upstream merge next week. > > "mm: use aligned address in clear_gigantic_page()": > https://lkml.kernel.org/r/20241028145656.932941-1-wangkefeng.wang@huawei.com > > "mm: use aligned address in copy_user_gigantic_page()": > https://lkml.kernel.org/r/20241028145656.932941-2-wangkefeng.wang@huawei.com > Nice, thanks a lot.