From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47BF1C021A7 for ; Thu, 13 Feb 2025 04:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73F7F280007; Wed, 12 Feb 2025 23:27:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EEFC280003; Wed, 12 Feb 2025 23:27:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B71A280007; Wed, 12 Feb 2025 23:27:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3EE5E280003 for ; Wed, 12 Feb 2025 23:27:42 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B658D1A0388 for ; Thu, 13 Feb 2025 04:27:41 +0000 (UTC) X-FDA: 83113637922.19.97F048C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 0A84DC0004 for ; Thu, 13 Feb 2025 04:27:39 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739420860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8MwIivvjjwPhnG/jazghabjG4mn4BT06WfyhWUGwRcc=; b=z9L2/ajlMr3z0hGAwUV2HoO2LsxqEy9KqOmG/4ZO0Y7RCxdKprrBqg6nZf51Qnd1wnZEtx niEaEPfNMJX1MCeURjXss7e0XAF6s9JqzBNB8HGu9+jy3wXUUAx9gKxZDvtST7oRpufXZx rJJqYjJf9ff3GDq8ICU+GkFxnkG5LoY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739420860; a=rsa-sha256; cv=none; b=Gm8p3KRS5omhgVyYnGO0WBdgufCCkQJvd/YH6pfOC2DPP7TKNzyeHPa1egPCXusfjEIMZ6 9n//yaxAbEtwKd5xGa7KNnzAANe/WH5TlL3jAXCDryf6IXdTbaKxOWhEHHndZYEfaO8yl8 01mMOtP8pjVnATGaucJw8Oja8mTitRU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BC4D1756; Wed, 12 Feb 2025 20:28:00 -0800 (PST) Received: from [10.162.16.135] (a077893.blr.arm.com [10.162.16.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B97403F58B; Wed, 12 Feb 2025 20:27:37 -0800 (PST) Message-ID: Date: Thu, 13 Feb 2025 09:57:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/mm_init.c: only align start of ZONE_MOVALBE on nodes with memory To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org References: <20250211082900.10877-1-richard.weiyang@gmail.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250211082900.10877-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0A84DC0004 X-Stat-Signature: fnq4o1pf6r3td7a3w1tko1u8ob1uwt8o X-HE-Tag: 1739420859-497785 X-HE-Meta: U2FsdGVkX1/SSbPMZPFclAdhtKrutE0+fq3bhL9qAzY27DYBMDX0clQcKkusycOAfB1wwqFk9UcscPjQy2zU1isVmQTdTo2TQWb5TExewkD1bzlKzNrVt2v963HHfAzdJUzwwEiZpsdX3/svrQrZbFIyyuoEBPUBES0jmIjM07gCFYWkQojAwtwjmz245IJ9gdMr6PJ0uBv6SVN12gxWxNZgNvJVcYKKnoHaiDPV565Ja5YG9D38CCZehrBZergelurV/uIEZsKtfhU52x75wGGZim9o7I5S5BWN8yeeFMbKm4jO6AseZs3T8mACKSTOtXCE2ch+uWNnVZY4bD6NwgFWTA3syZrSlpB+j4oPjdkcD6cFxVreMxVSqqNTk4FYWYpoMwuM65NH3gCCn+aUwfWn0GJZeSwCuSZi0zleNUxWlVipIMel/0l+lZ0NTcKMg7wF8UcypFuWEDvVzKDi8vrlS89pLTonDzMaQJ7OSYLrEm09IrWm05FbOZthS1I34z76OSJuzCnatoTp0F+86A7QDLIrUDb/p6p6CKx+Sv2G7JnfN66bjKT94TqQyt0lsqN6j0RVF9LSFw9Icc7XHYxdv9u5binFGESVeE4kO4O3CP2NfyUGAXh+qyqcinveisu7a28BXnbbv3gwQbgqQOIzFYvDI6KiE4Qo4jrCRqHgv/T8F4xj/3trm+zivAuhWD1FtVRbq/wsJyd1a5psKUtHI33KJjVi2+GmLzTEcMtmmJPhpZiNgGAsTyLJgJsrI1tIjK79tpOh80OIotdXb7exNmQlUefcCUHql76f4+IF+2ItXcpeiGNPCBT+4+9QE+30u/bLzzMSA8YyNHe5SIFSVRcEYtnGz0ppVGxJcu78xVlM8I3BeSfG0KmWENM4Lz+pqcUykalA8SdWEdsuYgev+Szs3JxwNmvsraD/svihkVdSSOIJhLYKi9QIcQ0nRL7j/lo6bOhQETxYYF9 YwJyAYZ0 lQke+CTqYpMlzv0GEydYx7wEiNEC4q/A7yFFYcOhGe4QhSnuvPpPX3hW94wz4uPpnxgXrQcJw+RcTQn12dRIDExGrAW/NPyMoyIICUN05Vs/P2uIvNaoqxIDPSPeEZyr4ZfYzz6PsFsm9zmTHxtM6NIvyUO/fbHsEQvsh1nurI6i8xS0npZUC3ILc039Bxq0bnF3Tiiw2QsjjoyzIdz9FoVTgmAA9gJhZFVN1I4ArvlLm+kkU03wcUzXKsnQEYxIEJWU/NxqvTdj09aSqWG0Wd4D994oj7NE7TJXc8F1PeXJO6XAhTgi7GfeECKQNjLPq5hLrFrAORswXxOyvtnSSz5HSMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/11/25 13:59, Wei Yang wrote: > At the beginning of find_zone_movable_pfns_for_nodes(), it has properly > set node_states[N_MEMORY] in early_calculate_totalpages(). > > Instead of iterate on all possible nodes, we can just do the alignment > on nodes with memory. > > Signed-off-by: Wei Yang > --- > mm/mm_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 35754a8ae6c0..3ec50b5fda12 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -547,7 +547,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > > out2: > /* Align start of ZONE_MOVABLE on all nids to MAX_ORDER_NR_PAGES */ > - for (nid = 0; nid < MAX_NUMNODES; nid++) { > + for_each_node_state(nid, N_MEMORY) { > unsigned long start_pfn, end_pfn; > > zone_movable_pfn[nid] = LGTM Reviewed-by: Anshuman Khandual