From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B6CC4321E for ; Tue, 29 Nov 2022 14:02:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB73C6B0074; Tue, 29 Nov 2022 09:02:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D67456B0075; Tue, 29 Nov 2022 09:02:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE0C66B0078; Tue, 29 Nov 2022 09:02:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ACFED6B0074 for ; Tue, 29 Nov 2022 09:02:03 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2E2131A0F43 for ; Tue, 29 Nov 2022 09:15:30 +0000 (UTC) X-FDA: 80185921620.06.B7D3D0D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id CF29580011 for ; Tue, 29 Nov 2022 09:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669713329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=CVTqeJsjJ6M6oUb6FrX1fTHFWJVu2XE/7Zl7XkjJYG4rto2Pu+e2T9BY9uVPkQpTq6j6At 3i1wWc5xcEBvJrdP2wz079vCxaLBwUswT8Vf13a5GDWSmCFmgs6v491cu1yUilm6gwEaIk m9jQz7TVRbNPZk35vnqZWtkr6+7cz0s= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-241-HANrreQSPSiTABy9lMFb_A-1; Tue, 29 Nov 2022 04:15:25 -0500 X-MC-Unique: HANrreQSPSiTABy9lMFb_A-1 Received: by mail-wm1-f71.google.com with SMTP id b47-20020a05600c4aaf00b003d031aeb1b6so9856945wmp.9 for ; Tue, 29 Nov 2022 01:15:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=kjtPYxPomjPUg6Evhv9PZ+nZ8HFAHFFly8LKmhL/jsHwPqsqIQJTDTd+7+/Eb/Of9s naGvAeGt2PyIS/rMJadwAOJV259HnC2d79McoCNz2QquDnpVxm0jsplFCPeu902uq8uu WvYf4iKLBOwDMOoYE5VXz1MFfy789BZ+7CJO4+4niXcc3HY7wRakYbiJVEd0olkGiKhJ mj/Z7Xd2JGSIu5zDSyfs9euoMFAANJcf0DYyQbfdkB3ju8TjvSigS0ogEXfHv769E+SF N3lI6QCM5hxxSKJgE5kcrYEan5qH0VFQa8/d+StA17kH7KzwszKsoXTXRiOW3tDdGvax EPIQ== X-Gm-Message-State: ANoB5pmWEzUuAYDrOysDghr0TpgUJ/0Fzf9mZ6x6To41vMHvgLx7+a/g pkp9zwM/34y+sAYmtTN3n5SKHx9g8t+5AsKLr4Dq/hYmMdTegpDD93OSdIwvjCRE52pz5+qZiL2 rKdX4vq5QRtc= X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243492wme.140.1669713324542; Tue, 29 Nov 2022 01:15:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf5aMoFyhfTZRz6WGw0GcgDkcONZAiRyZAh+e0PFHXmVnEtFtgvwKaxuOXbIxhdoVgI1OB8H+Q== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr42243382wme.140.1669713323266; Tue, 29 Nov 2022 01:15:23 -0800 (PST) Received: from ?IPV6:2003:cb:c705:ca00:3fb8:c253:3bf7:b60e? (p200300cbc705ca003fb8c2533bf7b60e.dip0.t-ipconnect.de. [2003:cb:c705:ca00:3fb8:c253:3bf7:b60e]) by smtp.gmail.com with ESMTPSA id n26-20020a05600c3b9a00b003c6b70a4d69sm1498998wms.42.2022.11.29.01.15.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 01:15:22 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 10:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: Hans Verkuil , Andrew Morton Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669713329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kLZwFc2T16+VzxzvdeqP7dZ+DZAGfAAiD+u0EUrSQ8s=; b=4SiCFiwnQCScWfVi3Mnl7jMQOHTTRQDsQIjFfiTq9jpku9e+PUjN3M/ifhOCBJGF2F+T3A MI2UE92uFseiXqDQqwFR5n67JAxUVV8xMS2Q/QepmQvjksvJyKhzQVZ/0wI4oxeepUaOHK SUuYSuIlXYlZ29Un9eFxjt+cr6vOBV0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CVTqeJsj; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669713329; a=rsa-sha256; cv=none; b=kwy6U3YUiHegDVaKq31YMXIhb+0PZO7zMKazPvNIxD1O0/Mrmd/Eh6yp7uu0t1Rjr28Yp9 UKZU4TjsyvPMIIdFdM+tMpdj9TwUOr8znBufOQcWsnwUV/+tn4sS5IWX1Hc5THJrzoyLty T9YcFHCnT1XPq2BDv32oB0GfFgvv9pY= X-Stat-Signature: 7nogipxhhs45adc99feed689tzcq9wd8 X-Rspamd-Queue-Id: CF29580011 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CVTqeJsj; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1669713329-831344 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.11.22 10:08, Hans Verkuil wrote: > On 29/11/2022 09:48, David Hildenbrand wrote: >> On 28.11.22 23:59, Andrew Morton wrote: >>> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: >>> >>>>> Less chances of things going wrong that way. >>>>> >>>>> Just mention in the v2 cover letter that the first patch was added to >>>>> make it easy to backport that fix without being hampered by merge >>>>> conflicts if it was added after your frame_vector.c patch. >>>> >>>> Yes, that's the way I would naturally do, it, however, Andrew prefers >>>> delta updates for minor changes. >>>> >>>> @Andrew, whatever you prefer! >>> >>> I'm inclined to let things sit as they are.  Cross-tree conflicts >>> happen, and Linus handles them.  I'll flag this (very simple) conflict >>> in the pull request, if MM merges second.  If v4l merges second then >>> hopefully they will do the same.  But this one is so simple that Linus >>> hardly needs our help. > > It's not about cross-tree conflicts, it's about the fact that my patch is > a fix that needs to be backported to older kernels. It should apply cleanly > to those older kernels if my patch goes in first, but if it is the other way > around I would have to make a new patch for the stable kernels. IIUC, the conflict will be resolved at merge time and the merge resolution will be part of the merge commit. It doesn't matter in which order the patches go upstream, the merge commit resolves the problematic overlap. So your patch will be upstream as intended, where it can be cleanly backported. Hope I am not twisting reality ;) -- Thanks, David / dhildenb