From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C3AC433EF for ; Thu, 9 Jun 2022 00:59:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF4336B0073; Wed, 8 Jun 2022 20:59:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4CB6B0074; Wed, 8 Jun 2022 20:59:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1E356B0075; Wed, 8 Jun 2022 20:59:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E9826B0073 for ; Wed, 8 Jun 2022 20:59:53 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 61E0C33A5A for ; Thu, 9 Jun 2022 00:59:53 +0000 (UTC) X-FDA: 79556890266.03.4E43E86 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf17.hostedemail.com (Postfix) with ESMTP id 4FAAD40012 for ; Thu, 9 Jun 2022 00:59:52 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LJQjF3fPzz8wyG; Thu, 9 Jun 2022 08:59:29 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 9 Jun 2022 08:59:48 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 9 Jun 2022 08:59:47 +0800 Subject: Re: [PATCH -next] mm/filemap: fix that first page is not mark accessed in filemap_read() To: , , CC: , , , , References: <20220602082129.2805890-1-yukuai3@huawei.com> From: Yu Kuai Message-ID: Date: Thu, 9 Jun 2022 08:59:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20220602082129.2805890-1-yukuai3@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654736393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x4BRr/cGitv4pcFGMGQwFQODNV1JdFtD3yIY8vcCesg=; b=yFunsfywSUYtffK15pYH7mYESZqORqNuyWtc16iGuCQv7mAIYzpVkEptY+nkt0gVj0wj9l vuBQzxuKWMgp/QfXFxak1yYrjpyaR0cRSBxwzO+EQT8aHJsDunau+ulkgmfDp3V0gcC/5y TpnbOByUNqEBM7K+xmG+IMniOMQ+D5M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of yukuai3@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=yukuai3@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654736393; a=rsa-sha256; cv=none; b=RXGCadmhAgZcPsoP4h6gUqD6QnZObV6zoask+tEJdVajAj3gtTOD/5FQZrEtyDbE/lbE6T SRdpmXU37bB0ljw6h0kZxO7ZzrDNXn6Gyypl4IkOr86JdM0RPaDSHv9Nz0C/w2ldvvp5Sw IhqZm1y2wS9OdcC/aARJstON9Xq1BNk= X-Stat-Signature: qemnesw6wm69mppyxfexxrtac4q9bpsn X-Rspamd-Queue-Id: 4FAAD40012 Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of yukuai3@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=yukuai3@huawei.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1654736392-409771 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: friendly ping ... ÔÚ 2022/06/02 16:21, Yu Kuai дµÀ: > In filemap_read(), 'ra->prev_pos' is set to 'iocb->ki_pos + copied', > while it should be 'iocb->ki_ops'. For consequence, > folio_mark_accessed() will not be called for 'fbatch.folios[0]' since > 'iocb->ki_pos' is always equal to 'ra->prev_pos'. > > Fixes: 06c0444290ce ("mm/filemap.c: generic_file_buffered_read() now uses find_get_pages_contig") > Signed-off-by: Yu Kuai > --- > mm/filemap.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 9daeaab36081..0b776e504d35 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2728,10 +2728,11 @@ ssize_t filemap_read(struct kiocb *iocb, struct iov_iter *iter, > flush_dcache_folio(folio); > > copied = copy_folio_to_iter(folio, offset, bytes, iter); > - > - already_read += copied; > - iocb->ki_pos += copied; > - ra->prev_pos = iocb->ki_pos; > + if (copied) { > + ra->prev_pos = iocb->ki_pos; > + already_read += copied; > + iocb->ki_pos += copied; > + } > > if (copied < bytes) { > error = -EFAULT; >