Re: [RESEND PATCH 2/4] selftests/mm: soft-dirty: skip two tests when thp is not available

David Hildenbrand (Arm)
2026-03-12T19:43:22Z

On 3/12/26 12:40, Chunyu Hu wrote:
> The test_hugepage test contain two sub tests. If just reporting one skip
> when thp not available, there will be error in the log because the test
> count don't match the test plan. Change to skip two tests by running the
> ksft_test_result_skip twice in this case.
>
> Without the fix (run test on thp disabled kernel):
> ./run_vmtests.sh -t soft_dirty
> # --------------------
> # running ./soft-dirty
> # --------------------
> # TAP version 13
> # 1..19
> # ok 1 Test test_simple
> # ok 2 Test test_vma_reuse dirty bit of allocated page
> # ok 3 Test test_vma_reuse dirty bit of reused address page
> # ok 4 # SKIP Transparent Hugepages not available
> # ok 5 Test test_mprotect-anon dirty bit of new written page
> # ok 6 Test test_mprotect-anon soft-dirty clear after clear_refs
> # ok 7 Test test_mprotect-anon soft-dirty clear after marking RO
> # ok 8 Test test_mprotect-anon soft-dirty clear after marking RW
> # ok 9 Test test_mprotect-anon soft-dirty after rewritten
> # ok 10 Test test_mprotect-file dirty bit of new written page
> # ok 11 Test test_mprotect-file soft-dirty clear after clear_refs
> # ok 12 Test test_mprotect-file soft-dirty clear after marking RO
> # ok 13 Test test_mprotect-file soft-dirty clear after marking RW
> # ok 14 Test test_mprotect-file soft-dirty after rewritten
> # ok 15 Test test_merge-anon soft-dirty after remap merge 1st pg
> # ok 16 Test test_merge-anon soft-dirty after remap merge 2nd pg
> # ok 17 Test test_merge-anon soft-dirty after mprotect merge 1st pg
> # ok 18 Test test_merge-anon soft-dirty after mprotect merge 2nd pg
> # # 1 skipped test(s) detected. Consider enabling relevant config options to improve coverage.
> # # Planned tests != run tests (19 != 18)
> # # Totals: pass:17 fail:0 xfail:0 xpass:0 skip:1 error:0
> # [FAIL]
> not ok 52 soft-dirty # exit=1
>
> With the fix (run test on thp disabled kernel):
> ./run_vmtests.sh -t soft_dirty
> # --------------------
> # running ./soft-dirty
> # TAP version 13
> # --------------------
> # running ./soft-dirty
> # --------------------
> # TAP version 13
> # 1..19
> # ok 1 Test test_simple
> # ok 2 Test test_vma_reuse dirty bit of allocated page
> # ok 3 Test test_vma_reuse dirty bit of reused address page
> # # Transparent Hugepages not available
> # ok 4 # SKIP Test test_hugepage huge page allocation
> # ok 5 # SKIP Test test_hugepage huge page dirty bit
> # ok 6 Test test_mprotect-anon dirty bit of new written page
> # ok 7 Test test_mprotect-anon soft-dirty clear after clear_refs
> # ok 8 Test test_mprotect-anon soft-dirty clear after marking RO
> # ok 9 Test test_mprotect-anon soft-dirty clear after marking RW
> # ok 10 Test test_mprotect-anon soft-dirty after rewritten
> # ok 11 Test test_mprotect-file dirty bit of new written page
> # ok 12 Test test_mprotect-file soft-dirty clear after clear_refs
> # ok 13 Test test_mprotect-file soft-dirty clear after marking RO
> # ok 14 Test test_mprotect-file soft-dirty clear after marking RW
> # ok 15 Test test_mprotect-file soft-dirty after rewritten
> # ok 16 Test test_merge-anon soft-dirty after remap merge 1st pg
> # ok 17 Test test_merge-anon soft-dirty after remap merge 2nd pg
> # ok 18 Test test_merge-anon soft-dirty after mprotect merge 1st pg
> # ok 19 Test test_merge-anon soft-dirty after mprotect merge 2nd pg
> # # 2 skipped test(s) detected. Consider enabling relevant config options to improve coverage.
> # # Totals: pass:17 fail:0 xfail:0 xpass:0 skip:2 error:0
> # [PASS]
> ok 1 soft-dirty
> hwpoison_inject
> # SUMMARY: PASS=1 SKIP=0 FAIL=0
> 1..1
> CC: Li Wang <liwang@redhat.com>
> Signed-off-by: Chunyu Hu <chuhu@redhat.com>
> ---

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

--
Cheers,

David