From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB8BC7EE30 for ; Wed, 25 Jun 2025 10:13:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C33E36B0088; Wed, 25 Jun 2025 06:13:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3F36B0092; Wed, 25 Jun 2025 06:13:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAC236B009D; Wed, 25 Jun 2025 06:13:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9748A6B0088 for ; Wed, 25 Jun 2025 06:13:20 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4460F81A7B for ; Wed, 25 Jun 2025 10:13:20 +0000 (UTC) X-FDA: 83593510560.16.DD7FB7A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C6562100005 for ; Wed, 25 Jun 2025 10:13:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KyYg5kgj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750846397; a=rsa-sha256; cv=none; b=Z/Pmh3hp5md1SgZaTD+X1jXKt/BmM1D4gZB/k5wR60ACFCTLigpUD5tVBhjoVOAlMb1wTe nLfdC+4ygHq0uj0FediWrHEwKiMSHIHEdPyIrNUTsPUuKUJTVB7HfPnADvU/go/+Xl54qH zxw/J2rwM2QW//Dx/ZsOlqH3/nbSmtw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KyYg5kgj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750846397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ocn/ODqk8wCM+J+nUX+K2lMqIhHOZxBKo9wLudoDs0w=; b=axjRFRrJmybwwJmCVnwED5oE3EWRrMMne2th3XyaSt95RoddT8J1qgbn29tKsLjYvgdY8w 3CwCgZbnasF9ENYuMmrnBbZ1KZqt0ZnpAYolA57IAsZr/5drSAmaiSaHlYGhr33mfdradS SMc/JkgYw37DgdTxKa4ea+9HHhHIaRU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750846397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ocn/ODqk8wCM+J+nUX+K2lMqIhHOZxBKo9wLudoDs0w=; b=KyYg5kgjByqR35olV2glR6G2srTQcdULobsCxhtp0j/ZcgQ4b2ixD/y49k5N6nnJ7R0uvB v8l7mvT7j6PVU46sPlOqyhm3GdOMp41XqKmGQtsDv/2IvR96rb2/nqRNuhDhHP0858A+xU OtUPWH1FUbPB/UifFqSUPcBgD+DxMeM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-ukGzDtS7MsGzWYUJxmMTjw-1; Wed, 25 Jun 2025 06:13:15 -0400 X-MC-Unique: ukGzDtS7MsGzWYUJxmMTjw-1 X-Mimecast-MFC-AGG-ID: ukGzDtS7MsGzWYUJxmMTjw_1750846395 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f7f1b932so4173853f8f.2 for ; Wed, 25 Jun 2025 03:13:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750846395; x=1751451195; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ocn/ODqk8wCM+J+nUX+K2lMqIhHOZxBKo9wLudoDs0w=; b=m4pbrCB0mxDh18qMBn32uL0LZSUiXZKK/JmO5kFOR9DKiG777fE7AjT+/7CTO3azYx jOgpnHqhbDEve4FQtcRAFAWQv3e3VjrdslS2X8uzugbV367BMIItseARbKc7yLXb5DG6 IdHfX0fSEwcZpeQA55zHYfXM/M4qdAeN4pSYa2vGygn1SrbRZWfsMWORxfQciCZP9lWE DoePztQzWeFOQMnajP8H1M+NEiKLCI/dqRf2HzhvCrXxWgKDJUGckrtbe2UL/GM4Ueaa L9Pv1j0RlFrxlGI9cKVU99R3vZLYzzmdVEQRtwiMNFuB6lWWzgtKd62C4hiaOiUf3mhJ +fqg== X-Forwarded-Encrypted: i=1; AJvYcCUj6xOgSHeAY/6JpI8xj+vnE2u6sJSFaWGGGaaR9r7kK+FUr/SVplT2tOfG/nxWZmA9KvBbyGAzHg==@kvack.org X-Gm-Message-State: AOJu0YxzkKT26xJIjL7n+tbJ0x2roviDqCe6IUKpY868ralrJg2PuxoD ogHRu6th7CkB4h1UTnFbBjTC5g8wenYxHTGNS0fhj+z29f+O3bSYg82ohWHGAlek8jQPlgAr/eB cLuxCOtWjuU6EFnfYNvsRZepL7zB7vPIEmLozb+v5j5fGNnOzPYWS9BuxTJMRrRE= X-Gm-Gg: ASbGnct4kxqglCS/5wG68fXGASybxSNGkf4AbDe5kBDiyPrFbzbNrZZrgdqlpxkabIv eEXf4BDBrbxOuzP2maPG7Mv26otZv9tdvDyZz8Uf9o1XBM/mYInOBFt1x5/1CfjAk7iKK0XWvi1 Im6UPKBLZ36ULCT6YbD2jYVn4yHbgxdHLcgRAjBeKVEqQa8YUPYDaZ50BOI1mvAjuvF2yebf+54 UGQ7zjGu45oJodlw8jajmK681NTd8xTS4Lt7t02lDTywFOY2H6SGj3+nGFb8/pwOFIFEjd+BYEz rxE8X1uMdNIbHA88kFftQ8jVyV8JUwMRLK0i8C3vIhuei/PuFkA1bg== X-Received: by 2002:a05:6000:4913:b0:3a4:d367:c591 with SMTP id ffacd0b85a97d-3a6ed5c7b26mr1861536f8f.10.1750846394737; Wed, 25 Jun 2025 03:13:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPoNM7p9tuaRpt47wshhpPxdQ6o8XwMpBiMzR2lmO9/zLctCPS7q+Nksaf3M65EY6A8tOpJA== X-Received: by 2002:a05:6000:4913:b0:3a4:d367:c591 with SMTP id ffacd0b85a97d-3a6ed5c7b26mr1861517f8f.10.1750846394352; Wed, 25 Jun 2025 03:13:14 -0700 (PDT) Received: from [192.168.3.141] (p57a1abde.dip0.t-ipconnect.de. [87.161.171.222]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823563fasm15039395e9.21.2025.06.25.03.13.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 03:13:13 -0700 (PDT) Message-ID: Date: Wed, 25 Jun 2025 12:13:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping To: Oscar Salvador Cc: Andrew Morton , Muchun Song , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250620123014.29748-1-osalvador@suse.de> <20250620123014.29748-2-osalvador@suse.de> <45d66a0c-a5ed-4894-999c-0ed5b732ebb0@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VVHtmOYiB6fr8-dwCdqayMyAHEjauk5_SufBjvmg7vs_1750846395 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C6562100005 X-Rspamd-Server: rspam10 X-Stat-Signature: m1ifnphtabsrqa4s1uirabjx768ee59d X-HE-Tag: 1750846397-307456 X-HE-Meta: U2FsdGVkX19wnH28xWR92guUIwG7T64jF9aoqJWAEEsIT/srrblMJe0dqUW92lJ359f5xvgSyYqkZiPKKZ58Wx5TFkwDvDcMK8b5kA5qHgrq0hzperRmjGyn5aJS95mMjTWVgJN4+5sJ5o5GEu/d4HM1VmV6pu7WBdis0SsRuWDjBmh+eqja5GR7byQgjuUb3DVzWzRlb/V6bPEzL21sbb+sO9+EUCmUnuQvGwMgwttyR+iORaRPt4OGt05r3LTNVoMUxUuJqlbeVd7d7JamPG30x/XSOzpsxjE1A8iEb+1HSexs8iJ0S/b7sd8QcodonLUjDxa05hiAJX8SdVb7YdKg4s/BylkXwU+fcRJaNb56SbQ/3ZDxs/sNDYvg9ED2gBPMeWCHtDuLSdKnVyY2rjSSyYodMBbAX8CE1L6jE5vnwmT0cACwrCVWcLYJd2xxQyEFWUm8Myb4on6Gj+0su7QSscqz1J5GvJS1j1RyIwU+Gk/0EjACqDteG/Nvtk9u+fP6S8YiY45kMnkN59Mzv7RockLVcDsx2ycCcQpnrGr2yJYDttm4skmymnQPVWz3aVU8myQwR3tzywCBooyz2b588z3XIkAMvII/bk7yU/ttLkVWTS4zWjszCnsikajtAG3xJNC2k8fDh7kIVqxvqFCkGpPBvApzIVtNlQlJvye50PrWYrneztLvKiMTTqvuN/vN/xZyEoDkX6cbsWgGFZLFZWVnKi6h9/8daD/8PB++0QtHjTGimJcoBVw6mXQ2++xOeIowp9NOIyUadKFDgQFQ+9DlQzyU114h/fVmDWLgwlwbEmPY8EVbQkaadw54XWLRcW8huxzioyTQ2g1EkF9p7z5zbE7JtBX9xjjZ2vXCkp4KCJ701ViZ2McibuS38Teq1/vfrOnosdVMGtC9OwBKJ4muXF7eKx1fj7HW7tCEpC6WV3ANP/AJL0dorKH+hg2k7SHH6NxUsU9aC+F ucNMgdfy tRr4vwvv/lbggFRevd4iXHVjSq4PuaCgxtYxR9waPojoQhIpmwD9e95GlD6xg6XDP2Up/q3wsJVejItT5fHXfGIKn1nAUl/U+MuMfSAowWinwQXjFbn74i7Chlm5vI7TkfGSxTafFUN3+r0VIPonV4jXobcA2VZsgzs2DFuxw6uE3wp3POMolZYXYveDfc79fKYMkd7TmAy1VapebLjh6ku9W8P2g0UaJK/gG02b3QK4ffy2GoxFiHPVPQKZ4EoxyGLTpxaQjc469pSwTH3lYcwLpguCzdTpaq7H2u8yPN1xIIoO8f3H5D5J857/5IbTq5BoVZqdnyz814shH2SUrzzSeWbeNf42NloE8oKATYq9PlejwNUTcct21L86+qn2BGaVjdhlA5QKHsSaFsMiYOvMqrGt//7yg1asw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 09:49, Oscar Salvador wrote: > On Mon, Jun 23, 2025 at 04:09:51PM +0200, David Hildenbrand wrote: >> >>> - /* >>> - * hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) and >>> - * pagecache_folio, so here we need take the former one >>> - * when folio != pagecache_folio or !pagecache_folio. >>> - */ >>> + /* hugetlb_wp() requires page locks of pte_page(vmf.orig_pte) */ >>> folio = page_folio(pte_page(vmf.orig_pte)); >>> - if (folio != pagecache_folio) >>> - if (!folio_trylock(folio)) { >>> - need_wait_lock = 1; >>> - goto out_ptl; >>> - } >>> - >>> + folio_lock(folio); >>> folio_get(folio); >> >> Just realized that this won't work for this patch here, as we are holding >> the PTL. >> >> In patch #2 you do the right thing. > > Yap, missed that. > I might have to do the lock-unlock-dance here, and then in patch#2 move > it to hugetlb_wp. > Sounds reasonable? Yes -- Cheers, David / dhildenb