From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8985FC6FD1D for ; Fri, 17 Mar 2023 11:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E4006B0074; Fri, 17 Mar 2023 07:04:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 094316B0075; Fri, 17 Mar 2023 07:04:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9F7D6B0078; Fri, 17 Mar 2023 07:04:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D95D16B0074 for ; Fri, 17 Mar 2023 07:04:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AB9CB80B10 for ; Fri, 17 Mar 2023 11:04:24 +0000 (UTC) X-FDA: 80578106448.21.99A6B32 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf25.hostedemail.com (Postfix) with ESMTP id A5A80A0015 for ; Fri, 17 Mar 2023 11:04:21 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Pv66YiMj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rEsjJ8ac; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679051062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0gTqNyOWas1b1mGuUVuoC2toQOZDunokBIW1RrnAt9s=; b=i2Nz9xovXGNOkxoxEakZfjpMeDc0YPxYZspF1uXblvXe/ZZhrpy5v7DZP6KrJAF798o3lR uN86iSegGhYeU2PagO4GItvfX+TQ8GZnZhOy6roUDkA9C+UgUKKusMvwhNPPIOW/Rl1utt Po3dZTiNCwoMZaj/0caiMVSdumNuUoM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Pv66YiMj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=rEsjJ8ac; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679051062; a=rsa-sha256; cv=none; b=8Kp2XoYdB/4+odjrrWXYmnfk1kLqt705L1epZh65KlpWV8Bb9DXlC6cvfjBBlK2Hf89p8a SZEZAuAJttaHdzNqAxS8mkQ2LqBp4kKCwq16XCEDmZ+WMYNS84ZdjECSTIRmwv+DeAEdih HDMItTN3IlPuW3FacxrjgixYZrSSY0g= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5A3071FDDF; Fri, 17 Mar 2023 11:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679051060; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0gTqNyOWas1b1mGuUVuoC2toQOZDunokBIW1RrnAt9s=; b=Pv66YiMjFihFlXGEgUrQ+mP5exd7suUo7O/FGooBsMGQRYn3WAHPyVU9JNbf8LbVUfveUF buiEWJkCKAZgAK6+ncebBkiJMMcq2wjjQbufNi8c/irmbyxfkfE9LmCJV4iQ9a0W8imKXn hB30+lcszzXvc1hJipoj90IJVcfuKe0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679051060; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0gTqNyOWas1b1mGuUVuoC2toQOZDunokBIW1RrnAt9s=; b=rEsjJ8acbBKWGCy0+vPHW+wekO5LGfupl4FU8YKvhylebz4xhuCxG1XNk79WhvWB0cJi7Y XIDTn0iWLaIEQ7CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 409DD13428; Fri, 17 Mar 2023 11:04:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RzkODzRJFGQhBQAAMHmgww (envelope-from ); Fri, 17 Mar 2023 11:04:20 +0000 Message-ID: Date: Fri, 17 Mar 2023 12:04:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG Content-Language: en-US To: Vernon Yang , akpm@linux-foundation.org, 42.hyeyoo@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230314071601.343817-1-vernon2gm@gmail.com> From: Vlastimil Babka In-Reply-To: <20230314071601.343817-1-vernon2gm@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A5A80A0015 X-Stat-Signature: q3rumb5nftr4ds6y13qq91gp5khdhaye X-HE-Tag: 1679051061-721480 X-HE-Meta: U2FsdGVkX18msaTAIh8WH6FgfGUN6s7/tzx4eBrBqb/TOIxQkcGR7Yv7225vbAUud0A3rO4GJaRpriaIaxtPtXeCw3tNDCHBJKfckmCptqq1VC2b73M1F4/lWHJxbhRKhPcYaXG3Rfm6dRBflRtdZtvkmiqUyXyCGaE+s2+zFuNvXoG+52rSaSXD/SjVOc/E51Enkrtahu5t79COTdPavt6GhjLPnkW3ktl4iLfuJ7jpnUHJINlXQJSIPHTgzH6JeZd4BDFOQ0mfjF/i9tN96n/z7xVfXZ0r8wUNMEiyEbWSxf8ZZjwVSaT3w13QAIqxODYQNmWwfEpRcV7Z7EVmp9WPio3X+qab297TXR+YISFgIm3UWk4Ovbf72hirOa6rOijji91GvjCQuEPS/F6GMYqA6m9GAKmvIPxLPv96cZOSrmlZjN/Lsyh+WNCT4K+yE+CjLFwBz6kLgzfWAHcR0oZC26aRnU5EhZvN5jJSi6UV5zgymZzGL+DV+TWzxcSmAG+sR//viUd2T6yrwiY7nGO/nhRU3CJQ5ZfD884RdIO4IPKAu+bdH38ebqgxEbgBuBj0NvQAXQj5zv/5kt7HEMl/JEUAHAbZzRDN1K7U8FIcvmWN0qDgBrqbuf5csx8pibOhtIRbPlNLF2ZN49qsxaXYKl5xvmQbLpCpp4NDeJpCENObzK9Y/k6r0VBLODPhGJTlR2mr0o6A0lJbdL/Geh0PWQ2/43tyzxXUjWmXMkSRpranR96d7WfzzgW1PKnl+BfOgTiyhdUdOsurYQXjEFzlitVXeTZQgY+a3EADDnvX8VXu6RZfovZeYHo7X1mEDVjnctcGJl8ytH8S6eygvh3tWEM9Rp1umKIV38koCY5N8ZfZBJdKh+7reG7vXuiKV/yUpCkCiVpAYsM2A5FXLZYaBx4ZgcIMMeZK6j9L3Q6N5R33aGt2xyhkV3j8FzKBtk3rv+1QUA4918IBd1P kydcSuZ5 Kf1SrChW92w8xDQmBwXkT+vHfi+j+VIQH9t5pjU1Ri9mzbeE6fRvcqv2mwHnOtB9+zOSdWO4QQF5hjJVkLapnTegBaePgwF+Lx5RVy+Reoq7OIcpHDHSZ2O6LRQEB+VoDabvuBVCzRenm6XuQW2Vf863+JDYTC3EyZQz6DgWkbXoK+SZi3BFEChBsn/weOX2UOar9Qky9tinN8mj9br+5OhgkOyCuLhPJ8z6RP+ndY1VdPEj5amRY94Yfe3JI9VSrny6ZtNxPQhdOCYWSVZw9PVkaWlmjoEVZBPCLBNsA+895KQueI5/F+k0uSCVBtCTfXYzqS6dNchjVH28rGt3/GH3SrLH4mwZtTcVz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/14/23 08:16, Vernon Yang wrote: > Since commit ab4d5ed5eeda ("slub: Enable sysfs support for > !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables > SLUB sysfs support that is not true anymore, so fix it correctly. > > Signed-off-by: Vernon Yang Thanks, slightly reworded and pushed to slab/for-6.4/trivial > --- > mm/Kconfig.debug | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index c3547a373c9c..9a90a88ce053 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -60,9 +60,8 @@ config SLUB_DEBUG > select STACKDEPOT if STACKTRACE_SUPPORT > help > SLUB has extensive debug support features. Disabling these can > - result in significant savings in code size. This also disables > - SLUB sysfs support. /sys/slab will not exist and there will be > - no support for cache validation etc. > + result in significant savings in code size, the /sys/kernel/slab > + will exist but will not provide e.g. cache validation. > > config SLUB_DEBUG_ON > bool "SLUB debugging on by default"