From: Vlastimil Babka <vbabka@suse.cz>
To: Vernon Yang <vernon2gm@gmail.com>,
akpm@linux-foundation.org, 42.hyeyoo@gmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/slub: fix help comment of SLUB_DEBUG
Date: Fri, 17 Mar 2023 12:04:19 +0100 [thread overview]
Message-ID: <ab97a4bf-b89a-0c8e-f871-d5f2b3dfa645@suse.cz> (raw)
In-Reply-To: <20230314071601.343817-1-vernon2gm@gmail.com>
On 3/14/23 08:16, Vernon Yang wrote:
> Since commit ab4d5ed5eeda ("slub: Enable sysfs support for
> !CONFIG_SLUB_DEBUG"), disabling SLUB_DEBUG also disables
> SLUB sysfs support that is not true anymore, so fix it correctly.
>
> Signed-off-by: Vernon Yang <vernon2gm@gmail.com>
Thanks, slightly reworded and pushed to slab/for-6.4/trivial
> ---
> mm/Kconfig.debug | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index c3547a373c9c..9a90a88ce053 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -60,9 +60,8 @@ config SLUB_DEBUG
> select STACKDEPOT if STACKTRACE_SUPPORT
> help
> SLUB has extensive debug support features. Disabling these can
> - result in significant savings in code size. This also disables
> - SLUB sysfs support. /sys/slab will not exist and there will be
> - no support for cache validation etc.
> + result in significant savings in code size, the /sys/kernel/slab
> + will exist but will not provide e.g. cache validation.
>
> config SLUB_DEBUG_ON
> bool "SLUB debugging on by default"
prev parent reply other threads:[~2023-03-17 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 7:16 Vernon Yang
2023-03-17 11:04 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab97a4bf-b89a-0c8e-f871-d5f2b3dfa645@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vernon2gm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox