From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12738C4332F for ; Tue, 1 Nov 2022 19:35:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FA8A6B0073; Tue, 1 Nov 2022 15:35:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A9826B0074; Tue, 1 Nov 2022 15:35:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 470FF6B0075; Tue, 1 Nov 2022 15:35:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3BD346B0073 for ; Tue, 1 Nov 2022 15:35:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0E48C802B3 for ; Tue, 1 Nov 2022 19:35:59 +0000 (UTC) X-FDA: 80085878838.26.CD82328 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id 7195C16000E for ; Tue, 1 Nov 2022 19:35:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ABF861F8BA; Tue, 1 Nov 2022 19:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1667331356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jc3GZbUnGicye2/jncE2VAeBO5z9oAX6w1xDyj0hRaI=; b=zxfEoNp7ByQJWbFfW/abgDH3V5Ms7cBMA7PHBEYuzp95JXxSnlsKV9HE48hNuYThLVm4d8 pDUT0NS97pS9sleJdlH4HYB4TuKVZ0sW0UcxJDs6rj6RjjnVG/OYrQhOYfWNtJolbMgKYn 42KRxuj4mYVHb7TJUD+FfYxMqVIuygI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1667331356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jc3GZbUnGicye2/jncE2VAeBO5z9oAX6w1xDyj0hRaI=; b=R81kdDAat9+Gy9w72WUdJdEEDk1kFsDH5uguOsuZGDmslkZx4I/62V9xhPiUKDalyvl3JQ ekfwdj+5mkwhYwAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6A11613AAF; Tue, 1 Nov 2022 19:35:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id g9MRGBx1YWOATwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 19:35:56 +0000 Message-ID: Date: Tue, 1 Nov 2022 20:35:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v4] mempool: Do not use ksize() for poisoning To: Kees Cook Cc: Anders Roxell , kernel test robot , Andrew Morton , David Rientjes , Marco Elver , Vincenzo Frascino , linux-mm@kvack.org, Andrey Konovalov , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20221028154823.you.615-kees@kernel.org> <20221031105514.GB69385@mutt> <13c4bd6e-09d3-efce-43a5-5a99be8bc96b@suse.cz> <202211011014.02F2559@keescook> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <202211011014.02F2559@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667331358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jc3GZbUnGicye2/jncE2VAeBO5z9oAX6w1xDyj0hRaI=; b=uOrtPB3wsEwW1rXCLnc6NRTSjjDkqkr9qGVTuq4Owj3FotZ7/3oU9D1lzruJzmiZqI+8LC 84sVA+UxuJrTd8jZJuIMCsZK2mIcWGeEXBkrZDfVW9OK0VPZsuIeH8d8FjKLr5NHii2G8U u0jSw1lDFiv11IXi1Mibc48jw6NuW/o= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zxfEoNp7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=R81kdDAa; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667331358; a=rsa-sha256; cv=none; b=zXrXH5iPSf1h6+FYk8JPdHGR4LnxL9C829PEHtMxIsxI3nPZbf7nHs98KF0uKUqOrV9DbN dWLSLtgibzXogIQ1sNdK2WX4ohr23GTfiSlMVhBFuIx1JfyoXQZ2r9yn1C+Q1Ymheu4YVX 0OuJkcf8QB1wNoVNldaaYq78ZxpoOZE= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zxfEoNp7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=R81kdDAa; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: 6mguwrt1sx6xo8rrdxgrdtk6tnuqwe3c X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7195C16000E X-HE-Tag: 1667331358-586091 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/1/22 18:15, Kees Cook wrote: > On Mon, Oct 31, 2022 at 04:00:25PM +0100, Vlastimil Babka wrote: >> From a4a5a40852723dfadb2429bee1d5e1f9d3b75f39 Mon Sep 17 00:00:00 2001 >> From: Vlastimil Babka >> Date: Mon, 31 Oct 2022 15:55:47 +0100 >> Subject: [PATCH] mempool: Do not use ksize() for poisoning-fix >> >> For slab mempools (not kmalloc), pool_data is not object size, but a >> kmem_cache pointer; we need to extract the size via kmem_cache_size(). >> >> Reported-by: Anders Roxell >> Link: https://lore.kernel.org/all/20221031105514.GB69385@mutt/ >> Reported-by: kernel test robot >> Link: https://lore.kernel.org/oe-lkp/202210312110.1fe5d224-oliver.sang@intel.com >> Signed-off-by: Vlastimil Babka > > Reviewed-by: Kees Cook > > Thanks again for fixing this. I don't see it in -next yet? Should I > resend this directly, or how would be best to land it? I think Andrew will add it from here, but maybe is waiting for Anders acknowledging that it fixes the bug for him? > -Kees >