From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D67C433FE for ; Tue, 15 Feb 2022 09:37:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D36026B007B; Tue, 15 Feb 2022 04:37:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE5FB6B007D; Tue, 15 Feb 2022 04:37:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD5566B007E; Tue, 15 Feb 2022 04:37:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id B03DE6B007B for ; Tue, 15 Feb 2022 04:37:43 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 72160180AD837 for ; Tue, 15 Feb 2022 09:37:43 +0000 (UTC) X-FDA: 79144512006.10.29817D3 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf28.hostedemail.com (Postfix) with ESMTP id 87A49C0003 for ; Tue, 15 Feb 2022 09:37:42 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4JybWx1bbNz8wct; Tue, 15 Feb 2022 17:34:21 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Feb 2022 17:37:39 +0800 Subject: Re: [PATCH 07/10] mm/truncate: Convert __invalidate_mapping_pages() to use a folio To: "Matthew Wilcox (Oracle)" , , References: <20220214200017.3150590-1-willy@infradead.org> <20220214200017.3150590-8-willy@infradead.org> From: Miaohe Lin Message-ID: Date: Tue, 15 Feb 2022 17:37:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220214200017.3150590-8-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: xtktgnsekhpjc6jdicujxowqnh5zqm83 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 87A49C0003 Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-HE-Tag: 1644917862-839708 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/15 4:00, Matthew Wilcox (Oracle) wrote: > Now we can call mapping_shrink_folio() instead of invalidate_inode_page() > and save a few calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) LGTM. Thanks. Reviewed-by: Miaohe Lin > --- > mm/truncate.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index b1bdc61198f6..567557c36d45 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -505,27 +505,27 @@ static unsigned long __invalidate_mapping_pages(struct address_space *mapping, > folio_batch_init(&fbatch); > while (find_lock_entries(mapping, index, end, &fbatch, indices)) { > for (i = 0; i < folio_batch_count(&fbatch); i++) { > - struct page *page = &fbatch.folios[i]->page; > + struct folio *folio = fbatch.folios[i]; > > - /* We rely upon deletion not changing page->index */ > + /* We rely upon deletion not changing folio->index */ > index = indices[i]; > > - if (xa_is_value(page)) { > + if (xa_is_value(folio)) { > count += invalidate_exceptional_entry(mapping, > index, > - page); > + folio); > continue; > } > - index += thp_nr_pages(page) - 1; > + index += folio_nr_pages(folio) - 1; > > - ret = invalidate_inode_page(page); > - unlock_page(page); > + ret = mapping_shrink_folio(mapping, folio); > + folio_unlock(folio); > /* > - * Invalidation is a hint that the page is no longer > + * Invalidation is a hint that the folio is no longer > * of interest and try to speed up its reclaim. > */ > if (!ret) { > - deactivate_file_page(page); > + deactivate_file_page(&folio->page); > /* It is likely on the pagevec of a remote CPU */ > if (nr_pagevec) > (*nr_pagevec)++; >