From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECE1C71136 for ; Tue, 17 Jun 2025 07:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C34556B0089; Tue, 17 Jun 2025 03:54:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0C1E6B008A; Tue, 17 Jun 2025 03:54:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B21B86B0092; Tue, 17 Jun 2025 03:54:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A59F66B0089 for ; Tue, 17 Jun 2025 03:54:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 57D7FC1758 for ; Tue, 17 Jun 2025 07:54:37 +0000 (UTC) X-FDA: 83564130594.23.42FE28F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id EAC0E80003 for ; Tue, 17 Jun 2025 07:54:34 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FzNVGQz8; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750146875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ktge954MPbzaWmp5iHOmPfmIe8eROLXd6XeMQ+DHaQI=; b=8n68AitjG3pcxCgGFk/34DNmuZdnpxAydmZIZwXSGbRwR9W5xDOO3OjfoPYeBhKgd+yomV lY0uOAeknRKRMj832yoVv8VmpBIEb7NI36/cCSRukcHMS81qkRJVYwg6S5pfsxIueelnbd xjw991raW8qyfnNMaKuYTqjr8MhcIsc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FzNVGQz8; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750146875; a=rsa-sha256; cv=none; b=l578s1tvEbcjuiHD2be9RkuFxzTOlG+m44nCI6mmdG3IQiZr9Vh9ykmOP4LaQ2PVlqFFsq Joh1x7SyTIb6xyNjCzyHlHBQBPlIq2KqrVpPjH6vTx1E8hOYFCvNBHUxUvqYHu4CQxXBrP /5QF/5Q65mTfiCUChkboMWewUGX03Ko= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750146874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ktge954MPbzaWmp5iHOmPfmIe8eROLXd6XeMQ+DHaQI=; b=FzNVGQz8d/3MYeEN1r5A0r62bP7D09zpHb4X/I2lO5J/AmGvR8lUXoXee5AAB6YNdU0sJb XseDvYFq+G45LyzhsKwS1ULXwe45Ss7mkh7Jx1IuTLj6z23bOfGngy1/QhdQJZHfTdts7h 1tsgVtMkXbm5RIrqbPUT9mW/3ltCWRM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-RxNs0tE9Mkqn-gbUxFHxIA-1; Tue, 17 Jun 2025 03:54:33 -0400 X-MC-Unique: RxNs0tE9Mkqn-gbUxFHxIA-1 X-Mimecast-MFC-AGG-ID: RxNs0tE9Mkqn-gbUxFHxIA_1750146872 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d6768d4dso34767985e9.2 for ; Tue, 17 Jun 2025 00:54:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750146872; x=1750751672; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ktge954MPbzaWmp5iHOmPfmIe8eROLXd6XeMQ+DHaQI=; b=RFDGW/24H0xxmfDLDuBvx6zDg8ekhXXgFayT1XDCtekkWysJl2miav3Tue5NFVSVZ9 VHgOfDxhFMkmp39O0FhSgIwO545Z3nuEki/r7QidFE3ACydal3zKaZd3jjLKtg8VY984 VgchryUU4BJC7QeVsPQdhsnGw5/qKGve1Y6ZaSEtXSLCgz+89bqVY4r+EkfZ7wnusMc7 iOWNf2H88O+EmksmSrtNqCkh0dIYgezFueABQdrLpVTkkAV5z04Wg8ftzhb7bgVx8a9z xtNxkL0k+AQzRHYMF7fFRujro6sW1c2m+nyxq2k1cDy3Iq0jnYJSL9l9fckHZz1OSREe 5JhA== X-Forwarded-Encrypted: i=1; AJvYcCX2Un9Q45qgsutmjPFrWzRTFcvCuHAfz7hwM6jS5xJuKsDTCxwf7wF04TOu9fizNL8MuDbkfk34Vg==@kvack.org X-Gm-Message-State: AOJu0YzWCZV5drrHvkgYcBPesUSLEg2llz5sLc+bNSwN1qnq9TGv/p/l Y0iA0hrf7Vg8Th/dEGRz6tKtAPNy39aaLbbNpBXaT26MKDQ+V4MBv+8dJj64X7Xe61QVRTQcVmk nY1ggIX6ZmjA0iUopjcW6WEADNIOYJWIYH/6dNoR2nXoOnMYUs11x X-Gm-Gg: ASbGncv7lqrqv1tzXxSqWghSF66+2ArtXYMBsQQQaCd2lcY7OkZGs15etNUSCkr47xZ gNvLmPgr+CxcP4xPKCDmoAHoZ79IDEXK1O/g+bout49lQoTEx7SgozkgeeEHVqojuAdMFaAru7H RtXRaBvx8mCQTGer9PrJIXVXLh6EOAxmMmaYUcRKkYXDKksgKjIN69riXO+tStvLNUHW6XG/BuU fYJeLkAwotcmonR2Z3bu49KUl4bhh0Jz6nmT4P4QKm0GY2e/zkcf9Buq859UgQrDhgobiJXwewn PJOapBjGFM0KC5HL6kpihwZ3phoEOMUjxMfy4GBBoXJBnjaeBOa5Rp/XIpJPwpYEgOSH0ogqvDl IxEfEtsyADv9NbMEaCHMndAE4BXM3+0qOzVBHfUtjQM+G8DA= X-Received: by 2002:a05:600c:a00c:b0:43c:f629:66f4 with SMTP id 5b1f17b1804b1-4533fc72ca5mr106832735e9.0.1750146871799; Tue, 17 Jun 2025 00:54:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUcqQWPf7LM6cm3kf+uv13qxdjFKgN4rS0XgA5hjJFbgBmHJrv3oPD7MFgGchjgMpwLB0QtQ== X-Received: by 2002:a05:600c:a00c:b0:43c:f629:66f4 with SMTP id 5b1f17b1804b1-4533fc72ca5mr106832475e9.0.1750146871343; Tue, 17 Jun 2025 00:54:31 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b7741bsm13345683f8f.98.2025.06.17.00.54.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 00:54:30 -0700 (PDT) Message-ID: Date: Tue, 17 Jun 2025 09:54:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/madvise: initialize prev pointer in madvise_walk_vmas To: Lance Yang , akpm@linux-foundation.org Cc: 21cnbao@gmail.com, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, lorenzo.stoakes@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lance Yang References: <20250617020544.57305-1-lance.yang@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250617020544.57305-1-lance.yang@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rDKiQzUJgeLCiA8F0sH1spDg2i7ykXaF6WkXdwrBnhE_1750146872 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EAC0E80003 X-Stat-Signature: 1cssmcwqtjp93z7oqy5bw8w5fyzawirm X-Rspam-User: X-HE-Tag: 1750146874-827147 X-HE-Meta: U2FsdGVkX18/ehUS5ePlIurdM0WjVtRNt7DBgO7rwczYf4TYsXoLwUWgrfiB2M3/F3lGruNUxMqlpqHvg6LUepPZ1deeKgebs5DJfooh+RsfMoiGZLX2MmGCGk1eip5MwCR2cUWFx0Re3Cu0P7lgykQ/uguHVu5uuSQrRpYx9hLX1ybb1Cpf0c030dttQ087738Qn0CPDUmkLFsspdUWBn3l4rAyCdospS6GXiJAuRUG6QIXCivLm7fBY3vkP86wM9sU43YwfwSYaR/j2TaNtgU+C5oPG88faXjjrT0f8deAYo5+oH2iqxxybjvJlRXxVuz9rhG+0YHFqW/O9kx0JzVVQkLLyyfGdD3NvUJAXLO0vHacwQr4ynwoie7p702w++MUU9gXV+arZpX1VTEt5mtqKOmdv9CkZaF/cUL2EfOND3FA9cn6d8885JWCvqN3NktkJ1DGxzSjUopFVrOow+xkb1XT8+o8DCXTXZqpudWcpzydo6UdNaBqA3wxpR5wohm83qumtNblUqU91WKTTnWs6y6PyhgIOb9RrtDuCCj6XcnsNmlUrMTMpjgGhibbVwnuSxH5u3Ctva4ZEtB6P8WY0D1oMQklsyslu+erwieA5SoA6Qwo7qdBDP4xkeuHBx9JKw+0aEFy9e2CUUTOgUh8VoUj+ugm9Vcveciw1ObDAS80oEc1sUNLVLTujV3iVMJoIZCBs6qVSb8UL7fpTpDx1imowinQHiH1kvI+U/N/CnpE/qXSqfxLrk3fn33ittdrDrWRCWOI3vZx6lU1YGvDZjY2ePfSuEwG8/SNfFRi4ycMoDfmIXaSzWxwZMQtI36GmrvgQC5ZpWlP+8r2WhBp2yrwaHhENZfuLQ7dVwLV4goda08t8F3Aeh+vm5eGB+seUWKvQcb/fQhh5Qf+TCYJHdmtglwfkBqKCm82UtCR/6yUllbf0xzfRaDn7aFNnjimorHt21hrZLNSvmh pQhZXAbD w/RkvXAyirOyx0N5v5ZQnmBo7UUT9yrOdgtFXyERCljoPtKkuJRW3TvxZ9RIvUJLlp/w+yhX3hQroxoNwhEjMkuSzBt/hv4K8RyUbDeHiwj/ZSdjiFvBfBEwTBArRCKl6cgmf/9izleELBapFnA/FNXXW4nDyoktrgHmGTCKZjJGD6mH+CSqUrFFsF1KXpW7lCFGK9+9KbHt7lwKlwrTSSMqGPXrh8EwLY1HGZpGKXay6sH1hGr+UUUYjWa88i2z/XZ9p6IJJQg+1xIGgPTSgQrLlFp/vJikTyn+jNBnge6J0E+zgdOujZYuekSC3HZXI/5anW17W10w0E47n2G+3baROYgsVyxNmXDajGZLR0AqWtuEZEcquL2YC7DTMQQu8UE2r7sPBn397W96+boePGlcUzOk3sdN9xXH3V8v90wv8NIUKdgmO+O2vBlPCOfu+IBKetCHfBdtZEvqZt2+8phzuUM9bmUsR73N1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 04:05, Lance Yang wrote: > From: Lance Yang > > The prev pointer was uninitialized, which could lead to undefined behavior > where its address is taken and passed to the visit() callback without being > assigned a value. So, we are passing the pointer value to visit(), which is not undefined behavior. The issue would be if anybody takes a look at the value stored at that pointer. Because, already passing an uninitialized value to a (non-inlined) function is undefined behavior according to C. In madvise_update_vma()->vma_modify_flags_name() we do exactly that, correct? vma = vma_modify_flags_name(&vmi, *prev, ... We should use Fixes: then. Acked-by: David Hildenbrand > > Initializing it to NULL makes the code safer and prevents potential bugs > if a future callback function attempts to read from it. > > Signed-off-by: Lance Yang > --- > mm/madvise.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 267d8e4adf31..c87325000303 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1536,10 +1536,10 @@ int madvise_walk_vmas(struct mm_struct *mm, unsigned long start, > struct vm_area_struct **prev, unsigned long start, > unsigned long end, void *arg)) > { > + struct vm_area_struct *prev = NULL; > struct vm_area_struct *vma; > - struct vm_area_struct *prev; > - unsigned long tmp; > int unmapped_error = 0; > + unsigned long tmp; > int error; > > /* -- Cheers, David / dhildenb