From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D35C47DDB for ; Thu, 1 Feb 2024 12:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C6D16B0072; Thu, 1 Feb 2024 07:11:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 377136B0074; Thu, 1 Feb 2024 07:11:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23F886B0075; Thu, 1 Feb 2024 07:11:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 16D536B0072 for ; Thu, 1 Feb 2024 07:11:38 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A33501A0E67 for ; Thu, 1 Feb 2024 12:11:37 +0000 (UTC) X-FDA: 81743120634.28.2FC9EDD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id B1563100006 for ; Thu, 1 Feb 2024 12:11:35 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706789495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PoF+3hQyBjW0Wqz3kA3/JFt8Gn0BHpxTGgftvJLp8pw=; b=oDVjwEqZla7FqeC9j9xEVGMRtJ9IBsgGw0hglsdZVKQLITw9T2HlL9Tm4LzAJTuQVtQkBu Q5MDPeuImPUpWycRSTdhWDtR9Ogd+B8J5GxZDNSZjtHWoIP6rnNufKa/tMfYPRucEKJG1j RyoOt85Y8AAzHUzrdvcHgIdFynFXaDk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706789495; a=rsa-sha256; cv=none; b=QtznSxkntATgfuT0CgAp9NKYcU15LPuls7sXVZRs8sM+9ayEHxRZ+2cEFY5AWKA9QzH5P/ bJlPTT+YXWgFSu/lYnTaX8cei74W1XCNTuyoynU8SgANrWANgyD/TeinokZvdDE7KX/+Kb lzBV7YXU2CO5iVLSYmKVNvkRnXSICPM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26519DA7; Thu, 1 Feb 2024 04:12:17 -0800 (PST) Received: from [10.57.79.60] (unknown [10.57.79.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 681EB3F762; Thu, 1 Feb 2024 04:11:33 -0800 (PST) Message-ID: Date: Thu, 1 Feb 2024 12:11:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] selftests/mm: run_vmtests.sh: add missing tests Content-Language: en-GB To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240125154608.720072-1-usama.anjum@collabora.com> <20240125154608.720072-6-usama.anjum@collabora.com> From: Ryan Roberts In-Reply-To: <20240125154608.720072-6-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B1563100006 X-Stat-Signature: 9iucpf1w55z9z8dbds1n534daqnzw9q7 X-HE-Tag: 1706789495-484108 X-HE-Meta: U2FsdGVkX1+V8ucPtfhAofBPlTJCbxHwnDyp2Kujw4L3zO/753vRA4qSAPfiSmK4qJ3MRqNB2TZmSX+EbNp1cOaNFCpm5rEwbIiRrfva6DniXOUyO1FcfGKbFTGNc7ZD1eoklT/Yv07kolTxVjMLOQTZ95gisL3/1bMVr6E/Cf6SK6AlbirXh/9DhPfGQualgXGss/m6Xe8eq/9v5f7wEw7E+80VzB5eAPSFk2N+HRHpBMvQmUlVKdddY9bOB4tlufoOilg/LWrwuhL2SknYbawfXn/H28gp5N8aaJTqwld3Fe++iDL3t6MoR1soYAOOUXg1i6YxqQ444T39RvcOowlSpCgZfnqBKuaEIPyCS2dbMLzOjKeCdBXqrJ8rWBK5ZGpWhs06LWCTXK/Ev60l1VXEQFyZraqJsCXUTTXx9n3AogBu8PAQQwS2ITbheUIUsyenh9nJ0xyOPRHcNa0pR1AXT0KNj810n24YzYlvSWp2RaxTlUOpzdRjWEkppodZOwveEPo7GzupIJRda99P721CmsgHIYKx4jjh+zSAJaq/lX+YfkDBgwJS8eNCRijhiJ7gj0e7fSH4WqU2IF9SzcKhOmAxuhZGPY07kaKw8obmuyBYUVW3I8b2mVhglNAZtBXbnzlAv/RvM+uQfB3YZHy8I1ZLqq7bgMuWC9nz1746yUv7Eq2KPkVUF7KBdTvBtmveSlEwq38UlwBK9rl5FjISmIwS9ecx4U5jFOm3/i+KrfjRQ/fZyedX0JOI2P7/NjZVyJKcSXZKK6GUAYgV3MPIqr45MQKJJwCyfPlhoKpk17Odmq07bdjKHGCUgXofuYns/npQ5oZgvxIXQ9bnw29FwfF8Zxj3pKYxnjbk7gZ7g2ESgz5JCkRKIwH2NArsXMdqJaJy9/evUg7yqCPnPIkFi/hnWrscAtPfnT7d/d2qUmxtqJuWc1BX0q8609SqImLIcrqXqpuL2E7/age sGz2llJ4 G5C/S1fwhJp7unfNPO20QlTizOzhztipI/Nj0190XPI2b7NnSkooNJ5Svtc7wurFyL9zzdTZV8OwVE8lkCEJn6IbZ5ZHuPVDC6tz/hAf2SClaUS2sxeo4Cn29qizNjP5YGX/V9SYj6MObRGTN/wWW0mPnbMzOWl30PS6rlx7Bkrnhzqa8f7Piuv2nxdYrtFcIoWHvV5u1aA08bVE1H/uDle7UFGVw1KuMnossVgFVLpk5af9zziNELgu/yxsevM49LJETvcj78TfpM6Q1CThPowVQyRzzxpLGA4fE8NaX8D7a+vPH3SqbrdE5Bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25/01/2024 15:46, Muhammad Usama Anjum wrote: > Add missing tests to run_vmtests.sh. The mm kselftests are run through > run_vmtests.sh. If a test isn't present in this script, it'll not run > with run_tests or `make -C tools/testing/selftests/mm run_tests`. > > Cc: Ryan Roberts > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v1: > - Copy the original scripts and their dependence script to install directory as well > > Changes since v2: > - Add a comment > - Move tests down in the file > - Add "-d" option which poisons the pages and aren't being useable after > the test > --- > tools/testing/selftests/mm/Makefile | 5 +++++ > tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 2453add65d12f..f3aec7be80730 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -114,6 +114,11 @@ TEST_PROGS := run_vmtests.sh > TEST_FILES := test_vmalloc.sh > TEST_FILES += test_hmm.sh > TEST_FILES += va_high_addr_switch.sh > +TEST_FILES += charge_reserved_hugetlb.sh > +TEST_FILES += hugetlb_reparenting_test.sh > + > +# required by charge_reserved_hugetlb.sh > +TEST_FILES += write_hugetlb_memory.sh > > include ../lib.mk > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index e373d592dbf5c..a0f37e4438937 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -19,6 +19,7 @@ usage: ${BASH_SOURCE[0]:-$0} [ options ] > -t: specify specific categories to tests to run > -h: display this message > -n: disable TAP output > + -d: run destructive tests You probably want to clarify the behaviour for -a (all). I guess providing -a should NOT run destructive tests unless -d is also explicitly provided. > > The default behavior is to run required tests only. If -a is specified, > will run all tests. > @@ -79,6 +80,7 @@ EOF > } > > RUN_ALL=false > +RUN_DESTRUCTIVE_TEST=false Either call this RUN_DESTRUCTIVE (my preference) or at least make it plural (RUN_DESTRUCTIVE_TESTS). > TAP_PREFIX="# " > > while getopts "aht:n" OPT; do > @@ -87,6 +89,7 @@ while getopts "aht:n" OPT; do > "h") usage ;; > "t") VM_SELFTEST_ITEMS=${OPTARG} ;; > "n") TAP_PREFIX= ;; > + "a") RUN_DESTRUCTIVE_TEST=true ;; The help you added says the option is -d, but this is looking for -a, and conflicting with the existing -a=all option. > esac > done > shift $((OPTIND -1)) > @@ -304,6 +307,11 @@ CATEGORY="process_mrelease" run_test ./mrelease_test > CATEGORY="mremap" run_test ./mremap_test > > CATEGORY="hugetlb" run_test ./thuge-gen > +CATEGORY="hugetlb" run_test ./charge_reserved_hugetlb.sh -cgroup-v2 > +CATEGORY="hugetlb" run_test ./hugetlb_reparenting_test.sh -cgroup-v2 > +if $RUN_DESTRUCTIVE_TEST; then > +CATEGORY="hugetlb" run_test ./hugetlb-read-hwpoison > +fi > > if [ $VADDR64 -ne 0 ]; then >