From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB3FEC369AB for ; Tue, 15 Apr 2025 07:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 840B92801CB; Tue, 15 Apr 2025 03:23:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7762D280154; Tue, 15 Apr 2025 03:23:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A2B82801CB; Tue, 15 Apr 2025 03:23:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 35400280154 for ; Tue, 15 Apr 2025 03:23:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F2C43140F92 for ; Tue, 15 Apr 2025 07:23:50 +0000 (UTC) X-FDA: 83335438620.12.FF039E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 6AA501C0005 for ; Tue, 15 Apr 2025 07:23:48 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Po1Odh1l; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744701828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nykEKAeh4acsKdXeDPuBQHlu5evELl7tZo4cGDJKvLs=; b=dJU5o8ZJ0G6sma2cwgWhGVrpKqL7+dbDaXMhfuxWECz/pMFQh+cy9yl/Kq18kle310HRGY H3wMS1TSFwYrezjapKuMfMGl6ljCQOp2pIm2A6w0RgRE1wwKU+sz/PUMftWgPhaDi3520Q BzmQsztDQfe0r4sm0GUVT9wZBJ2AD08= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Po1Odh1l; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744701828; a=rsa-sha256; cv=none; b=6oSB2rp5qBrBYpEMNEaeNwqkHo1qcqXH2UYxPXQFOY0lWw7KErxWooYAh+bPASKBD6P6Nu XIb3Hp8MpKiFKkD0v9gdqaBeBhesFa9NQF9McmDfn86YBrt4UApzbWDZZoCcTnOl+P7+V6 2J+ciLhv4zWJoCDF/nK+16VL9LqxYKU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744701827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nykEKAeh4acsKdXeDPuBQHlu5evELl7tZo4cGDJKvLs=; b=Po1Odh1lS7wwLXRVI3A/CVGculapIFa7N9yAcm5pvqQqohUwMdelMhQvkvEynKvfcmIeE7 JxBFMMHBHIVS4jYDY8Pf3TH6XvuAh5NUWYJy1rBM676R8khWO0pi3oFlP4FlmrSVTPtd29 mELa6IAJHxS7YLSa63qzm8Q/uIZDhCg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-TEtZm06pO0-5Vn06L0o0Ng-1; Tue, 15 Apr 2025 03:23:46 -0400 X-MC-Unique: TEtZm06pO0-5Vn06L0o0Ng-1 X-Mimecast-MFC-AGG-ID: TEtZm06pO0-5Vn06L0o0Ng_1744701825 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d734da1a3so26098885e9.0 for ; Tue, 15 Apr 2025 00:23:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744701825; x=1745306625; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=nykEKAeh4acsKdXeDPuBQHlu5evELl7tZo4cGDJKvLs=; b=EJ9RztTWeH2Ap/OJiRj+AaT7YNwTOPKChNTbL5vyDrqs4+qaMVGASfXRIWPZjA1WCr xYqOhpEP0EsvmnRxOS3/yl3yNHOMKBbL7b9b+riczsBRtRUVsAM6KuY+eeIeAb9bnTxp l00uElvcZ4PugGnyKiSqBd7Y6Rkt47Lf/D4Wc8bL/6p0xOMDm5ZT7cj71JFUkXA8zVUH 0x9cV+XvV4tBnpjJmjhfgy/GPkxWz18ldYYV1WoeQndyj5gxkwO0RjDPOhZEYOhzAs7F uDbRnTPvERLTt2Bo92iXhM7F7CeQVrwIUg51Ky8fZa9hYgYOc2UH3oVB9Yw1BsEEXh1Q Cq+g== X-Forwarded-Encrypted: i=1; AJvYcCX6TvzabUGsNJsMkn9PbLSoITKlJH7wFEb81CSn7xIDt+oHGwVPxqYeQjZxYqTqX66LwgfBk1W3QQ==@kvack.org X-Gm-Message-State: AOJu0YyNnnFEwixXtDwe0/4A2AKZGTfTN/8gH+GnWlWDcALF/FIMzhrg rBcw681Xk0TSrLA44Qe5ax+z+P2lLfkxnl6aJyWO1ZuZBkH7M/oGAD5QXC4k0N5hDI3s8X1ArmW vmuWb0eyIOjQ9wM73MQ9TejGDyti6bAJ8ATJOWP7yAbv7L375 X-Gm-Gg: ASbGncto7ZNBucZQ7TM/ahwvM5/tZj2fE5qAeSjYw2mZ2pmuj2NuMemSb3ptiNkEgkp G8pV5dIN/TJBG+6WpjaEDZECapmyAQ4phFPbupbjQkOvxsl/J1abKOIqIeOLrFzGbcD02CxZCTT w/xXSGWF/sJHBQfcx4sMu6sFpd5/WEO0+McqfLzCkBIrupcKX+RblJBmyJFVb1TrYG3jOwyThXy a28GVkmJLbltEdlJx2q+sWe0pdEoPNcbDDLaqoV7URORXGXX07REsedTd/xCZ2rIOqCjEjfISyt 0chO2exPFdpRUDuzzpewx209wFquzXn9ymfog56/iG5Ta7uh3q8df65pdys8Ed/w3zPp5L6Hrku b0zryMXvK7QK86pbKxXxXWatyp0facEQMNuyDsg== X-Received: by 2002:a05:600c:5897:b0:43d:d06:3798 with SMTP id 5b1f17b1804b1-43f3a9aa683mr86748935e9.20.1744701825195; Tue, 15 Apr 2025 00:23:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAZK9ne9BFrFBK9FNh2u572GCWpZNZnHSV61pujmCWL3CNM085fealxx9BR5pYLq2FSGJUJA== X-Received: by 2002:a05:600c:5897:b0:43d:d06:3798 with SMTP id 5b1f17b1804b1-43f3a9aa683mr86748695e9.20.1744701824738; Tue, 15 Apr 2025 00:23:44 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d7d8sm206192665e9.4.2025.04.15.00.23.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Apr 2025 00:23:44 -0700 (PDT) Message-ID: Date: Tue, 15 Apr 2025 09:23:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, hugetlb: Reset mapping to TAIL_MAPPING before restoring vmemmap To: Oscar Salvador , Andrew Morton Cc: Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Matthew Wilcox References: <20250415054705.370412-1-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250415054705.370412-1-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UqJ4EsBH2OKwfVNJlJPo8_YZEFM1_QSDyknNkjTsmcQ_1744701825 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: zygqzbkpps1g5qqto487gmdowhmh58ou X-Rspam-User: X-Rspamd-Queue-Id: 6AA501C0005 X-HE-Tag: 1744701828-66671 X-HE-Meta: U2FsdGVkX1+ukFgqJ+KnxpwLqZ4uXVZi/Y43JLUEAglBb+oPpAUJGBmaECobQ1uPNkWQWqf6u5Pm+nIYGkOULVr+rNSpSsUOsRZMDLHjxtbOYoy8rPTrNQHVntUtajqloX/IntBfaUGoNV5gFv4icuZYEduAR6FFgsxPLpAj3wZ6/1EE63kvPc/wTf4XILM6MaXI+xG6X6yOkLkpqQQ2tKXTG3mcKqq81/n2gMvEjjMJCbwzVX3AiH096/KZ2ilVUAt4Mtl3xWaAmhBBw6M7moJNijwipsutmQiSHXmC/kU3mdht72u5dTDvdg90mYoBkCfLlKhiAM+yqSrlICxXLbFv62s9fzLqf+AVs0oPS7OWkZmxBv00yAfS1XEyh8YErq8Mo/TnnUxRSpLOCOgb6vmaPorWt0PXNzSjP/0UwnDmtmL+bbRIK7PguTaGMhVTHjCi1rZuqr7mtRleEIRnmt/y59iekCexS5ycJSf+I6b65XJ5N4UcmbeUHfl1GxgiQW3T8751oFmgLSEEm8OISb5ELpY2muFUTOoi+1WXvZzP3mgQd3M0Vxzcpb3AFaEVRQ6+5Ks0W4OjHOKImAEym6qYA2tZS3JtQJUyU8849oBTsaUTVYgG/X4KgTj2cGO4jkbVEZGTTWrx/5PFLjiafUdWMFIuUKoRAfp2y0K1y5D1oSXYAe5HYJTSWU4CuwGGVRg1JWqoUTZB1UtGaj4+4CcjbUVJhXTaagtp6w9fEqiJU+Csfc2PnWCUTP0CS5ute+ne2FDh0c3fSYm9RMQZAUASrnp6eKQflb3YsLKXDeWX7++dd78JVmPAw92DC7g+MAnRm7HYUhL95KGxeipNslsbs6Yuas5kmOVIIccxrB1SJdPBMqZ8tnasPjVypAsFqGAIm4QEphVsmU1GX4WH4RcRMlMccnRhGIiVrbL9tHXhMKyl7DPqZXRfyfSS4Pd3C2Hud2wwK50HQIEYU4L iayinNJC DUvbCZ1o/LHwEhrqxKRLccIqhRz/rDpZ1WiKGdeH/163Fz0kiUDY4Wk/YqV5pQLs2s/VGdD6fQzUgFiIZp2GZtmSzo8eTeNo5O6vTKPnsFwNB+cDIBJsumKfJ4LqqutI+W2VHkbZqiVim2XJRWxePp9Ns2DtMejW+xHLNX39fJBN8baYGiNjZ+4nHjqL9JraPAFpK5eNV9Q2Sk2AIv6KbkN0DkXQn2F/nu4KRyDmkbQQ71wN4al7qmcxe4FI2NLbLDQcHNAzL7Q3HDgPgpELXOWRteVIlvgImVHA377T2Y+aR9DJSUPzctQVn47GmbA7eV33EsXFpeftOOzF+u51cH6XTSWKbeJkR5JUXzQTw5Q/Wlt+h6lJXfxaGiN9ICM8cWWyjl8kG7ECeBNhE0hMzpHoTQpForn0ZaTFdxs4wqkalOIWWrpHs9DmgyMdXa8BsLrnE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.04.25 07:47, Oscar Salvador wrote: > commit 4eeec8c89a0c ("mm: move hugetlb specific things in folio to page[3]") > shifted hugetlb specific stuff, and now mapping overlaps _hugetlb_cgroup field. > > _hugetlb_cgroup is set to NULL when preparing the hugetlb page in > init_new_hugetlb_folio(). > For a better picture, this is page->mapping before and after the comming > for the first three tail pages: > > before: > page: fffff51a44358040 0000000000000000 > page: fffff51a44358080 0000000000000000 > page: fffff51a443580c0 dead000000000400 > > after: > page: fffff1f0042b0040 0000000000000000 > page: fffff1f0042b0080 fffff1f0042b0090 > page: fffff1f0042b00c0 0000000000000000 > > Tail#2 has fffff1f0042b0090 because of the _deferred_list initialization, > which was also shifted, but that is not a problem. > > For HVO, upon restoring that gets copied in some tail pages (reset_struct_pages) > and so those tail pages will not have TAIL_MAPPING set and the check > in free_tail_page_prepare() will fail: > > kernel: BUG: Bad page state in process kworker/0:3 pfn:10ac40 > kernel: page does not match folio > kernel: page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x10ac40 > kernel: flags: 0x17ffffc0000000(node=0|zone=2|lastcpupid=0x1fffff) > kernel: raw: 0017ffffc0000000 fffff1f0042b0000 0000000000000000 0000000000000000 > kernel: raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 > kernel: page dumped because: corrupted mapping in tail page > > Reset _hugetlb_cgroup to TAIL_MAPPING before restoring so tail pages have the > right value. Hi, To handle that for ordinary hugtlb alloc/free I added in that patch in free_tail_page_prepare(): case 3: /* the third tail page: hugetlb specifics overlap ->mappings */ if (IS_ENABLED(CONFIG_HUGETLB_PAGE)) break; fallthrough; default: if (page->mapping != TAIL_MAPPING) { bad_page(page, "corrupted mapping in tail page"); goto out; } break; } Now I am confused why that check doesn't catch that? Apparently only a problem with HVO? Because I recall testing the ordinary alloc/free. -- Cheers, David / dhildenb