From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43760C6FD18 for ; Wed, 19 Apr 2023 12:06:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5D198E0003; Wed, 19 Apr 2023 08:06:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE6008E0001; Wed, 19 Apr 2023 08:06:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B389E8E0003; Wed, 19 Apr 2023 08:06:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9E0248E0001 for ; Wed, 19 Apr 2023 08:06:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6710B401F8 for ; Wed, 19 Apr 2023 12:06:14 +0000 (UTC) X-FDA: 80698012668.10.048D29A Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf05.hostedemail.com (Postfix) with ESMTP id 1737C100021 for ; Wed, 19 Apr 2023 12:06:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=MaUkKBXx; spf=pass (imf05.hostedemail.com: domain of frankja@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=frankja@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681905970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XxQyWGNU20y3Wnv7oBYdxQVoyeJRqhv7cvwcPncLqqk=; b=h/fbfshV17HmNl62bPi+GKyTv1Met0ShiBuJO8lnVYhuBJiopKhSZWZPOswHyh3y36Osgr w0VXB738x/O8ytp4HfYTsNnAjGPzeUwSFM0TJBrcRoJbS1VPf+VQ09AFVhv4kac4pNmfDq d0zW9x/D/M2k8e5ANPsT1sexdpzreK0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=MaUkKBXx; spf=pass (imf05.hostedemail.com: domain of frankja@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=frankja@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681905970; a=rsa-sha256; cv=none; b=ahsKsl8NeADYJkdEgVTZqt0CyWbVSEp3gz9+pPmaNgqn49YNqt5DZT9zxe2xyFCpSlKg+D pPzEiOx+aiavhQvnPf0p3aranwQCp4Gjv/gWHqQcyeO0C88TWKxnYiVDScuCkzr39pR/Us ++xO09n6C2MRJFtD0doamgrbj/xGjEI= Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33JBmiVs034942; Wed, 19 Apr 2023 12:05:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=XxQyWGNU20y3Wnv7oBYdxQVoyeJRqhv7cvwcPncLqqk=; b=MaUkKBXx8iVhZnQfi2RDt8faEETMnMKAbEzNZO+lpYZA4Qzm/42cfcABcujSIwghRV0X 3PeqNDRd4IaTppWUkLe9WhVR7DHaK67napzSWb0/fyAY5su8TJWCvhMrkWNBKYnZzWpL nrZow2Y7r/vmn90Ku0+11UMeCHt4krQqymOUrwysBfKhQ3gB8XVNTfmR2AisCvruWOoC HGrgnECisFQCMRlF+rKjlvt0AJiiXkbKhxoPOW9SAl/j9H94nYFHqgnk9sLjyUqIjTb9 M4kh5I4Iraa1TWc6fPCqKtgixwG8fAM688OISqzSFuM22pbbenILF8ksGHq+DRGoNVxP lg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q2apmt6hp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 12:05:38 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33JBoDWh003607; Wed, 19 Apr 2023 12:05:37 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q2apmt6g9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 12:05:37 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33J0WAFx000870; Wed, 19 Apr 2023 12:05:34 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3pykj6jqcr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 12:05:34 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33JC5V2D45941078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Apr 2023 12:05:31 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4647620040; Wed, 19 Apr 2023 12:05:31 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 91F6F20043; Wed, 19 Apr 2023 12:05:27 +0000 (GMT) Received: from [9.171.27.132] (unknown [9.171.27.132]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Apr 2023 12:05:27 +0000 (GMT) Message-ID: Date: Wed, 19 Apr 2023 14:05:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 3/6] mm/gup: remove vmas parameter from get_user_pages_remote() Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, Catalin Marinas , Will Deacon , Christian Borntraeger , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kentaro Takeda , Tetsuo Handa , Paul Moore , James Morris , "Serge E . Hallyn" , Paolo Bonzini References: <7c6f1ae88320bf11d2f583178a3d9e653e06ac63.1681831798.git.lstoakes@gmail.com> From: Janosch Frank In-Reply-To: <7c6f1ae88320bf11d2f583178a3d9e653e06ac63.1681831798.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: YoUBdd5kWLHDb-6WjYvIk2NpjLH1WX8c X-Proofpoint-GUID: aezbm9zbIzDKmcuHzP9oULlrIcksYyaJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-19_06,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=566 adultscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 bulkscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304190108 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1737C100021 X-Stat-Signature: qrapab6ecbnzofjh94rumt7jmzx4qap9 X-Rspam-User: X-HE-Tag: 1681905969-949951 X-HE-Meta: U2FsdGVkX1/tqR3bDjjKb9JTk3o7poCK98D/hREXj/Sa+d6l0ajFezdUo6OaZKZpyX0NPqjKiuFVeHHbd55c/Fm05vXqWHut0kRF1F69vnAqR0b1HgegnO0BiG4asDqGS6j9A9fiAqphViltLiEtCdxgfNLW29K87jgvYDAyjG1o/5ByzFyP+rXX9ICmxZ9IlSkv2gvftK27y8wMfj5Q2dl6slDzS0Zl7AZW7QW6I0gHtYyDKL9mQidkGrJ43lp2J8UMTB3Kp1tY84rfMI/LJZIWsEU+0h/GM0d18upyI/JyMA8WUfEfUk3HArP8pZzhazs1z/CoROKOoLfJCM8dy/ng57r+SlhHdr0IqEK/JS2Nnv0Tdl9PlhaoMWbcKE1KtmhERxgUZmD61wDNzkF6blcZy6m1q+aru8GXvA7//NSynG78BXk069SzvVs06b5/P7Yns+GpjgOSJvo3r6orA6uEMOD2DVh3CGXyhlUqV5mb4Ny5+X+L9XqBpxTC1LSy5jN8mE4l05VgJkS2Sug/qyl3w2RcEczHG/YKR70yc0wMqpgRNKhOpTSE/K8y3w1Uid2cHMr56E6SORRK6hZPQY+8FUAA7KndDElSW9P0HF1RBK13X7VCZJizsmiYcSbTNHQmGhQtfAxjzjTa6Sb85wAAY5Hz4hruEbVZNbLGpHWwNYFQD4374jdBNxqsa+UpUq+6z1wPP4FDFCoxauWTsyJm2dvLU8dLK2ThQKchF/lb1xAn2SZc6KV0txjQrDaHbx8ypahFT4BlqZpOCbhQ0i2cF/EzoUkOG+sTOQYoR5aFxqrOlV9a+Lm5DelRilPDU7N4oKj9CASXv/KWFVZWUizSbZBHKNstTmmT/qeYryyZ6YzgPuy6X+TCZ26m/A7D23FuocB+mnGXWmbqU4UFm6jV9OzU9A5+r9AS7Kgs3Q9DaywPby/li2+3y9n5wr+z/e86JQm5QGUe45QMrvl MTdx9Vfu IXpoeVazvWPiBo7yR0BSBOUQy8kYyhw8rabkec/d68egvwZZSpA4bpYlmJVNbcxUleAugFJI0lGuBXcKp7tMym+M4xl7i41HtXPd+t9G8kG7bu2zErkZib0y8Xalh/SGA7yYowkPJfEDqCzVGCtAQArNVoGcnkY6Bd45ARpnLYLFVHGKg69ZkQ20LT+hgDT1Z7n2cPkKC5PkQGUuxox8E/20gDviKoi3FP/xmCsm0vrgFD2+zIis1xcLPMi/P2M0DcKLgY5+lMP1uxDGlcOKiToPMDjbn1+TVCT/iXSFXmw4XZFL1xeFlHaVWfE1vCLcfcGCo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/18/23 17:49, Lorenzo Stoakes wrote: > The only instances of get_user_pages_remote() invocations which used the > vmas parameter were for a single page which can instead simply look up the > VMA directly. In particular:- > > - __update_ref_ctr() looked up the VMA but did nothing with it so we simply > remove it. > > - __access_remote_vm() was already using vma_lookup() when the original > lookup failed so by doing the lookup directly this also de-duplicates the > code. > > We are able to perform these VMA operations as we already hold the > mmap_lock in order to be able to call get_user_pages_remote(). > > As part of this work we add get_user_page_vma_remote() which abstracts the > VMA lookup, error handling and decrementing the page reference count should > the VMA lookup fail. > > This forms part of a broader set of patches intended to eliminate the vmas > parameter altogether. > > Reviewed-by: Catalin Marinas (for arm64) > Acked-by: David Hildenbrand > Signed-off-by: Lorenzo Stoakes > --- For the s390 part: Reviewed-by: Janosch Frank