From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58931C4829E for ; Thu, 15 Feb 2024 21:50:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDF888D0013; Thu, 15 Feb 2024 16:50:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8F698D0006; Thu, 15 Feb 2024 16:50:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C09588D0013; Thu, 15 Feb 2024 16:50:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AFC718D0006 for ; Thu, 15 Feb 2024 16:50:41 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 81A0F120402 for ; Thu, 15 Feb 2024 21:50:41 +0000 (UTC) X-FDA: 81795383082.05.A9E2464 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id 51FAF8001B for ; Thu, 15 Feb 2024 21:50:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Dt8snzWR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fMBcDkXf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Dt8snzWR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fMBcDkXf; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708033839; a=rsa-sha256; cv=none; b=ntdmY4LbibQ7yH17G128YHMSA/DmOtolTMRxQDuqxLuvUMA0IoCDMAoRwDqASaHpKyX6Ta ny4RtGwN588AMzniSJ3HIdkLMSAw3OYax9z06msziD1avtLpMLFDzpmOcsj4IrKAhjPKuQ RlOAk/QTYJjOXhsZqjGpCIh0qaqX+DE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Dt8snzWR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fMBcDkXf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Dt8snzWR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fMBcDkXf; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708033839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PV2jhmuXtgna00Xa5XigbZslr56lI5Yx29VeaYM+7Zs=; b=T75Bbp1mMUOmmsDdYOYHbIBd7PQUdgouunBq8cj+C39YXiibFufBVujeFqbDjeXOdHP1g5 a6mPJnsyX6p+dZ3T5vMHRt7CdGOlG1Tx6lgNxcEv56bwhBT7tKuTb4a8lrAQuE4NoRsfCG eS+cScK9++K+py8OE1aO2WjceiZc1x4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C20A71FB3D; Thu, 15 Feb 2024 21:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708033837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PV2jhmuXtgna00Xa5XigbZslr56lI5Yx29VeaYM+7Zs=; b=Dt8snzWRDzt5u+n7VObmiYvxWro4RymUpbiy9sw6TJUMHM7ygUD5jEAxWkRS7EzXUv8zi7 ktWK6jolt9A0D7NGfbauD2ABizMFXygQsNOY5kcVfPjw/IQVTSy3RBsMvbGiWV66IpKOLm +RXZxjZszD7RZGyYJUHBpVyt5gyyCrQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708033837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PV2jhmuXtgna00Xa5XigbZslr56lI5Yx29VeaYM+7Zs=; b=fMBcDkXfHOR+SAskPJRLfaYNJtLmrqLqJTOD9a9kdNJtFih9vtJOhzZxQryT203bFs1NmW kiz2q60HV/OG58Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708033837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PV2jhmuXtgna00Xa5XigbZslr56lI5Yx29VeaYM+7Zs=; b=Dt8snzWRDzt5u+n7VObmiYvxWro4RymUpbiy9sw6TJUMHM7ygUD5jEAxWkRS7EzXUv8zi7 ktWK6jolt9A0D7NGfbauD2ABizMFXygQsNOY5kcVfPjw/IQVTSy3RBsMvbGiWV66IpKOLm +RXZxjZszD7RZGyYJUHBpVyt5gyyCrQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708033837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PV2jhmuXtgna00Xa5XigbZslr56lI5Yx29VeaYM+7Zs=; b=fMBcDkXfHOR+SAskPJRLfaYNJtLmrqLqJTOD9a9kdNJtFih9vtJOhzZxQryT203bFs1NmW kiz2q60HV/OG58Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3743813A82; Thu, 15 Feb 2024 21:50:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6IIYDS2HzmWgTgAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 21:50:37 +0000 Message-ID: Date: Thu, 15 Feb 2024 22:50:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/35] mm/slab: introduce SLAB_NO_OBJ_EXT to avoid obj_ext creation Content-Language: en-US To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-8-surenb@google.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 51FAF8001B X-Stat-Signature: psdzaotmiforwe6dbhzbaxunxzsogx79 X-HE-Tag: 1708033839-830423 X-HE-Meta: U2FsdGVkX19i34fteGy/EyVzwv0aBVoiwikogz6mwAYWoeoUGEr5e2iE3RaP/Oi2hOFJnp4qE/r27vEauO6MYNOwj3tJ/UsQ9mnrie6wLUlI3FggbkNJJU6hlfuHOed+cnOgPtkjPkq2SD3VMtQhHjFT6FuHlSXsx75YWdbYUqajYSEGbLEA+li1qignlobfIj90xjgU8If02mOjRfAJMJhTPdgWm938PXdQ0HoVfUIbWiUIEzMCNb3R0ogifOIjaJ9pjIxDGmbFwOW73289Km3ZTq8IM2xAlgzlAd3RICiZO05rRkBlOouqBwqhLDXV6m9RnTmyrmmxaNAyGid9SuTclM56wq+7+QlMJV3uV1bSFdOLJ1nj8dA6oe0BFtj/osmAKWOI+AcMVX0RtGfv+B+/LUaznZISCBCeo1gsSC2/3w1TcKHMzsb1GLaB41BRa9PrXCsKfP1LGKpy2utAlPiA8PUa2G24oyMMlf8tH5np7nynI7+Ay9gwnrQDH+XTBRCycxrAltqygtXrVHm3/7yX2wBN3pASmVKP2PqMb809YqorOvFjf+4sQvyBd8u/10Q9gpHo+aGAx2XBYFGGMPkUXvuXEy3FOq9jUmQm+Heux41nJWX25WEthvPHIq2DHOLU1dmr13jJ/Vl+qc26LgwesUU/VzURD/4fvcz2KovCsTyVBOK6mkJeyZ6EuMDxeeIwTjbzpKbQZYkBN0g5iF91lFj98FNS/oZKiEJrqoXiD9zcjsEFpY8rr5GswhjmuAuxDapP4y9MH0EX1V6VLrypBG0A9A2IxylWOwoWTwsb9+bX0aUOG3mgkas28LJ2D2JEEwCSxawYXyIiLexVd8qVcI+r0LAKmqss6btZQR1tHQalAhxmEWL4e5gXjiOjabSAy/Gz/X8z5w/wzNEMc0ca0ciXhBXL/TVcW01aDV6+WJfnIL0SubeNOUwkB6TIHrUom08FPUC4ElyKaLj /+9gm92e +hi1du9kFIfG3WG51EGRkWEq3WgrqHpVNnVyFsOBOXE435RYDziMC+eOvWks2/D67F8eIJSxc5TwHtOd9Fhn8hO7iRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/15/24 22:37, Kent Overstreet wrote: > On Thu, Feb 15, 2024 at 10:31:06PM +0100, Vlastimil Babka wrote: >> On 2/12/24 22:38, Suren Baghdasaryan wrote: >> > Slab extension objects can't be allocated before slab infrastructure is >> > initialized. Some caches, like kmem_cache and kmem_cache_node, are created >> > before slab infrastructure is initialized. Objects from these caches can't >> > have extension objects. Introduce SLAB_NO_OBJ_EXT slab flag to mark these >> > caches and avoid creating extensions for objects allocated from these >> > slabs. >> > >> > Signed-off-by: Suren Baghdasaryan >> > --- >> > include/linux/slab.h | 7 +++++++ >> > mm/slub.c | 5 +++-- >> > 2 files changed, 10 insertions(+), 2 deletions(-) >> > >> > diff --git a/include/linux/slab.h b/include/linux/slab.h >> > index b5f5ee8308d0..3ac2fc830f0f 100644 >> > --- a/include/linux/slab.h >> > +++ b/include/linux/slab.h >> > @@ -164,6 +164,13 @@ >> > #endif >> > #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ >> > >> > +#ifdef CONFIG_SLAB_OBJ_EXT >> > +/* Slab created using create_boot_cache */ >> > +#define SLAB_NO_OBJ_EXT ((slab_flags_t __force)0x20000000U) >> >> There's >> #define SLAB_SKIP_KFENCE ((slab_flags_t __force)0x20000000U) >> already, so need some other one? > > What's up with the order of flags in that file? They don't seem to > follow any particular ordering. Seems mostly in increasing order, except commit 4fd0b46e89879 broke it for SLAB_RECLAIM_ACCOUNT? > Seems like some cleanup is in order, but any history/context we should > know first? Yeah noted, but no need to sidetrack you.