From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971C4C001E0 for ; Mon, 31 Jul 2023 11:45:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F077B6B00BE; Mon, 31 Jul 2023 07:45:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E90B4280023; Mon, 31 Jul 2023 07:45:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D30DC6B00C0; Mon, 31 Jul 2023 07:45:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BF9B36B00BE for ; Mon, 31 Jul 2023 07:45:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 71A6D120B49 for ; Mon, 31 Jul 2023 11:45:50 +0000 (UTC) X-FDA: 81071727660.05.04B5D8B Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf15.hostedemail.com (Postfix) with ESMTP id B064CA0019 for ; Mon, 31 Jul 2023 11:45:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=VT13zwPY; spf=pass (imf15.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690803948; a=rsa-sha256; cv=none; b=lDx7EBhrWI9M50SAcI7OaIgxVUjLcv9JhXmVso9i51lPHBnTHgccEXiGBYHretETdnj1io gbKGfPPQ4RMSfPqPa/6c4odJGzO2/Ks1IvJG4H5DT8pVcF/OUUhhOQyguwMjZFOdkre5ej QFzz7NkFdARk7XP3jUvR+NlMKTPdn00= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=VT13zwPY; spf=pass (imf15.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690803948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eixVz+lC2CT7QVfWGuIxIWOZy5K4rUiP49mRPzTth6c=; b=zDMeLkMG7RUj/62aKX0hiUR/EuwCeAbp7OTMObYPjBD87OmeS02JUCf7PoywWFQ9CtdEFC koBmKYYxJFfPEC04n1iovcZNO7dcr89LfQi1eAqDkqEJzzXkVlBz4y49zHE/WReEAXY1g0 6o7aU+a/A0jzn9w/3E/u6EtGtLdUWPo= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-686b879f605so2848641b3a.1 for ; Mon, 31 Jul 2023 04:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690803946; x=1691408746; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=eixVz+lC2CT7QVfWGuIxIWOZy5K4rUiP49mRPzTth6c=; b=VT13zwPYUAOAfBEH3rgUxFldZISumpumgvx/iD+w+BPKXFCSw3sb4v14W/QgLOOhbW Y4qIeqO4CObDAuwhvipQAF/Nxwdfy7bhGuyOdCPdgvA74GZiUNA7YMGM2eJh0mgKpjun mbuYrgNQg2POZNYGwztFta3wBsE1ysU2dL3o/0F2XgHLPdsBU4kATSfglaZu9LdweHrO bc9/9LGBiT2538a98gFqSDRWXk4QjqRgfxoau2+N8CLFE5sgcBFdagXToM/WS7YhLx40 aAfi3jZsaDNavimHFkfpKR1AsIE9HlF8UzHi7DX9PX+WONweh99kzIdKxsN7CAlxRgQ/ uYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690803946; x=1691408746; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eixVz+lC2CT7QVfWGuIxIWOZy5K4rUiP49mRPzTth6c=; b=jMK4eHoQRCrSCShNtIHizULBIoUt6Rx8b6FT0MoY2XYAy+ioDN6MnndYS4twJzakpY VQL6j/PazvaxRcegHfy/cXdDvnUgScqQwsrB064EtIoKb7WKmGe7DFjF6N3Bm5nanwI/ BpfN3oO3kYbWj9Edk8lAzhinqznHxBMFYR40UESKTv9QYvLk2yJqHFnU6F4HWVNwPWS0 TffzdgLaXJJjdvtOUnKmvMRlcfURhQSY+4QkfEsnAiqDENF1P7fMiyVNy+tuj0mSA4y/ KyiHiTNEpsJilVII5qX4PoBXjobEc8C5XMlvOJWDoheakoH+rc2Rh68cXI0PjW6dqRJ3 dRtQ== X-Gm-Message-State: ABy/qLYFCfoPklHdCMvAMefIvOVfa5YiVb1yHn2QgwbpZjJH36o4tnd/ eDLbqMbRXJwVK9UdkUwjnYJ9gQ== X-Google-Smtp-Source: APBJJlGydmwkyBJiOoqdphaZJq4iW3Nm7CDrOuaHl7TUuebUj9EajXLsR+UqO8/g3DIuDKwJOE5j+Q== X-Received: by 2002:a05:6a00:194b:b0:677:c5bf:dccc with SMTP id s11-20020a056a00194b00b00677c5bfdcccmr10108630pfk.19.1690803946336; Mon, 31 Jul 2023 04:45:46 -0700 (PDT) Received: from [10.90.34.137] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id n9-20020aa78a49000000b00668652b020bsm7440809pfa.105.2023.07.31.04.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 04:45:46 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2023 19:45:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 03/11] maple_tree: Add some helper functions To: Matthew Wilcox , "Liam R. Howlett" References: <20230726080916.17454-1-zhangpeng.00@bytedance.com> <20230726080916.17454-4-zhangpeng.00@bytedance.com> <20230726150252.x56owgz3ikujzicu@revolver> Cc: mathieu.desnoyers@efficios.com, npiggin@gmail.com, Peng Zhang , corbet@lwn.net, akpm@linux-foundation.org, michael.christie@oracle.com, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, avagin@gmail.com, surenb@google.com, brauner@kernel.org From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B064CA0019 X-Stat-Signature: jx5fy815bdx7es95c1tzuksrpuj9yzbz X-Rspam-User: X-HE-Tag: 1690803947-157712 X-HE-Meta: U2FsdGVkX18uSia9rY5tpOvQ9iNEY5bVpM1WVSmJnPGZUKGuv+YoZJyutQfvvBbXv9k8oNq2JPLRxwGV4uuAUD9ad6LA2jQGK8DJsbMZsaVwRCXsD36XHYabpkEN9GIB+aqsuKK4w1OBle09jW8OlLPaXt1Nf8JqXQ42v2VQtXTU8Ho9vB3FyjKgO4QHFxy7du8NpxdM+NwuSWZE8NlQkrZgESPi9OkzSEcZPkPnk+HPQZT+l3owS30aSGk3jcGfiEGnypCm+laQtPXE2bISObdtpHPFUEkqM8Ut4qVR3rSVpfT43CVyFDPeQbj7Eh3wHGVwYM+Woc3syCJeW84Ey4WlElfbPRUjXvV/AD5O9pEbr0yaE2pwZvu1iGje8BzbnCSCgR8qmPQQQApg+JXd3eAIlpEVFl6MD/UdW/g71vTwOSumG/jojmbC4VC2eh0vbyYmw1v3L6Oz3MuEMtc7G5+YHly7MrU8daxYCmkZYI+RpfRJv7sc/Vrap3IY3TkNfw5O2u/36ajQumRkqml+4nuTACkJMt5TCq5WPrdlsXeMvGnNI2DX3Dm4V4SyTWXzSaiIbj73Ie01sW45WAGL3IJiBaJ0tenSBz6rxGWiCyt46Z5XBMblcsgOV95wiTkQCil0/Gy21n/wjMknlGoFb9KzNBgC07OPmDUF0DbLDQBv505uqdYHLQ9A0axLQoWZLUdjfgMI2ZtFUowQ9TWDb6hMauuhirE/stiAjrZmNaourVyrzE2ft/uAF5N2lwGBW52ARhWLgCmw9Eo1G101+xmpzQujWbVeyVuxtqXctze4R8jqx733uXAIKGbBnMB1dzloBd/I6C3ym70+NbwDFBFVW+cikZxSciV0x+DlWoUfskpD6JcLCsYYhuppKkhrOzgdBbJalcbQEGE7mdwbwfqFeCQ6omXbeo+6nJC1mosKoxiYz+y2ptok4onAcUUUIJiNsYyE+nX3IcXUh39 vbcdchhe +BUek/Ex1EbPTXd3HYoyh1FCiJjQAz3atzd2eL+l6LvdLWqUxdAvZN0nVvGhWe2QSOYVktZeNotOGxuBHJ0e48cIx0ls3enep2znIgy1XatnH2FyOG0iA5wyLAx6i74sGmVrmEIPjw4vNP5to+sS/aAyQiTMMHJiWTqW2wfZbjITeBz/ilSttPkkp1mYKrGJwcHNeeQSigIvx7meSkFBAcZDbRfaXJmY9JU4Vx9u53wDFks1M3HuG/SOXiikvHs1/L+LL78Ja1moe/fuLSQruNgM/OqfpT2SKaBMejAXgVaN3xJUPcXc2QDenAc80zvd4q6Dh80iLtVS+4a2yG1LeQv+V6qXxpB1uJZtezvosvJdzLsrUci0m/s+hUiU4+GhUsbspos/UKKqpfx6HAyNSyQweZSZgbTfx25O47UVRGALIjK222qzOTlUK77EC1Ez5P6qw8hULgLSv+y/xJ6hBRnsP/0/O2GS+3iP9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/7/26 23:08, Matthew Wilcox 写道: > On Wed, Jul 26, 2023 at 11:02:52AM -0400, Liam R. Howlett wrote: >> * Peng Zhang [230726 04:10]: >>> static inline >>> -enum maple_type mas_parent_type(struct ma_state *mas, struct maple_enode *enode) >>> +enum maple_type ma_parent_type(struct maple_tree *mt, struct maple_node *node) >> >> I was trying to keep ma_* prefix to mean the first argument is >> maple_node and mt_* to mean maple_tree. I wasn't entirely successful >> with this and I do see why you want to use ma_, but maybe reverse the >> arguments here? > > I think your first idea is better. Usually we prefer to order the > arguments by "containing thing" to "contained thing". So always use > (struct address_space *, struct folio *), for example. Or (struct > mm_struct *, struct vm_area_struct *). There are disagreements here, so how to decide? But I don't know if the new version still has this helper. >