From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009A1ECAAD4 for ; Wed, 31 Aug 2022 19:15:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D4498D0001; Wed, 31 Aug 2022 15:15:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 783DE6B0073; Wed, 31 Aug 2022 15:15:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64B368D0001; Wed, 31 Aug 2022 15:15:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 56CD16B0072 for ; Wed, 31 Aug 2022 15:15:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 17CD68074D for ; Wed, 31 Aug 2022 19:15:16 +0000 (UTC) X-FDA: 79860841032.29.905BCD7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 0C69B40040 for ; Wed, 31 Aug 2022 19:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661973314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OoTRUGFCRCGqc4N4Lf1mF7m1xbctNWtbqZZ4JOPVOxM=; b=c4a/c4X7Jek8pMTPDaZ4dM9qZY3MVs8sTFfDg+fLJ/ACjnE7xDyBR9QjJut6pee9sdHj9X 6w0+md0vutwvtjDBV/MXj/v7rYnPAzsMakdwbLtw+cMsy6b6JZiy7FMXwstZ3t4V2E815Q PzbsLDcbFMJve8wsGenjYdBhJHhgYT8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-617-ILDzfRytMJGnmdZ1u5F6bg-1; Wed, 31 Aug 2022 15:15:13 -0400 X-MC-Unique: ILDzfRytMJGnmdZ1u5F6bg-1 Received: by mail-wm1-f72.google.com with SMTP id r83-20020a1c4456000000b003a7b679981cso90565wma.6 for ; Wed, 31 Aug 2022 12:15:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=OoTRUGFCRCGqc4N4Lf1mF7m1xbctNWtbqZZ4JOPVOxM=; b=sqkEqHXSKKqcB3Xpe5k+yMWPlvRmcPINVJQLxJaUkaODrCVPuqmuk/k95L9B2jP5R6 q0C/zUEyuIG1SGc9eYKdkVGQXm94IlQxq6QznkTxwbvUfjd/9mivsrtZNkbmyaHJm4NI nxNDGrgMHgNpIZT9TT/jHHmdEz7sTbyJjl9svfcGgmdK99mpHqI+lS4moHwW4i4Xk8Ar 7rcjn/W7sUFBnw/4ikVFrehGtQY9lpOImobscC60McThhUcLmhSRQZQAwMCmrlJ/V2mk 8QOteH5/iBLiB+CGJig8cB/qVRVsnZreb9sF7c4yAGiZVN5xFKOYlRU/6sbPdUW1wU5S bhtQ== X-Gm-Message-State: ACgBeo0KQXrwc7EN9Br7/cDdY5jBHGH6W/uduQv3Eo0gTeJgS85GxwHW nN1UclWZr+BrXlFhs1gwhT/efugJloZet/NMyDIhhHbmueeZy1L4ejk3vlR6Mozv7Mp23jwbkEW PEY4+fvMnkZc= X-Received: by 2002:adf:a490:0:b0:225:2da4:10ff with SMTP id g16-20020adfa490000000b002252da410ffmr12717621wrb.1.1661973312083; Wed, 31 Aug 2022 12:15:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR7F7coh0iOwNSgEwYMu/hdq6HxvtLsOaJG5qGdBp234CJFc36CibInsWfni2LUDq0VSb8dTcA== X-Received: by 2002:adf:a490:0:b0:225:2da4:10ff with SMTP id g16-20020adfa490000000b002252da410ffmr12717610wrb.1.1661973311809; Wed, 31 Aug 2022 12:15:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2900:1613:4308:aca3:2786? (p200300cbc706290016134308aca32786.dip0.t-ipconnect.de. [2003:cb:c706:2900:1613:4308:aca3:2786]) by smtp.gmail.com with ESMTPSA id b11-20020a05600c4e0b00b003a50924f1c0sm3613727wmq.18.2022.08.31.12.15.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 12:15:11 -0700 (PDT) Message-ID: Date: Wed, 31 Aug 2022 21:15:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1] mm/ksm: update stale comment in write_protect_page() To: Yang Shi Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Jason Gunthorpe , John Hubbard , Andrea Arcangeli , Hugh Dickins , Peter Xu , "Kirill A. Shutemov" References: <20220831083024.37138-1-david@redhat.com> <4845ae71-b7dd-1707-ebc3-2eb3521e7fa0@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661973315; a=rsa-sha256; cv=none; b=c3kQovPsZgrJ7zrP2YK8pRm4SBLcEJetnQgWWUxkXwCxqCQ5PG/eIUBeMasAm489Uwktxa LGFFhglSrJNvLjSO0f8mbK3SPQ67dMI+HK1t+67+asa37oJeihBd2jAXUQmkAlQ/7XB4T3 HlCCyClEr9Vf7ZQ4gnghIESHgs8ID2k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="c4a/c4X7"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661973315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OoTRUGFCRCGqc4N4Lf1mF7m1xbctNWtbqZZ4JOPVOxM=; b=yUx7POM4PlOjoQHNkd/PNaT8xYntdwZ+je9f5lg81vLr9P6GQSSvyguqgc8VQ0gw3q+3jP dHwWHGSz63yf1ByQN1IoED4zcEf8xxgHu20zEnq2bbOD2rlrrvCGUU52jUvohPk9Ht0Dd4 5Nnqwd1S8oIXHzHU2YiTfGcXAqU6bxE= X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="c4a/c4X7"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam07 X-Stat-Signature: tfwfb1bqu53qxk5s85mjkhuwob5ajkee X-Rspamd-Queue-Id: 0C69B40040 X-HE-Tag: 1661973314-933974 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.08.22 21:08, Yang Shi wrote: > On Wed, Aug 31, 2022 at 11:29 AM David Hildenbrand wrote: >> >> On 31.08.22 19:55, Yang Shi wrote: >>> On Wed, Aug 31, 2022 at 1:30 AM David Hildenbrand wrote: >>>> >>>> The comment is stale, because a TLB flush is no longer sufficient and >>>> required to synchronize against concurrent GUP-fast. This used to be true >>>> in the past, whereby a TLB flush would have implied an IPI on architectures >>>> that support GUP-fast, resulting in GUP-fast that disables local interrupts >>>> from completing before completing the flush. >>> >>> Hmm... it seems there might be problem for THP collapse IIUC. THP >>> collapse clears and flushes pmd before doing anything on pte and >>> relies on interrupt disable of fast GUP to serialize against fast GUP. >>> But if TLB flush is no longer sufficient, then we may run into the >>> below race IIUC: >>> >>> CPU A CPU B >>> THP collapse fast GUP >>> >>> gup_pmd_range() <-- see valid pmd >>> >>> gup_pte_range() <-- work on pte >>> clear pmd and flush TLB >>> __collapse_huge_page_isolate() >>> isolate page <-- before GUP bump refcount >>> >>> pin the page >>> __collapse_huge_page_copy() >>> copy data to huge page >>> clear pte (don't flush TLB) >>> Install huge pmd for huge page >>> >>> return the obsolete page >> >> Hm, the is_refcount_suitable() check runs while the PTE hasn't been >> cleared yet. And we don't check if the PMD changed once we're in >> gup_pte_range(). > > Yes > >> >> The comment most certainly should be stale as well -- unless there is >> some kind of an implicit IPI broadcast being done. >> >> 2667f50e8b81 mentions: "The RCU page table free logic coupled with an >> IPI broadcast on THP split (which is a rare event), allows one to >> protect a page table walker by merely disabling the interrupts during >> the walk." >> >> I'm not able to quickly locate that IPI broadcast -- maybe there is one >> being done here (in collapse) as well? > > The TLB flush may call IPI. I'm supposed it is arch dependent, right? > Some do use IPI, some may not. Right, and the whole idea of the RCU GUP-fast was to support architectures that don't do it. x86-64 does it. IIRC, powerpc doesn't do it -- but maybe it does so for PMDs? -- Thanks, David / dhildenb