From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E04C77B7D for ; Thu, 18 May 2023 10:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F3DD900004; Thu, 18 May 2023 06:12:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A38C900003; Thu, 18 May 2023 06:12:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 792D2900004; Thu, 18 May 2023 06:12:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6ABC8900003 for ; Thu, 18 May 2023 06:12:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3DD01807F0 for ; Thu, 18 May 2023 10:12:04 +0000 (UTC) X-FDA: 80802960168.10.66730F1 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 272C5180010 for ; Thu, 18 May 2023 10:12:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684404722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R1ERtOl/K4oPnnmOaPMFZyrjmgR8y9PoLEPnykHTqG8=; b=xsBoa+gII4RzsKfDNBs872nIXpJuJ668wMPsidlWC1ajpVjEbcWKVSFjGGrcSrJdNCZrFL 1nSWb83fhZqIdemVLIV7m19utiwLR/U+xRjOZ8a/N9waI1s/xQ+hVXAhiejjh8ULaMyrHq VuKYSB9T8X8BfBMfIDXQHdY/RDYPD04= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684404722; a=rsa-sha256; cv=none; b=aGSud7obbrEsDIpAGOxE73lIWSWooN9eUeuIJhzh/frA2o4FkqjzJQAFtBYlGeUPUUS7Sg 78VNXeJGPxPxq9LDL9xXJF8j0dXGDel8pKXZtr0QOyUGpRV1Q2v+TxTnZ3g3AJyGE6JLvi xKf0mzMMctR/D05kuLPjpvj6KOWLSaM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D75171FB; Thu, 18 May 2023 03:12:45 -0700 (PDT) Received: from [10.163.70.177] (unknown [10.163.70.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD65A3F793; Thu, 18 May 2023 03:11:58 -0700 (PDT) Message-ID: Date: Thu, 18 May 2023 15:41:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3] memblock: Add flags and nid info in memblock debugfs Content-Language: en-US To: Yuwei Guan , rppt@kernel.org, akpm@linux-foundation.org, tsahu@linux.ibm.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230518091431.299-1-ssawgyw@gmail.com> From: Anshuman Khandual In-Reply-To: <20230518091431.299-1-ssawgyw@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: hn8t7hoh5d9by6mkqb6y198goq54yg7i X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 272C5180010 X-Rspam-User: X-HE-Tag: 1684404721-257362 X-HE-Meta: U2FsdGVkX1+wEaUR/d7ZRUe5i4QN08/7LBpLE3MBbJUW/3P4Wiudj4fOa/blCmYrDURhHSelPIe8Juh/HJ23mwBG1C73+0uHzMBrDk6/8S4YmLfqjU8Cg7hIBeLdqsim6PNU5ET5Us0XthH6237L7w8TX8vkCTaPxtIN2/T7ybfu58pqKunMRkfrCzi1KKF2Q4NLqK1La32SuSo4DdKh3l7kALvM4FiZAYxdJSHoENoztX/jVwChJ8TI2S0letFU/mythai87KrLhl7SGj0ADM/9fz/zLVAh4JKuw1Omkq95qtge8THMXk6yJ/fqugKJUgG6LtSkC2CpQyepGBSLaCjArmH8EF+QNvrqYxvvMjg5af8qoxmZbJLteBnMr4ocdLCtBS3yNDygIeOyph87MMqIE8MFg+khEqFGA1GXN12non/CeCZNfJOKEPIj531CSOzN3LsPbjRvDOS4M+7PppU5Ybl5Q6d4ta+vDiT23RcPMBPUdoRI4NeN/rRZDVvxBLkDc2XRek5+HOd5RHnafirrVwMcvvVQtf2GTT/v73V1+m32/W8YOcFecDTCQQLas+ayIEK3HlmMs2lK20y0QHbcbUJl0JcaR0w4LbNF/XZrVU8/3sg/n+xnpAOri4uIdHPymirDLi96L6BV/B/ytz++6okcoXaukAn1gqCaJEbb6+WQmd2qMO5PAhWQuzU/yYeIlP8ulRq4VAVZNwP+LvZN2MP8uLxu2mY/Od+ZvpP2BOZwQs+SydgvJWZDGXCWeoZLVjZ8PpbZng2u5+H4WKnjlPEUbMF9l+mgIe3GdCRQmNxfNSj3hW5AevEjPUgkbxCXrotW8g8WUqkidH25cSRyz3C9qT3ikDpD/f+WVUV4fmgGc5xAZzZrlBF+JMleXB3M6op1ESDfLAS3WkZ61UhPHDfika/bdWFF6K9lc5d47wHIEyEzjTDLjEJGr7nwDFE7d+p74wjuGqIzXnB A9cdEiZP fwxGq10ZjhrxeQph/FFpaUsZadN5JDdUvFchcRkX1Kv3A3+PqgTrmVdsqF0/goUgOB1F5BkAeG5GOqsw0sg4U/XfTB7O4Utt7W8SmP1WvNVAZ5JQqc5ymcOWkOXFzvo8U/mjV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/18/23 14:44, Yuwei Guan wrote: > Currently, the memblock debugfs can display the count of memblock_type and > the base and end of the reg. However, when memblock_mark_*() or > memblock_set_node() is executed on some range, the information in the > existing debugfs cannot make it clear why the address is not consecutive. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff > 1: 0x0000000090200000..0x00000000905fffff > 2: 0x0000000090600000..0x0000000092ffffff > 3: 0x0000000093000000..0x00000000973fffff > 4: 0x0000000097400000..0x00000000b71fffff > 5: 0x00000000c0000000..0x00000000dfffffff > 6: 0x00000000e2500000..0x00000000f87fffff > 7: 0x00000000f8800000..0x00000000fa7fffff > 8: 0x00000000fa800000..0x00000000fd3effff > 9: 0x00000000fd3f0000..0x00000000fd3fefff > 10: 0x00000000fd3ff000..0x00000000fd7fffff > 11: 0x00000000fd800000..0x00000000fd901fff > 12: 0x00000000fd902000..0x00000000fd909fff > 13: 0x00000000fd90a000..0x00000000fd90bfff > 14: 0x00000000fd90c000..0x00000000ffffffff > 15: 0x0000000880000000..0x0000000affffffff > > So we can add flags and nid to this debugfs. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff NONE 0 > 1: 0x0000000090200000..0x00000000905fffff NOMAP 0 > 2: 0x0000000090600000..0x0000000092ffffff NONE 0 > 3: 0x0000000093000000..0x00000000973fffff NOMAP 0 > 4: 0x0000000097400000..0x00000000b71fffff NONE 0 > 5: 0x00000000c0000000..0x00000000dfffffff NONE 0 > 6: 0x00000000e2500000..0x00000000f87fffff NONE 0 > 7: 0x00000000f8800000..0x00000000fa7fffff NOMAP 0 > 8: 0x00000000fa800000..0x00000000fd3effff NONE 0 > 9: 0x00000000fd3f0000..0x00000000fd3fefff NOMAP 0 > 10: 0x00000000fd3ff000..0x00000000fd7fffff NONE 0 > 11: 0x00000000fd800000..0x00000000fd901fff NOMAP 0 > 12: 0x00000000fd902000..0x00000000fd909fff NONE 0 > 13: 0x00000000fd90a000..0x00000000fd90bfff NOMAP 0 > 14: 0x00000000fd90c000..0x00000000ffffffff NONE 0 > 15: 0x0000000880000000..0x0000000affffffff NONE 0 Although, Mike had suggested to keep these flags print last, above format looks good as well. > > Signed-off-by: Yuwei Guan > --- > v3: > - show string value for each memblock flag > --- > mm/memblock.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 511d4783dcf1..5fba53f98b2d 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2143,13 +2143,23 @@ static int memblock_debug_show(struct seq_file *m, void *private) > struct memblock_region *reg; > int i; > phys_addr_t end; > + static const char flagname[BITS_PER_LONG][8] = { > + [0 ... (BITS_PER_LONG-1)] = "?", Minor nit - Although checkpatch does not complain, should there be spaces between the operator and operands e.g (BITS_PER_LONG - 1). > + > + [ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG", > + [ilog2(MEMBLOCK_MIRROR)] = "MIRROR", > + [ilog2(MEMBLOCK_NOMAP)] = "NOMAP", > + [ilog2(MEMBLOCK_DRIVER_MANAGED)] = "DRV_MNG", > + }; Also, BITS_PER_LONG sized array is really required here ? as there are just four available memblock flags. > > for (i = 0; i < type->cnt; i++) { > reg = &type->regions[i]; > end = reg->base + reg->size - 1; > > seq_printf(m, "%4d: ", i); > - seq_printf(m, "%pa..%pa\n", ®->base, &end); > + seq_printf(m, "%pa..%pa ", ®->base, &end); > + seq_printf(m, "%8s ", reg->flags ? flagname[ilog2(reg->flags)] : "NONE"); > + seq_printf(m, "%4d\n", memblock_get_region_node(reg)); > } > return 0; > }