From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EB55CCF9EB for ; Mon, 27 Oct 2025 17:00:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE2A480079; Mon, 27 Oct 2025 13:00:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B93598000A; Mon, 27 Oct 2025 13:00:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A826880079; Mon, 27 Oct 2025 13:00:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 93CC28000A for ; Mon, 27 Oct 2025 13:00:06 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4E7641401DE for ; Mon, 27 Oct 2025 17:00:06 +0000 (UTC) X-FDA: 84044506812.17.0FF4B9C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id A9B12100016 for ; Mon, 27 Oct 2025 17:00:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VB+2++4U; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761584404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VPdePOfud/gTRbDwaWlddH91CzCWm669JLEOi7t0B7k=; b=Cn5tSHZQsGRXTCwLCzkUC6K5u5gAOAX5U5CGKGQ2qlebPdwFyhRg+h3ZbTrVX400G6kE4w OOPoULc/vrRaVvF2jEWYJMNJQ2Qe22IT+OidM0wCMcaRvkXi58sUdFzNPK7u4VLQohTz9c aypo4g6YpiEq9wvyQ1KAID+Ef8OBi64= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VB+2++4U; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761584404; a=rsa-sha256; cv=none; b=pLCj1VL2XVpoAQEuPA0Xn5vdXpyGXRj1IRRUz4G4a9ktJbOj1G/it/MIS6eGIKAt8sVrpA k6lVsHsqa4mrx9lDMEn+/H2rZdasZDNTWUSd6jAoDUyPCy6Jc+A1Hwa6UoZ2jFcP8jdm6Q gbwm0mYLzha2Tm+HysV1jbbM79ntslE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761584403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VPdePOfud/gTRbDwaWlddH91CzCWm669JLEOi7t0B7k=; b=VB+2++4UDFb5pIO5k4MKCw6+GSLKo5rul4aoIa6EihVxI5hdspebWIEtZmJ3kCyV/zFsj/ exsNz9lOPxSKlG/lQJJiyw7BG4uqqEiduU9vRaTx3Yzg3eqnHjCbAw2E52rNfAi++b+xx4 3nZTFT4GKzxZJymMgMFrn2ZEb23JT0A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-UhYdlalvOjy09d9TWfSCFQ-1; Mon, 27 Oct 2025 13:00:01 -0400 X-MC-Unique: UhYdlalvOjy09d9TWfSCFQ-1 X-Mimecast-MFC-AGG-ID: UhYdlalvOjy09d9TWfSCFQ_1761584400 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4710d174c31so48600295e9.0 for ; Mon, 27 Oct 2025 10:00:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761584400; x=1762189200; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VPdePOfud/gTRbDwaWlddH91CzCWm669JLEOi7t0B7k=; b=sfAkv+/GnRe0nBaouL6MgLp2uc+eneuqCdXFtDlE6W+pGjacF5HtvhOs5ZQn7aNMw/ MAJt75Ij9lBSdhp5Q0MCOrufarIsz1KEQP5Bn76izrek84JkuBSGwj1s3R50nZOTPPPb wTAlfoUPdV/wevchPJczpGFZyWLQd2XHJjuXt4VC0BGLIwU2su0U4ISHx/Hj7a2uNmeq bA/utGL/H5VKOgTAX/CrRdX2d2K9oWo/M53bzzfxAWn5Zd1DfheG9lXOceXsqvWrvf8S HIhQ0WQvWYH+B5QnhMPLbHV8tvZ+6SmJaXkHKgNVXHGL8O6dUTqiEO5N/RAIaC2809mn Dn+A== X-Forwarded-Encrypted: i=1; AJvYcCVovhozaozKpJyH707NcSKJEeZ2olJx3/+s4wCTp1V9E6YKGAikfAuFVsymUOKh+F/EFYnNtQf0gw==@kvack.org X-Gm-Message-State: AOJu0Yy4HvrttOj4n3pKiWltGw/9KAFzRo4uiyidEBEQ8GCdIMPIC6Wq msrQlDBLWxnrcZt83I1nIuoEjTZYi+NjMbge6Fx8a9YHIbZP0d2NLGk7Jcu7GxmdMI83TQEp2Gy H6xlmvEbHlVF8Yq6pTF1e6onoeqrGEZvZ5mc7cZiR3LUzXqiTRsAo X-Gm-Gg: ASbGncuF/HgUCM5JldBmIJPEy4MQDpdxx1u5zOtPDRlcQRnIh0YcRPtSdeQpTb3AD1a ncdZBukb9AKpP7c6y+BMXBVJ3ZJQNOQut8jdwgrRYl/Z4O56bDfFHDi7y2PPCwWLeId9L/BhlHA ZemFt/ENADXt4QfLAHeln79ryeTRdiS7rJi9Kplzk/uHKJsw0lK7z5uO4QWccVz4eDIQEBOcPfN Tf/Dsz7WL5Fo0XJ4sZ5QEB9P0sqG6WbbHXj0STOniuwkB9OTVvYoEBdzBPPDt227Lb/yTB7KcYq Z4wyH6O50dIZk0G67gyO3/tAI9xVx0Rmwov03wgZ7qnU8nYK+/qNUWOFT36MBnf5+NAHoayv71p +mGH6FxXCAUiR/UzqVFIzY2Goj8WVZwBzbr0T/VjVA3ZP1yVXUaTcBYjVBR9HNrSk9TNbaudGht Bz3VOY5jeea8UQn2Ct6UAjNMX4NwM= X-Received: by 2002:a05:600c:6215:b0:471:16b1:b824 with SMTP id 5b1f17b1804b1-47717e3f3b5mr3497465e9.28.1761584400487; Mon, 27 Oct 2025 10:00:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1punvjQGH5qjORoP9iHJACPCMWv2X1DQYdUT6Rf/tzl5ujUWNGjF8uD9GnRgJxgCJIA9BGg== X-Received: by 2002:a05:600c:6215:b0:471:16b1:b824 with SMTP id 5b1f17b1804b1-47717e3f3b5mr3497205e9.28.1761584400037; Mon, 27 Oct 2025 10:00:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3f:4b00:ee13:8c22:5cc5:d169? (p200300d82f3f4b00ee138c225cc5d169.dip0.t-ipconnect.de. [2003:d8:2f3f:4b00:ee13:8c22:5cc5:d169]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd489e6dsm144533855e9.6.2025.10.27.09.59.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 09:59:59 -0700 (PDT) Message-ID: Date: Mon, 27 Oct 2025 17:59:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: KVM/s390x regression To: Claudio Imbrenda Cc: Christian Borntraeger , Balbir Singh , Liam.Howlett@oracle.com, airlied@gmail.com, akpm@linux-foundation.org, apopple@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, byungchul@sk.com, dakr@kernel.org, dev.jain@arm.com, dri-devel@lists.freedesktop.org, francois.dugast@intel.com, gourry@gourry.net, joshua.hahnjy@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, lyude@redhat.com, matthew.brost@intel.com, mpenttil@redhat.com, npache@redhat.com, osalvador@suse.de, rakie.kim@sk.com, rcampbell@nvidia.com, ryan.roberts@arm.com, simona@ffwll.ch, ying.huang@linux.alibaba.com, ziy@nvidia.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-next@vger.kernel.org References: <20251001065707.920170-4-balbirs@nvidia.com> <20251017144924.10034-1-borntraeger@linux.ibm.com> <9beff9d6-47c7-4a65-b320-43efd1e12687@redhat.com> <8c778cd0-5608-4852-9840-4d98828d7b33@redhat.com> <74272098-cfb7-424b-a55e-55e94f04524e@linux.ibm.com> <84349344-b127-41f6-99f1-10f907c2bd07@redhat.com> <748cdc18-e32d-41bd-90d1-a102b1c51e06@redhat.com> <20251027174726.5d8fcce7@p-imbrenda> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251027174726.5d8fcce7@p-imbrenda> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Jb302-mUxAf0XeABJ7OUxBPaddg8tK3JkneRRTqQ5tc_1761584400 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A9B12100016 X-Stat-Signature: nnoh4apdtowfs9axrsqpmaa7k9m3jktw X-Rspam-User: X-HE-Tag: 1761584403-310522 X-HE-Meta: U2FsdGVkX1+ZOHkPi1JFQCWKWmu3MQOAaXWVeFsUHBnDdtCAT6TSz8hB9I3sAKVLK8+7uj5BUmCJxgVAcNtCg4sF9s5d/06DOJ93XMS8podSrPVHVTHEm76Pf9TUuCQ0cR8EzKj8rHfAHHvDGElQclw1OL1V0lYytupboLt56MpqbnQCjvEyB1U8CX5xUzHgOTs2KFskqxixWMPxyYaGRcnOLmKvt8rcZ50zvmPUhuywjEltYIv0u47iq5V6bQmvnjsTlZIfB4p3qpBuu5RShxCzblF8Dp4n81fHqnq6cSTeMuMbSgZeAehG0+EvKhI1lrlsi6VnhjOgM1RJQhtbfjCFx//W4ZRu1SQoI32Hg9o+4uUBC1ilRRwxmb7F7NUI3eAnd7/UPQwQPR3R8Zu/C7l/twKVSR9iYe8qfg2XRMrwS7Bcan5ApKYhV0wwaDE/jWVbFj0+G4YVyplGLMsDC7NiFqwAr/gwKwy72eHIMyBfXEt0+OgehL67Ntk9Ssqpda9Kp7BYkvVCM3pxsng7WLPmQFK1dEgIvnh23JtejiJh3g2+ic0Zc50D3OSAKJTPJMoIYAkF3zuzK3MelAewwDfk78S+mi2yehJQ1sfUhH9PFS1fBiII9STNxzDttE5CFoLmDSnSRbMRGXdp38ZHNzh/NtARnRmwQE67LzPYuYaEOUPX9j0HPZ29hcGeUDIq4Z0bQ2aLyILQzSITK0jBVzIkhRITaF0w1V03GSXQBnPeWk9VVtYScNc6or12CvjzLbLbWQ4c92kCA6G30o6GfOxDC+XskbjZGa5GpdU9InxXHzn1QlhG5JHjn8+1tDUYlUC1lnXn5rCmqDTWLqmxeQWw+34OBMvA5XTWr0XXwaROdxeJQHewIOkToGHZWFaIxUNgvrY1aJpIAYjNk+TduA6f8jRbPQXozbbxs18vqOvh4zCzX/1UchHVzfUXg6vzP3xz4ZjGXFx1LRMeowA Q7xUPXw0 A2dmSGSWXgKJkFgEwtPQDRpUCiiugB7SYr4g+z5Li2U19EWSOY8BrPxkJxoOLIMsw+od0kt4hkE1hlBE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.10.25 17:47, Claudio Imbrenda wrote: > On Mon, 20 Oct 2025 10:41:28 +0200 > David Hildenbrand wrote: > >> On 20.10.25 09:00, Christian Borntraeger wrote: >>> Am 17.10.25 um 23:56 schrieb Balbir Singh: >>> >>>> In the meanwhile, does this fix/workaround work? >>>> >>>> diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c >>>> index 0c847cdf4fd3..31c1754d5bd4 100644 >>>> --- a/mm/pgtable-generic.c >>>> +++ b/mm/pgtable-generic.c >>>> @@ -290,7 +290,7 @@ pte_t *___pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp) >>>> >>>> if (pmdvalp) >>>> *pmdvalp = pmdval; >>>> - if (unlikely(pmd_none(pmdval) || !pmd_present(pmdval))) >>>> + if (unlikely(pmd_none(pmdval) || is_pmd_non_present_folio_entry(pmdval))) >>>> goto nomap; >>>> if (unlikely(pmd_trans_huge(pmdval))) >>>> goto nomap; >>>> >>> >>> Yes, this seems to work. >> >> Right, but that's not what we will want here. We'll have to adjust s390x >> gmap code (which is getting redesigned either way) to only take the page >> lock. >> >> In the end, we'll want here later a single >> >> if (!pmd_present(pmdval)) >> goto nomap; >> > > this seems to do the trick: > > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c > index 8ff6bba107e8..22c448b32340 100644 > --- a/arch/s390/mm/gmap.c > +++ b/arch/s390/mm/gmap.c > @@ -599,8 +599,9 @@ int __gmap_link(struct gmap *gmap, unsigned long > gaddr, unsigned long vmaddr) | _SEGMENT_ENTRY_GMAP_UC > | _SEGMENT_ENTRY; > } else > - *table = pmd_val(*pmd) & > - _SEGMENT_ENTRY_HARDWARE_BITS; > + *table = (pmd_val(*pmd) & > + _SEGMENT_ENTRY_HARDWARE_BITS) > + | _SEGMENT_ENTRY; Probably worth adding a comment. I remember we don't reuse this bit as a SW bit in gmap code, right? > } > } else if (*table & _SEGMENT_ENTRY_PROTECT && > !(pmd_val(*pmd) & _SEGMENT_ENTRY_PROTECT)) { > > > > it marks non-leaf gmap segment (pmd) entries as present, just as normal > pmds would be. Yeah, I looked into hand-coding the PTL lookup but it just gets nasty real quick. > > I think it's a good enough fix for now, pending the rewrite, which I > hope to get in the next merge window Agreed. -- Cheers David / dhildenb