From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA26BC2D0CD for ; Tue, 20 May 2025 03:16:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E95C6B0083; Mon, 19 May 2025 23:16:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BF1F6B0085; Mon, 19 May 2025 23:16:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D5CF6B0088; Mon, 19 May 2025 23:16:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 325A16B0083 for ; Mon, 19 May 2025 23:16:12 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D0684812E5 for ; Tue, 20 May 2025 03:16:11 +0000 (UTC) X-FDA: 83461822542.06.C29BB05 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf18.hostedemail.com (Postfix) with ESMTP id 16A131C0007 for ; Tue, 20 May 2025 03:16:09 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ll2qeVuw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747710970; a=rsa-sha256; cv=none; b=xOswAPDNLfBBfCHCtRcAYyeEnjxjkGkoP6AbIkLGnuDfHeSsDpcOQlak1QzBIEQ6e1jibN mXBCEQW2HYnFGKKWTPfM6LvP/qekex7+gcZ/J7BChU08ujjcb3c6APR7vxDM/+D5FZsEWg RHVY2FYqgARfdp86EmXIc+XIOoNpREE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ll2qeVuw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747710970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQfMDoQ260BGjCMrcScg0wHQ7wmLuw8S4sagjFqk5vA=; b=KwGISNmBQJuuuyjy7iceCtqrpKtUkOsdIBBP4JSl8rktggDR1gOpdBYAcnhtoQEjUQPK6E Mxso8qbLy4zUrrFX5gTHYRBovZyDHl4GrMJq2WHdNj7d4mcQMIV8mhxlXaKABdi4267sZ3 56L67wYuZ2HFAR9m4UmgfSsx9Xf5oxo= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747710967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQfMDoQ260BGjCMrcScg0wHQ7wmLuw8S4sagjFqk5vA=; b=ll2qeVuwHYlqF06nbJapV7M04PIb5JWw4ezsb3LpeLlHEgtvPM+woEGuhfJ+qNRUi6arka 5OrguEJWF2vBokVj0MAr24gB/mhPhZo/ZnGi1wrPXet3sYHISKXoMZ30IpS/Z4khtvFrEJ Ru/x3IjYboKkfu6GrysovtojXIv9V7s= Date: Tue, 20 May 2025 11:15:55 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 2/4] mm: ksm: refer to special VMAs via VM_SPECIAL in ksm_compatible() To: Lorenzo Stoakes , Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Xu Xin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 4b8m8tdf9arnxgohdqsx1dr47wmycyyx X-Rspam-User: X-Rspamd-Queue-Id: 16A131C0007 X-Rspamd-Server: rspam06 X-HE-Tag: 1747710969-191166 X-HE-Meta: U2FsdGVkX1+pu9Lf43tNy7LhYFdO6Ots+Lk0enZJqVKdIkH206ulMTuPARPNBYNe28tVq1WcSr9pqKGqEypwXGlVNOAHNFBFfj8Kx5oYuKAlsxMqQZDfuOv3SS9TpfDuhQrYjYGcSaJQP3XS57fH08OLPDUG1vdiGaSbi5rQGwL/xDqEusDcZGpXoTRIE2TqP3yHXfVMueFdCpzTzfSzdWhgJhnuo5kS3cx0hlQjG4Fp54LeO3qsiWsHyulTZbk1QRnq0UNPy9puQ5G3bGVjD2BLIWwYu9AcNY3UJy6onG+tpKGwdpriq17TOX9IARXHc2wL4Cqdt7kp3+ISdzf/uk3Avy1XgsKhXiJX3XI9ejSkfRiwKgELt2B8FqNFysT8FKbdvAQXwS3QJQwY+CYdh09vg5DwM8MGciWLhb3laH4HpszcCN4P2dwKc6l/WTUG29aZTJAJ0ROHA3+vNP+8Amd7kxkwdFb73pSL1k4NVuDp7VsuK8ChN9kLTyEbLbIJE+itU2sJ16ODJNDRBuxOmlzDYFLpfaoj6OZItFeRuLkMWlFsMjtZIw3mOfLXBOCNolQwY6dvLJjboUxIY3yu08EcGUWzLXJzBJJ2WJ3Q/E4QKeNOYtNgV2vuVHejJj5AXtdkTyINVz6GYYtnMiedpkYOCVwTrEmI+lnr8zHCE9JEsMuo6XxkRVd6kZ98eI9H5DtFCOBBXBlpoaytiYg3WulemOr2jjfOgGChFxVl7DWxsdCLBOfbMMGsao+sDTiyRKLa1IvsH9nOyiRRluei7ypkEZ/RGdVbhUPilJO8HgNmnZMxXxxdN0SJ1c/SNIa96ht7u8ipyjfbwfg3Tw1qCs9zyB58LFh0+YIPoPUYqHliz6EbTb+HQl9U31W8J41ifrikmUWy7QODYwgUdLqg5e+30vNFjC7DRxYnZO1CA8X6BQxZKkC2KPvqQAPJULhExaayiXR1Exn0w/coUw5 G8yXUzTg yUc1bcc7a0LYI43jnC8467GzwjCl6IzoG3xEw9XTFfaPEBHIqmi8uGgm+e+dEKz8pvPZIPjCtFHcfaLE9m0hrtzeMzPzbDx28iZeywXuGnzmOnsWcdZ8roqHFS66UrpWvmk2ZaeeVQl/jQE6jqfFexsWJciMMQv7CFsbNNQyj5FEebkFvj5udaviid6WL9b1HleMGsqlVi+eTkyB5P3J8cL0/A6tdyYifsk/6lnZCJ8liLGAOZAka1qjI6mGsNztp0ANhMMOckE0fMzaVnOXR8MyK6vfkP7f3Dt9A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/19 16:51, Lorenzo Stoakes wrote: > There's no need to spell out all the special cases, also doing it this way > makes it absolutely clear that we preclude unmergeable VMAs in general, and > puts the other excluded flags in stark and clear contrast. > > Signed-off-by: Lorenzo Stoakes Nice. Reviewed-by: Chengming Zhou Thanks! > --- > mm/ksm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 08d486f188ff..d0c763abd499 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -679,9 +679,8 @@ static int break_ksm(struct vm_area_struct *vma, unsigned long addr, bool lock_v > > static bool ksm_compatible(const struct file *file, vm_flags_t vm_flags) > { > - if (vm_flags & (VM_SHARED | VM_MAYSHARE | VM_PFNMAP | > - VM_IO | VM_DONTEXPAND | VM_HUGETLB | > - VM_MIXEDMAP | VM_DROPPABLE)) > + if (vm_flags & (VM_SHARED | VM_MAYSHARE | VM_SPECIAL | > + VM_HUGETLB | VM_DROPPABLE)) > return false; /* just ignore the advice */ > > if (file_is_dax(file))