From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBFBC25B74 for ; Tue, 21 May 2024 12:52:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C73A86B009C; Tue, 21 May 2024 08:52:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C24426B009D; Tue, 21 May 2024 08:52:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEC7E6B009E; Tue, 21 May 2024 08:52:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 91EF46B009C for ; Tue, 21 May 2024 08:52:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 55DCA1A0F9C for ; Tue, 21 May 2024 12:52:30 +0000 (UTC) X-FDA: 82142391660.04.A170F83 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 90E59120020 for ; Tue, 21 May 2024 12:52:27 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716295948; a=rsa-sha256; cv=none; b=dQaMD0dX0krpeV++7FPDtHg5FGRFgRDGR9fzNzF45ujdvQHa/RZAkIExas+4OCjS+C+1U7 JEDgmjhsM1bbcai6HsG9O1fTB9ujdKK/U5veEVzjhsbsEylRMRrylgqQvjBAJgUxeZlOLm ZHLctjwwVOfARdClMaI4Usw/GpL4evY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716295948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X3qR+ayeMIWLfJK1ndiVMzONCDsB5JPpbhekNrttsd8=; b=ucRPPhlw60Mus7YySom7MOi/ZWxRsGRVFUiQpWIEPgR0Y99gMWuQzNBT8rF9AswzDt0Yen XJvQRWnrVjEiIArU7ZUmbH7DSReu7TOotiGqLeaDc6Z5YvHranNzJUb2+I+vgPqpH+MR0/ JHLTQ0dL17exIjfSy48Hqfu6ktiA+Fk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4878EDA7; Tue, 21 May 2024 05:52:50 -0700 (PDT) Received: from [10.162.42.16] (e116581.arm.com [10.162.42.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE2EC3F641; Tue, 21 May 2024 05:52:23 -0700 (PDT) Message-ID: Date: Tue, 21 May 2024 18:22:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: va_high_addr_switch: Do not skip test and give warning message post FEAT_LPA2 To: Andrew Morton Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com, kirill.shutemov@linux.intel.com, AneeshKumar.KizhakeVeetil@arm.com References: <20240516035633.143793-1-dev.jain@arm.com> <20240519164823.8e21acfd2bf9ad13f7798f1a@linux-foundation.org> Content-Language: en-US From: Dev Jain In-Reply-To: <20240519164823.8e21acfd2bf9ad13f7798f1a@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 90E59120020 X-Stat-Signature: d7pmot9bh7gekp4kx6t5qij7n6byxmrk X-HE-Tag: 1716295947-333977 X-HE-Meta: U2FsdGVkX1+uQLXf2F/Hpa76/37UM51GRW/XgHx020HUpEMruQhEC99sv7cBl6ppvxg3uXGpoIcJExZ7SlueBNcFiwB9azWIxs5ws4fR3RK8ljKVe1bQuNACibcshVIfrJCSpVcQDC01NOAP/LeUM+uI19qMyQs5RBRSWxWT6sB/+qX4Ch/GNy3XfbN2vnwV1kawSyWjOr+RhOSleadilH+pDRVliVY3mhxJfxafaxJFLWg0z0i8I1uweJiiqMTs+9WGrP/+ShTz/uLQlO10qQkbI6V55g5QOjiSMCGDMjkEuILTL7FYuMJNvrreqNqCp/lKHsCU80rLVEYB/5H2uJSa58d3/XxBtiaIJgJ6mcY5X4p+YFacg2Mvhi6V8pu98YWwdk+lDX09yZnYLZASFToQ3zyupwlXEv0i5nHQBTjKHloQZTHrFdKKTesoNMK4OQarxogjnoMUpItXDT8JeQpkLt2auoXLdSYoLz0sbM/3pdozursEn4Z7lvmg7zFqj9pP4VgSEbPJB5aQwNkAOF4ACKQeOA2Rocq5BJ2k+uxrgfTtXA9pqb/J5Q8w43GWQTzMR0DOlajg7SfWGwPky0DzVCAzU4FhRDm930uSemrmu4u75fFo8hfxHP8eElRvVsxkC/G31l4JmBJG7iMdyyxDiSZQP9/p5Cnp+1S/eMCylThOSlhAiTiPOT+pAl3tx6ocNIKvvs56Nj/DQU9/9oD1o8nQNYTHXuO0RNswmKCHn7tehyF6ztouapKJJ3fqmPCoPTeczSs5zo3PozefhO/liVei5CxvIOtyyLBSr402hibUOcyygg+4+FuT7zYkoTRKgx0INzIuo5UvRUiJGM1VuHNJzagmaQsNTRqFWMIRD5JlhjgK14pGTvD5m5tXaAXm9h2NLJqRCWb2ijFUqfstwTMVb7QDAfOStaL+odsA/zbMDnOuwDsYGbui/n1bDEK3NRWWo9A6M5uWZOg KY31JAIi S3g4TCNVI+x+FzctEgFmU5XtpJOx6L3EO1yarqHUuvq4noMizF7lzGyRNm1U/wRqv1Hbv5oqgp8+yK4RFv88pRPCo/Z9B0weFbMy1vp65KxvmGEgRsD9QwaLuiTiJbCEldFneMd1es2ZsNQU9eyyj/7YJ/ZNZ/J5eUttGgRQXCdV7t1oTEU1iTMstxCeqPNXVJu4tjw20u12dSoFZ/G7kQlOum0VKGk1Xnemb6zT+R6N0jTyw0apr/4Q/qw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/20/24 05:18, Andrew Morton wrote: > On Thu, 16 May 2024 09:26:33 +0530 Dev Jain wrote: > >> Post FEAT_LPA2, Aarch64 extends the 4KB and 16KB translation granule to >> large virtual addresses. Currently, the test is being skipped for said >> granule sizes, because the page sizes have been statically defined; to >> work around that would mean breaking the nice array of structs used for >> adding testcases. > Which array is that? testcases[]? If so, we could keep if fairly nice > by doing the array population at runtime. Something like: > > static struct testcase *testcases; > > static void init_thing() > { > struct testcase t[] = { > ... > }; > > testcases = malloc(sizeof(t)); > memcpy(testcases, t, sizeof(t)); > } Great idea! This should work. I shall implement it.