From: Matthew Wilcox <willy@infradead.org>
To: Kiryl Shutsemau <kirill@shutemov.name>
Cc: Chris J Arges <carges@cloudflare.com>,
akpm@linux-foundation.org, william.kucharski@oracle.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: [PATCH RFC 1/1] mm/filemap: handle large folio split race in page cache lookups
Date: Fri, 6 Mar 2026 18:41:08 +0000 [thread overview]
Message-ID: <aasfxLYRWzNodAYO@casper.infradead.org> (raw)
In-Reply-To: <aasddOvIfcMYp3sk@thinkstation>
On Fri, Mar 06, 2026 at 06:36:30PM +0000, Kiryl Shutsemau wrote:
> The proposed change doesn't fix anything, but hides the problem.
> It would be better to downgrade the VM_BUG_ON_FOLIO() to a warning +
> retry.
The trouble is that a retry only happens to work in ... whatever scenario
this is. If there's a persistent corruption of the radix tree, a retry
might be an infinite loop which isn't terribly helpful.
next prev parent reply other threads:[~2026-03-06 18:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 18:34 [PATCH RFC 0/1] fix for large folio split race in page cache Chris J Arges
2026-03-05 18:34 ` [PATCH RFC 1/1] mm/filemap: handle large folio split race in page cache lookups Chris J Arges
2026-03-05 19:24 ` Matthew Wilcox
2026-03-06 14:13 ` Kiryl Shutsemau
2026-03-06 16:28 ` Matthew Wilcox
2026-03-06 18:36 ` Kiryl Shutsemau
2026-03-06 18:41 ` Matthew Wilcox [this message]
2026-03-06 20:20 ` Kiryl Shutsemau
2026-03-06 20:11 ` Chris Arges
2026-03-06 20:21 ` Kiryl Shutsemau
2026-03-06 20:58 ` Chris Arges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aasfxLYRWzNodAYO@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=carges@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox