From: Breno Leitao <leitao@debian.org>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>,
Lance Yang <lance.yang@linux.dev>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com
Subject: Re: [PATCH v2 3/3] mm: huge_memory: refactor enabled_store() with change_enabled()
Date: Fri, 6 Mar 2026 07:56:48 -0800 [thread overview]
Message-ID: <aar479k_ElLUtU8x@gmail.com> (raw)
In-Reply-To: <ce99b331-809e-48dd-ae8e-19eb6a44b5b4@lucifer.local>
On Fri, Mar 06, 2026 at 11:39:28AM +0000, Lorenzo Stoakes (Oracle) wrote:
> On Thu, Mar 05, 2026 at 06:04:55AM -0800, Breno Leitao wrote:
> > + mode = sysfs_match_string(enabled_mode_strings, buf);
> > + if (mode < 0 || mode == ENABLED_INHERIT)
> > + return -EINVAL;
>
> The mode == ENABLED_INHERIT check is weird, it reads like 'oh a user CAN specify
> this, but if they do we error out', but in reality
> /sys/kernel/mm/transparent_hugepage/enabled explicitly outputs only always,
> inherit, maddvise.
>
> So, even though it's duplicative, I think it's probably saner to have:
Agree. That would be a better approach.
> With that fixed, feel free to add:
>
> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
Ack, thanks for the review,
--breno
next prev parent reply other threads:[~2026-03-06 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 14:04 [PATCH v2 0/3] mm: thp: reduce unnecessary start_stop_khugepaged() calls Breno Leitao
2026-03-05 14:04 ` [PATCH v2 1/3] mm: khugepaged: export set_recommended_min_free_kbytes() Breno Leitao
2026-03-06 11:20 ` Lorenzo Stoakes (Oracle)
2026-03-06 11:33 ` Lorenzo Stoakes (Oracle)
2026-03-05 14:04 ` [PATCH v2 2/3] mm: huge_memory: refactor anon_enabled_store() with change_anon_orders() Breno Leitao
2026-03-06 6:07 ` Baolin Wang
2026-03-06 10:30 ` Breno Leitao
2026-03-06 11:22 ` Lorenzo Stoakes (Oracle)
2026-03-06 11:32 ` Lorenzo Stoakes (Oracle)
2026-03-06 16:43 ` Breno Leitao
2026-03-05 14:04 ` [PATCH v2 3/3] mm: huge_memory: refactor enabled_store() with change_enabled() Breno Leitao
2026-03-06 11:39 ` Lorenzo Stoakes (Oracle)
2026-03-06 15:56 ` Breno Leitao [this message]
2026-03-06 6:14 ` [PATCH v2 0/3] mm: thp: reduce unnecessary start_stop_khugepaged() calls Baolin Wang
2026-03-06 10:26 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aar479k_ElLUtU8x@gmail.com \
--to=leitao@debian.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=usamaarif642@gmail.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox