From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A5DE7717F for ; Tue, 10 Dec 2024 11:36:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 666BC6B018B; Tue, 10 Dec 2024 06:36:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 616776B018D; Tue, 10 Dec 2024 06:36:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46B2E6B018E; Tue, 10 Dec 2024 06:36:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 25FDD6B018B for ; Tue, 10 Dec 2024 06:36:22 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CE9D01207F8 for ; Tue, 10 Dec 2024 11:36:21 +0000 (UTC) X-FDA: 82878845700.05.3050893 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id 4545C1C0003 for ; Tue, 10 Dec 2024 11:35:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="M/epqt+d"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=suW9qEgz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="M/epqt+d"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=suW9qEgz; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733830569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hFu9401+IvDJjs4N9L/SvxLlufhJYXIIH4OTS622MBQ=; b=uieWZVbl1YokGeRMlrL5Ah+5hpnCHD8vuPbb5YyVh9BZY0h8r940qyoN5QzuGMrfxqIsDf f+WI2KMWL8vC7WuAGyG6/4tmrFuJL3TlpygW6k6tKUYPusR/4TNiyIzLvzdN1Q7icIsq5h SGLxAd9JrecHft0sKFjFfVBNRKSOrXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733830569; a=rsa-sha256; cv=none; b=7WdkNNIQKg7L98NNqM1eVd/MKDPdrsTmwFEZDiD/mc3W/zyYs/GqTB0U/fCXmDFCLWS7DW BKsaHrBoGtxrWDVZ0wwfRgZA/nxMWme+8rOuuVqBS+RTnsNqtM4+7GpLAnM561nedSuNFc VjDnnRZGYA0LoeRVJauNsXI11ifrcFM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="M/epqt+d"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=suW9qEgz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="M/epqt+d"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=suW9qEgz; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 84D4321101; Tue, 10 Dec 2024 11:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733830577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hFu9401+IvDJjs4N9L/SvxLlufhJYXIIH4OTS622MBQ=; b=M/epqt+dfeGjPzB0kjhchXA/rgIcDlm+z1p4Iq+Fh4g62RPA43g+phiU5J5o+/prVpAdyn pYMHSq+FfUMaqVYcvy4AspujnVtcA+67rBWseeNgg3GyXYImwx/d2VatGllitq76FUsq3w xss+ALm4mK+R5MYE1l6Nhz5qNrUJmlg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733830577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hFu9401+IvDJjs4N9L/SvxLlufhJYXIIH4OTS622MBQ=; b=suW9qEgzyNbQuM0/Pi8zQwjWnnwV/VbFHNoRJSZVub1W3HKHzgD49aNog9wcFx/1FBp6r7 F45/wn+yiJPqprCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733830577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hFu9401+IvDJjs4N9L/SvxLlufhJYXIIH4OTS622MBQ=; b=M/epqt+dfeGjPzB0kjhchXA/rgIcDlm+z1p4Iq+Fh4g62RPA43g+phiU5J5o+/prVpAdyn pYMHSq+FfUMaqVYcvy4AspujnVtcA+67rBWseeNgg3GyXYImwx/d2VatGllitq76FUsq3w xss+ALm4mK+R5MYE1l6Nhz5qNrUJmlg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733830577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hFu9401+IvDJjs4N9L/SvxLlufhJYXIIH4OTS622MBQ=; b=suW9qEgzyNbQuM0/Pi8zQwjWnnwV/VbFHNoRJSZVub1W3HKHzgD49aNog9wcFx/1FBp6r7 F45/wn+yiJPqprCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4A1A4138D2; Tue, 10 Dec 2024 11:36:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oBrHEbEnWGexWwAAD6G6ig (envelope-from ); Tue, 10 Dec 2024 11:36:17 +0000 Message-ID: Date: Tue, 10 Dec 2024 12:36:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/6] mm: mark vma as detached until it's added into vma tree Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241206225204.4008261-1-surenb@google.com> <20241206225204.4008261-4-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241206225204.4008261-4-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: q1juycji93xxifu9f3539hfhi1tdum3p X-Rspamd-Queue-Id: 4545C1C0003 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733830556-243579 X-HE-Meta: U2FsdGVkX191qYZKpRe7crl6hLNU31veyaOz7XdkZqOtINrH9uq6AsNduvX7osg7dETVQpdUhQtA7MQcf0wM273+d5Sf7D2jsazPgKU1Sx54tm14pA9jiE2n3771S+x6BoYW7eKJv84+UEbZ0zVO34EFgBtlW9N7SiD6G5MLjdlnE/h5a7zwZOhF/crt8/4txKYY4Cz9spqKqAckmDPfDNkzhAx/E/6xwS4WBhxo7LH1CJoeECVNMX5qDAgjwHWHHQjuI0I2k/AzNnVlntmIpdEDItpblX1rIc82ofhYxlyqoekMwR1Hljpux/3p8xuDobw1SsuBvNfv+hWwJdiUuwnBVgebjfFDn9Dpbg1/Vz53SJMm/wBY2Of6rCxE6gu8TVz71+5C0pnC7eV7+/Zok7H4s9/SFiN0lP2YDs7DN74CCuc78s+mYxgI7EqU2yb2pMQ5mBHJ16qF8BQCL+io/DBt1WJURyU1o7EzrdkujI2ZSCbpCXv+E6OIU/kehJT8rlJGPw0CCQUmqxUGgYNpdqVvdqjIKovy6d/WY/DBPe303GJc0nQRQCoRNX5MYgImbaRi3p4FT3dCutRnD+7y9bzNV35KK5jbQ+kEb6G5K0AKdgI3+pvO3+oXN9u22o9CDuPuc7HBQtWwaH/unejaSVp+dAnm4Z9fSYGXw5niQqLcLdIA/xfU3AwjdHH7cj3plm9la3hjtL1+wU40BW2DbpLWshW6SJa35w+xll5B9ouOO+vVkgo+7byMCBtNIzDfQVf7wLsMgn6hIxEX0pGlBbo2L6OutaEkvEWrXELlGLlIVXy/0E46uRcLfnWEMSZu8RKNzZTJx8w7FjQhwnCbyBdkKD1HYTcDEZFzfg66tWS52JY43u7OCz3LZCGhdHfdRhAqbYkjb4tOv7O07IJ66NofGPMrLo3o2uI04Jm5VY7uyimOY2PXdfuDIvyEBuczXN1Og2C+zTY4rOwF3ep /GA4rw7L 120uLoK9ZdW8BYoghjKNz5qG7iQbGyqwmC5Ie0juZFVSMgQa3Nsc9SvCosSiW76xCyfvIGhw8jKKaFTg8JgHb+Z41QyoRbPB5i7U6Bf/eMREpOetaWExOlEjfBhnWAnwR4SJobn9nD8qbPBr8f746eVpMwUj4M7QlNIb9aMYMCrS+qkBZVOxaWAVZ5ZLxh1B4H5q29cS5oO9i0jEZ7CrMeFQvXgBRFSI+nbeWtAsHzi+KLnAZSbEksNyCKPLtztb065YSb/WjOyo3zhNcI+cfOptnAxlA5y9pIGi8bk9KAKmdQJHwJzxrm8JY/nycyiRXmG55b10b20Yn4B87p93rcccjtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/6/24 23:52, Suren Baghdasaryan wrote: > Current implementation does not set detached flag when a VMA is first > allocated. This does not represent the real state of the VMA, which is > detached until it is added into mm's VMA tree. Fix this by marking new > VMAs as detached and resetting detached flag only after VMA is added > into a tree. > Introduce vma_mark_attached() to make the API more readable and to > simplify possible future cleanup when vma->vm_mm might be used to > indicate detached vma and vma_mark_attached() will need an additional > mm parameter. > > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Shakeel Butt > Reviewed-by: Lorenzo Stoakes > diff --git a/kernel/fork.c b/kernel/fork.c > index 21660a9ad97a..71990f46aa4e 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -465,6 +465,10 @@ struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) > data_race(memcpy(new, orig, sizeof(*new))); > vma_lock_init(new); > INIT_LIST_HEAD(&new->anon_vma_chain); > +#ifdef CONFIG_PER_VMA_LOCK > + /* vma is not locked, can't use vma_mark_detached() */ > + new->detached = true; > +#endif It occured me we could probably move the detached setting to vma_lock_init() to avoid the #ifdef (also in the ctor in next patch)? > vma_numab_state_init(new); > dup_anon_vma_name(orig, new); >