From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7659C4345F for ; Mon, 22 Apr 2024 09:33:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 589346B00B2; Mon, 22 Apr 2024 05:33:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 510F96B00B5; Mon, 22 Apr 2024 05:33:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33C7F6B00B7; Mon, 22 Apr 2024 05:33:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 142596B00B5 for ; Mon, 22 Apr 2024 05:33:35 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8B5DF1A0B09 for ; Mon, 22 Apr 2024 09:33:34 +0000 (UTC) X-FDA: 82036655148.01.C552FB9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 45178C000E for ; Mon, 22 Apr 2024 09:33:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SeFdC5Pa; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713778411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jNmMcHHqbadB2TewlY1lynwQ7lt5HmD0hnZgW77LkSk=; b=a5vhzFjxWerFmZ70z9XTN1s3/PsFW/VDrip3/yGQpzL0xB7369Eftaq87NL7oFZl5btydI KaqeRMeO8R9aEMJe6oJbG73ORucLOfATzyNUoVeZTr2y9hyT0ajotLOTj2Or5JActcTgJf pCl1yeEn2EEiA4pokGeetarQJi5ucCk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713778411; a=rsa-sha256; cv=none; b=CUubIZWeITfjVc3z7lPE4/XlAzPLGNrAtA/DN6hqvgzMpfzpD12l/A9AGs1/vR/4WSY620 WEFzVZHaUknta2g3wbCxo0IlkUMTg2i2NB/IuMYLOay8NUC6dN1q2hL/gJk/7H3XjdVA+b XRxddWjUW3gcDxrz/ayrfSNxMjUpGoo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SeFdC5Pa; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713778410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jNmMcHHqbadB2TewlY1lynwQ7lt5HmD0hnZgW77LkSk=; b=SeFdC5PaxXQJyEw9V+E6NcwZ4/thqhWZJqKPxESFENgQ6xLDM2aGYpMGJwhXocfbVCl/SS ueHu0pz+2ImBpkykT3ybnYfmdvZKDVlhhSa4a2SoJNqgn41/3rZZtFNiEDUCrezp+V58Xg 3yummkCK1ZrQN9qho0m/HDD2EKAUzbM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-fifhipGdPFeB2sSH1byNuQ-1; Mon, 22 Apr 2024 05:33:28 -0400 X-MC-Unique: fifhipGdPFeB2sSH1byNuQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-343ee356227so2732045f8f.2 for ; Mon, 22 Apr 2024 02:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713778407; x=1714383207; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jNmMcHHqbadB2TewlY1lynwQ7lt5HmD0hnZgW77LkSk=; b=kiVqfuaVA2o5GsweA7kLWJ2D6klP5es93GyIy+e4lIApeYiaTr9z9nyUINASKUE8NL PCq0QGWTsLmNhQ6IfhiRY43GpOeiDMu8sfJIw/Q7lN8y1smlVub3y/Fmn6xQlORACikA juzAzBkYRB/yTQu5SKg9JS/JBhVW1C5XWNSVx9jG0KrTh/4t07UhPhZ77XFD1WynIotY x+xKF/p2qo0PP6hbcfTh8eX3POa+pc6FaHpfLTrPKzEevQ3x0F9c3Y87JFMmBaaCapM3 uHPgg+0ATPIr62F/neRek8fO4pHJUc9fJTMG/2hKrE+Wv+W89F/3hlQC9AQzcO0wruKA Ayow== X-Forwarded-Encrypted: i=1; AJvYcCXy0XM1HLRoXLggOIHm/cbWH8EOdZSJWfTprHvFYiPzU/R7KzlQaJaeRAAPVVtgJVVtmiVrbK4hnU0T7qomBpsJhfo= X-Gm-Message-State: AOJu0YwtX4cUgl6ovDbeHVfjKq8cCJJgnV6/9Zh2ot3SfOdHK2CIUqFV vFSIgSghJNa3XM+A1eQdezvnkN2py8C4nDABEY28/mYZNJfvYCScRTuuSZZGC0XQQhX8OZzwEQJ iPy2Z9PXrBg8f8yqT8oW8W5i/9kSPnre5b3M/SUcb2hpKziSg X-Received: by 2002:a5d:5711:0:b0:346:ba70:f262 with SMTP id a17-20020a5d5711000000b00346ba70f262mr7194358wrv.14.1713778406973; Mon, 22 Apr 2024 02:33:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpBaSn2r2iCAtFJvANxs0XOzMaoUuzni6bSdgwnUdZGECebZkgc6ReIKdKSkkb6wmF47nUbA== X-Received: by 2002:a5d:5711:0:b0:346:ba70:f262 with SMTP id a17-20020a5d5711000000b00346ba70f262mr7194331wrv.14.1713778406473; Mon, 22 Apr 2024 02:33:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:600:d2fb:3a8a:9944:7910? (p200300cbc7390600d2fb3a8a99447910.dip0.t-ipconnect.de. [2003:cb:c739:600:d2fb:3a8a:9944:7910]) by smtp.gmail.com with ESMTPSA id g4-20020adff3c4000000b00343c1cd5aedsm11508618wrp.52.2024.04.22.02.33.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 02:33:26 -0700 (PDT) Message-ID: Date: Mon, 22 Apr 2024 11:33:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 5/5] selftests/mm: soft-dirty should fail if a testcase fails To: Ryan Roberts , Catalin Marinas , Will Deacon , Andrew Morton , Shuah Khan , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , Shivansh Vij Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20240419074344.2643212-1-ryan.roberts@arm.com> <20240419074344.2643212-6-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240419074344.2643212-6-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 45178C000E X-Stat-Signature: nnc7ux3fdzxomniqig7g5eq75fqjbct5 X-Rspam-User: X-HE-Tag: 1713778411-223700 X-HE-Meta: U2FsdGVkX19e8QU8puE+rJpNbcGz2wRybpC2iiR3+n+lQM7Ez1SbZ3nV9K/73b6B3XPKQvlpEyCLMNN3pfV0JcjXnpQUI6Ez8Ot2t+HZGq8Qdm9ZduB8RJjB8IYdSnTZsQ+FKVBLH+Wf3xQj2qveY1X04ucYYDGNFoRe/z30hy54/JGDtEtJdL9X7PM+oyw+zl7x/YsLiNnkkkkgVjDGnClGNU8z8Q0BHUyq1hn6ap1XzectgCL93dyg13XvEz8VWMJ1d5571vFFBHw6PkAl958dq9eJn/XUHbrvKg82RJvwiimvnxVjlPi6AJe1/p/dkvpF3InZbTmOP6sZcWTG3gexoA4fBHxX3DVFlrTne7I9ktMd7ysE3Er0jNsbjHtu3loQ+jsmF72Xr3Wvt70mainF/zP1FfviNR1onCmIC43caws0vm9jNLyNkxo0id8i0Jq4GHCeqn/KIVUuCm5Y46crLD968DWLnWbrRwBNLK1qIx5QNM7SfkrSDnb17WMq4FsQ8+PMxolgR7AcIM8ElF8XRNQfF+IwqclS76A3QHdqDAs0W1tNzGQscRjEqSoEVFcNRlocwaGMbgRrJYb0O5Ud8AruFMcayeBEgsv5hcpvKMq73Pd3KKx4YIn72ayIk7g64Ed/rVv7flJM2nviH34yDzTA6/1EHmKroIaNX4+J02GItD7by/qsbQZafcf7D6rTG0AghND6ti4kWF0sZEFnkp29beNwx1R3XTj2jwr+JjUpcLZwRwDwXZxGE4mq8pU49DjIgvT8ot4M3S6MKIqLdpxNKhB66L5uAVZFECdn5kxQQLHZeyT+yBG80ItZ+4R1k8eD08JnP8eBqDOzV/MywbropET00e3I7wQuqqXakFUS+ogc8AB8P8mnNyvF+pJMFrjxU1s3YxoAOqaUKVLhr89RO2XRIAwa/9PVN6baZKeXtbVX+kcigHp6XJ25t11vSJRMj8hDnbd1f5e A9fpOYdl 0vaLgP6NBa/j2N0/kNsoX/Txoc6sJjU36jcrMtzfiFBz4DsXCRzr41J3FrSAFpoSXOYMfu8EGIjoEahrU2VCV1EhlwoSee9FJK/IymwdNu8/qP8c/+bLEXcbYqvmPLEwLC1L5RMu+6cLzihp10/mSdF9DRul7SuPw9rQ88KPIgq2nUgIuKidaB7m7HkYReMIPGD2HeNhPmd9R1FQaNh8utysA4kuXKccDM7fNwYd9xYzgMLYXvzXvz3fDWLEfmmgm++3ObaX9NqdCLZyi1gMxRBV2fOfdfpXNrHhWqkfIG5nPtVBFfQdkJxKolklP9UUVFkmB8KSvxtJUzTYOhPeX1omgEyFx+yTPnSNsLNl07esY+4ClSA24s2s0cYTAqCYyuvDUsjQDIl3YDrXAMX5dwizCdcw0jG3U95y3Y93CkiwPsItMyyaMhmgtm/Mxclpjd8EQfCP2KjMIM4zk0UDepyTCMwII0lzuLm0CkURjjjjRZJUQP0LqdH1f15a2kXvBCojg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.04.24 09:43, Ryan Roberts wrote: > Previously soft-dirty was unconditionally exiting with success, even if > one of it's testcases failed. Let's fix that so that failure can be > reported to automated systems properly. > > Signed-off-by: Ryan Roberts > --- > tools/testing/selftests/mm/soft-dirty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c > index 7dbfa53d93a0..bdfa5d085f00 100644 > --- a/tools/testing/selftests/mm/soft-dirty.c > +++ b/tools/testing/selftests/mm/soft-dirty.c > @@ -209,5 +209,5 @@ int main(int argc, char **argv) > > close(pagemap_fd); > > - return ksft_exit_pass(); > + ksft_finished(); > } > -- > 2.25.1 > Guess that makes sense independent of all the other stuff? Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb