* [PATCH] slab: Update stale comment for sheaf_capacity.
@ 2026-02-28 20:15 Kuniyuki Iwashima
2026-03-04 1:55 ` Harry Yoo
0 siblings, 1 reply; 2+ messages in thread
From: Kuniyuki Iwashima @ 2026-02-28 20:15 UTC (permalink / raw)
To: Vlastimil Babka, Andrew Morton
Cc: Christoph Lameter, David Rientjes, Roman Gushchin, Harry Yoo,
Kuniyuki Iwashima, Kuniyuki Iwashima, linux-mm, linux-kernel
The comment for sheaf_capacity says it does not enforce NUMA
placement, but it's not true since commit 4ec1a08d2031 ("slab:
allow NUMA restricted allocations to use percpu sheaves").
Let's update the comment.
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
---
include/linux/slab.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/slab.h b/include/linux/slab.h
index 15a60b501b95..7477109eb315 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -359,9 +359,8 @@ struct kmem_cache_args {
* may replace it with an empty sheaf, unless it's over capacity. In
* that case a sheaf is bulk freed to slab pages.
*
- * The sheaves do not enforce NUMA placement of objects, so allocations
- * via kmem_cache_alloc_node() with a node specified other than
- * NUMA_NO_NODE will bypass them.
+ * The sheaves try to enforce NUMA placement of objects, but the
+ * allocation may fall back to the normal operation.
*
* Bulk allocation and free operations also try to use the cpu sheaves
* and barn, but fallback to using slab pages directly.
--
2.53.0.473.g4a7958ca14-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] slab: Update stale comment for sheaf_capacity.
2026-02-28 20:15 [PATCH] slab: Update stale comment for sheaf_capacity Kuniyuki Iwashima
@ 2026-03-04 1:55 ` Harry Yoo
0 siblings, 0 replies; 2+ messages in thread
From: Harry Yoo @ 2026-03-04 1:55 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: Vlastimil Babka, Andrew Morton, Christoph Lameter,
David Rientjes, Roman Gushchin, Kuniyuki Iwashima, linux-mm,
linux-kernel
On Sat, Feb 28, 2026 at 08:15:07PM +0000, Kuniyuki Iwashima wrote:
> The comment for sheaf_capacity says it does not enforce NUMA
> placement, but it's not true since commit 4ec1a08d2031 ("slab:
> allow NUMA restricted allocations to use percpu sheaves").
>
> Let's update the comment.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
> ---
Acked-by: Harry Yoo <harry.yoo@oracle.com>
--
Cheers,
Harry / Hyeonggon
> include/linux/slab.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index 15a60b501b95..7477109eb315 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -359,9 +359,8 @@ struct kmem_cache_args {
> * may replace it with an empty sheaf, unless it's over capacity. In
> * that case a sheaf is bulk freed to slab pages.
> *
> - * The sheaves do not enforce NUMA placement of objects, so allocations
> - * via kmem_cache_alloc_node() with a node specified other than
> - * NUMA_NO_NODE will bypass them.
> + * The sheaves try to enforce NUMA placement of objects, but the
> + * allocation may fall back to the normal operation.
> *
> * Bulk allocation and free operations also try to use the cpu sheaves
> * and barn, but fallback to using slab pages directly.
> --
> 2.53.0.473.g4a7958ca14-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-04 1:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-28 20:15 [PATCH] slab: Update stale comment for sheaf_capacity Kuniyuki Iwashima
2026-03-04 1:55 ` Harry Yoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox