From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09DE9C54746 for ; Wed, 28 Aug 2024 01:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9265D6B0082; Tue, 27 Aug 2024 21:27:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AF686B0083; Tue, 27 Aug 2024 21:27:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7503B6B0085; Tue, 27 Aug 2024 21:27:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 544206B0082 for ; Tue, 27 Aug 2024 21:27:52 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D382C141AE1 for ; Wed, 28 Aug 2024 01:27:51 +0000 (UTC) X-FDA: 82499917542.15.9A6F74C Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf20.hostedemail.com (Postfix) with ESMTP id EBBD11C0018 for ; Wed, 28 Aug 2024 01:27:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724808426; a=rsa-sha256; cv=none; b=4hAeSNklmomq8+HK7uLn1YIBepiujJfS1YoJPg7EarFyHp3wNYpfY8W6/Wek6xAHTtqPG3 xE7RwgKjvV07nEjNmjY3JtM6eWJ8q9F3W+XHjTrPir4h7gpt0LQdeig4tEMUbyWfFoHVki IAzn+hrfDh10YG/AOK3qXylKbF4KP68= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724808426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KFlksZSSJLYrhCvoJBDLzqihDsAjmzuK8pLM8T4/TDs=; b=RnD2VLdzjLpjeRLH+6X2p7AQURo2D4Ivwkc0YXFLfBq63OkfUt5M8/tQJR43btU3cM1uzY iuzhI/5EiTeHIlYs+LsPuaaiaGcuN/duujKt34UEDAoSd7IaEl+0OdtSmpO87J7AMZekq/ /Tr6A1APiERBe+r+IaUOD3i8jlJVLV8= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4WtmxJ11Lkz1S93f; Wed, 28 Aug 2024 09:27:32 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id 8B1CD1401F1; Wed, 28 Aug 2024 09:27:43 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 09:27:43 +0800 Message-ID: Date: Wed, 28 Aug 2024 09:27:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next] mm: make use of the helper macro LIST_HEAD() Content-Language: en-US To: Uladzislau Rezki CC: , , References: <20240827015724.620110-1-lihongbo22@huawei.com> From: Hongbo Li In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500022.china.huawei.com (7.185.36.66) X-Stat-Signature: n9bcgccwffdug7ab8gb3hsaqo3k8mksk X-Rspamd-Queue-Id: EBBD11C0018 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724808467-866631 X-HE-Meta: U2FsdGVkX181BiP236cdXg1H9keJXDrqp8bz/4fGTyEvqeaHfoT/mvtUKJ6p9nn1S0z6Gl1Nq23qSZcms70ilCZpECM5ynf3pWO1jleiXRdbf/CP1QFFgA1L8vy8nJtCdrOEvt8cRobXMtv4e8cZPkdWhH4M5a++27hC765u3qRSR6lnSOiiFwswraFadHBl6ycYjPqWVrtXDCrrgH5osfG6zdaXeoHnmy3Ol5Rwgbci62ENRVZ6Nj1+6K09bM9D0sDXm1ofIq0KwjJAaMqGHwwuRYJAmpwhR81+aP37OwdbwMAEFOJqd41EtbCjz3SfGIlXsw5eOe5rY/hpiZSRJ0Wj/6UAeGkBF7Bja3HUvACbpJOy5Xhf4ctBcJu5209oLBo2cXj6H74WfTchK8JelMo0No1pfnk6okw8ea4tN4bsx9gYBzhdzXG/wGiUllfYjGparEeY1Du+LI3/fmd8SSxn6iEUXTfSgp6d07nxEHuKnmII6hptTtB3M60hxJbHdEiqIUIFmiFHbxzfg/L2PxfWmEmacHIwmSFlNAnA5VBKA2xF7yBG+nNv/QU8Fq1Tzu2TfINr2Bii6OSBgbxr4gMnH+E96WRX1GzxZFnP+HWXVBw5nLkNf+9sq/u2FZDvifuTFVH903S1Q0bbfQEDcgJbRI3V+VGExE2jLsGWcDuvfN2P0mg+03RhsqxhSBUxX7kj6+71ElY46sTSMCY+2dxlG3HbKVRLQ1ZBKTy8OWwePjp6qe9lGKHrvwwKjVvaoB5e+SfOGWVUhP3Wim8h9DAGzvAWhLK+CdZL9Mw2I3lQXDDWkO+SJxhcPd5hnAeF8fWYKFW+xfyrn5GQEoXGeZBptMnebSdSUl4pcZ0NaY4yG6MZ621tNWejQ/nRIVGUwjKiGvuAymyNRx7bJTRlk27uH98CW2MQhx59zwz3t302fYzR8nrlcnbOCl0GqvqJ7ym/OorKHbEWSkh951b 3mabcrHo 7C3bcpimzKEeQnjcmjOs3CbKLKmlKKfiGRAXW0jDexZRIZgPiaPKYST7Qswj85k+EBcinfOwBAmLLefIyllFHzhgzeVxwqL0mhoBCMwgEQ4/VCPi00FZLyHP+5SDJApoBACwzMsHnE4AxSp28D0fAqEN5Tsa6IANH0P4c21W5Mpjchks3E7qrAca9ZTgK9kx5Ez9vVqVmP1WsXV6Xtq1IptljxD3HJrvNRHGG0+R7UR13Qpj6qDjyIxE/J+PBhpECascjEwp+6ipf758= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/28 3:22, Uladzislau Rezki wrote: > On Tue, Aug 27, 2024 at 09:57:24AM +0800, Hongbo Li wrote: >> list_head can be initialized automatically with LIST_HEAD() >> instead of calling INIT_LIST_HEAD(). Here we can simplify >> the code. >> >> Signed-off-by: Hongbo Li >> --- >> mm/vmalloc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index 3f9b6bd707d2..3f7b38481fcc 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -2141,13 +2141,11 @@ decay_va_pool_node(struct vmap_node *vn, bool full_decay) >> INIT_LIST_HEAD(&decay_list); >> >> for (i = 0; i < MAX_VA_SIZE_PAGES; i++) { >> - struct list_head tmp_list; >> + LIST_HEAD(tmp_list); >> >> if (list_empty(&vn->pool[i].head)) >> continue; >> >> - INIT_LIST_HEAD(&tmp_list); >> - >> /* Detach the pool, so no-one can access it. */ >> spin_lock(&vn->pool_lock); >> list_replace_init(&vn->pool[i].head, &tmp_list); >> -- >> 2.34.1 >> > Maybe extend it to: > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 57862865e808..e9c6f29a46ad 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2131,23 +2131,18 @@ reclaim_list_global(struct list_head *head) > static void > decay_va_pool_node(struct vmap_node *vn, bool full_decay) > { > + struct rb_root decay_root = RB_ROOT; > + LIST_HEAD(decay_list); yeah, seems reasonable, and thank you! Thanks, Hongbo > struct vmap_area *va, *nva; > - struct list_head decay_list; > - struct rb_root decay_root; > unsigned long n_decay; > int i; > > - decay_root = RB_ROOT; > - INIT_LIST_HEAD(&decay_list); > - > for (i = 0; i < MAX_VA_SIZE_PAGES; i++) { > - struct list_head tmp_list; > + LIST_HEAD(tmp_list); > > if (list_empty(&vn->pool[i].head)) > continue; > > - INIT_LIST_HEAD(&tmp_list); > - > /* Detach the pool, so no-one can access it. */ > spin_lock(&vn->pool_lock); > list_replace_init(&vn->pool[i].head, &tmp_list); > > > ? > > -- > Uladzislau Rezki