From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA08C83F1B for ; Fri, 11 Jul 2025 18:57:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1D1A6B009A; Fri, 11 Jul 2025 14:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF5386B009C; Fri, 11 Jul 2025 14:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE40B6B009D; Fri, 11 Jul 2025 14:57:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AECDE6B009A for ; Fri, 11 Jul 2025 14:57:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD8C81604AD for ; Fri, 11 Jul 2025 18:57:42 +0000 (UTC) X-FDA: 83652892764.07.C670638 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 34F43180004 for ; Fri, 11 Jul 2025 18:57:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="gALLjl2/"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752260260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VbL3LlciXrx5usUof/F7sG/X7kZUjQJ0y4avrgolLvM=; b=v96CVzXzfro6aaw6O9yGOo2x0ioRcfgwNUkTCZ6qsE4SxRQ0C1x/NqMIiWgiiU4Wa6P25e 9+HiqWHubRLCxFzB9Mcqqv5VjB3gVOIor8ZKcWVzVfgMb0KR3ihb0sUeCDmFea12IRKrAg h84naCULATls/k/9WCjncvTAXA6bIh4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752260260; a=rsa-sha256; cv=none; b=q6zTl+1BNda3b5VfST4MQNew/AGLvxLzXNxBhyMdXCfzRrvuWc1tihFuE3eTiakKHTnlfp VByOmJPfWVJ6bfnuuFrSdIzj6zYIJYhAk03ELnVterT0EYsyeRIbXxkk9R8pnNClrgYXF2 SIW2Symk0yZT/fKAchdcG7iLDKaiVE8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="gALLjl2/"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752260259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VbL3LlciXrx5usUof/F7sG/X7kZUjQJ0y4avrgolLvM=; b=gALLjl2/69KpLdydwNZte7ubVKX4YlwqVCF5pnfGIuhp0/Gm0rQKwtkkeFMca7aC8yNq8J TLRhLh9FLJCFfqRW0G+XFg4xUaMJWB6aA7ZnzsT77BIeeQeVL3a3tZusx19PesaXl9/Oio wu/YOZ6Uj5kFf7SviP40KSzz/y4POls= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-pyWGHeoDM5OKuY3QpkpysQ-1; Fri, 11 Jul 2025 14:57:38 -0400 X-MC-Unique: pyWGHeoDM5OKuY3QpkpysQ-1 X-Mimecast-MFC-AGG-ID: pyWGHeoDM5OKuY3QpkpysQ_1752260257 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-455e918d690so4226895e9.1 for ; Fri, 11 Jul 2025 11:57:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752260257; x=1752865057; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VbL3LlciXrx5usUof/F7sG/X7kZUjQJ0y4avrgolLvM=; b=ZIUTfjHc4YGEqiCrPTfaLSS23Ze507liAUuPEth8HqzoGVKQdZCjB2bRT8lu0o8ArA rP3CY7jGNun3rPc6A1ROtc5VSYm22Lj3N0xAbs7HLU38T3nxz1m5hwAroSxCdN43VFNu R3cPvTr1G4hOMdxT3b3M6ltzCmxLaWnz5rkiCwBwyFDMCqkHZHiDyBs37cRXZzFBBK8G PI1+zUiyIdgCwO78sx2+ZZTnOTnqXZZbWlaYmDUijLFuskSKeN2bMhwt0j91fPj1Q/Fq 8WoqVQUvLgZ3VrROInI65VQFw7Qvi0KJDNdvtQUWHjRLzFBnbcv1KEkf5qksT141yx+B 8nvA== X-Forwarded-Encrypted: i=1; AJvYcCVmNYCe1qhkR1jN2ieQkSf0XD+SgYzRToCaVHO99tP2FTK8J4huw9VBvnj7sdRfMzBh/O9uIGwg6w==@kvack.org X-Gm-Message-State: AOJu0YyPzYczI50M15+g9/WjUaj9cH1qciFta+x3ZpujjIJmIDOh44n0 8zM1rhwCOhsym0KkQSccIubyuDWXOZXVlT3oEHqtfrkndXLbrbLfANUGsSy5xuzJLbmtH/uP3DW wasRHyBUpV7PrDQmYrM4KCLHhW+mX66o5eKX+zSGpFT028ucAw2+V X-Gm-Gg: ASbGncuPAYq6jvVjWI8OLyB+vRf28JPeiarja4ewqNZdF018jRoyWNFH/toOigCSPU9 bFgRnSwIvGh3Iw7ISkf97elwd+lLC1GfejtSKedJknkZytATT0RKmrej238/oGBU9yns4Dz7P5H YYM8W76htk0VFznDKsuXG0odNRmFm39gHhhpYYoDOIq/IW2fx6jGvtSyXNSXd0jxKNfpdPLQy6o hBl8DStW5zp7LxPR6uGTMBZoRI+26qMhGobaZ+tvv9gQe+RmhAV1Qx10aMFrRlCwUcH34Dlwkhx +4C72sZ7akseCgajhi2R0p/BIvN08yW3rTR/+JtMOC459D6xa1smHeb+qtSTom1F4pashtCnkvN t1UTfXCHPMFGgoKn2bGKLM3ySNpXlRJv+J9gUopCVPwp/IDhCT5iOIl0OQbqHSXEQeHM= X-Received: by 2002:a05:6000:2c0f:b0:3a5:3993:3427 with SMTP id ffacd0b85a97d-3b5f1e95fb8mr4724534f8f.26.1752260257169; Fri, 11 Jul 2025 11:57:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGwKEUQLbh/zY6545eP9xFg7a7s2kPU1xUA4JG52ouaTweDCumvMrk6zcF1Opz8ywnEmQoVg== X-Received: by 2002:a05:6000:2c0f:b0:3a5:3993:3427 with SMTP id ffacd0b85a97d-3b5f1e95fb8mr4724490f8f.26.1752260256647; Fri, 11 Jul 2025 11:57:36 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0a:2e00:89cb:c7f0:82f2:e43c? (p200300d82f0a2e0089cbc7f082f2e43c.dip0.t-ipconnect.de. [2003:d8:2f0a:2e00:89cb:c7f0:82f2:e43c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e1e8b1sm5171588f8f.82.2025.07.11.11.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 11:57:35 -0700 (PDT) Message-ID: Date: Fri, 11 Jul 2025 20:57:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 01/14] mm/memory: drop highest_memmap_pfn sanity check in vm_normal_page() To: Hugh Dickins Cc: Lance Yang , Oscar Salvador , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , Lance Yang References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-2-david@redhat.com> <5e5e8d79-61b1-465d-ab5a-4fa82d401215@redhat.com> <36dd6b12-f683-48a2-8b9c-c8cd0949dfdc@redhat.com> <0b1cb496-4e50-252e-5bcf-74a89a78a8c0@google.com> <056787ba-eed1-4517-89cd-20c7cc9935dc@redhat.com> <5e439af4-6281-43b2-cbd2-616f5d115fdf@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5e439af4-6281-43b2-cbd2-616f5d115fdf@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OCEJH6OyPsp0py7LHQ7L6seNGmzJqk50UDbJtpQGhN8_1752260257 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: cog9u7ik1b5z3ca8z3hrtnci9brrr11e X-Rspamd-Queue-Id: 34F43180004 X-Rspamd-Server: rspam02 X-HE-Tag: 1752260260-136286 X-HE-Meta: U2FsdGVkX19Fl1QjekZOrVUEc+h5TmlApqMMgouR9Nd0DrXd9hdI2ZK+YKc9UFNwI3cEFr8TXIBzHrjCM1KfCnQeBJeDbpix7xFx9hX5MtisEDiFK2f7vz3eVsiZa/7Wjk+3iuiHNu2oX0xBtDYr/ItHGTXT5kmFZI84KA56ADf6c1SUC9O+jVKzeCglA/p/vXdXRtMD2AgEDxhpy2d9AttzJSIe+EUUZ5Vq/jz7ZY17QvuaHkztEVDlGYISbmgULy/yt2k9N7mqgttTIQXKbCg8cDozmi1DJoFuVlvIKej/BBBDID/PGFrN7InDl1p30l9lvhvEB4u76zZqPQP4rvZqsU5YtGG+ENHDw9Ym5uTZT7eQe7FJW309gitDZfsUIHxFxAlVH4K0YWJ2xpb1eg8pU1tiP8ebT36C9Ctx+SZNaaSAywCcERAKuZmUSp5egmawhzNDZcKyKHAyT9BIxReWlhcrBt36c9bhWIv0VS97UScrwAOB04mY2nvYM067ejzlbNqn0aYGwAaeJnhUr/lQ5ZFJvTE4d/Ki7x7gUSjXikR6yuYPT6Zs2J93d8s0+VwfqPKW8DtE377sMgR06ydFpkAzQuWfnbGeqjVN93x72YU1nPo4I0VLPYnMZekcWVCxRIXOLP71BsntKyagGox7Sb9W1w9Uw5D98jjY6WqRHRwvtyel17geYwzf1377lU5BpFM3YlQn3Fb3evyy0IYKbQSxEkOLC0K2ytp6ozq9xft3sjP2/LWVp8zXPIOdUNAnzkgVDjddKq3bLS8tQygFCdQgUOjyY+ajUlAdNYlWy+UeK/lUbmvBNv09r4+EtXkMDKun0Z5Hn4KKj4XcRCVd5Ty8n9EZxAjP+t10ne6lLteJdxQfkMl+MJig7+KEKfJnJdqArWThfEwlyTkqGy3t/UBUmMmFw750vSUVlnK8b4AHLu/9urmHoguuKf+/4x5Wfn1oQ3uwPQVwGNo K3ybEsC3 pSmD+JI2uFswOIaoRj/aMlzdFvClC8T2DOpQP+xJYYHKWyQ/wJodoh4KvHsTq+teh8LvRcCnGyyeAZ9kuCXoioi03GqlTCRG2+mFUguQzHe9P+ateOzPyddVeL8CVRCshcUSIANNEsBhtwTt8UEAXHJ+jObUaxns7vPV0B/jxyNN+/QL3MLEyPBqpbuTyxRCdgwR3uTsuQRUZ7EtUNiNvHFwKWV9ktKBZy4Fz5IzT3fENYzJ7gI03ISpSNW8em/wEG+QoiJnXZa7lZYR7UXaqu53/zIaoKr/yKsqnrzzcIhuQjrZT+JxMXlNph8rgwPuzYSo7OVcrDhKqy1ZrmHQFCCDs7fKMBbOZj3i2yVRZ1EaBNZaenQboIL9+9hVpugeBbKVuAdh5UyteLvYQQdCcKbKKVHgLlbt+Zg66wLlsKgZIQvEN2301rXwzQc+PzjKspZzMj1pD0NvSHpsE9HerLiyRpB+b2gs6LviM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.07.25 20:49, Hugh Dickins wrote: > On Fri, 11 Jul 2025, David Hildenbrand wrote: >> On 08.07.25 04:52, Hugh Dickins wrote: >>> >>> Of course it's limited in what it can catch (and won't even get called >>> if the present bit was not set - a more complete patch might unify with >>> those various "Bad swap" messages). Of course. But it's still useful for >>> stopping pfn_to_page() veering off the end of the memmap[] (in some >>> configs). >> >> Right, probably in the configs we both don't care that much about nowadays :) > > I thought it was the other way round: it's useful for stopping > pfn_to_page() veering off the end of the memmap[] if it's a memory model > where pfn_to_page() is a simple linear conversion. > > As with SPARSEMEM_VMEMMAP, which I thought was the favourite nowadays. Yes, you're right, I had the !SPARSEMEM model in mind, but obviously, the same applies for the SPARSEMEM_VMEMMAP case as well. Only the SPARSEMEM && !SPARSEMEM_VMEMMAP model is weird. IIRC, it will dereference NULL when given a non-existant PFN. (__nr_to_section returning NULL and pfn_to_section_nr() not beeing happy about that) -- Cheers, David / dhildenb