From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E42DC47085 for ; Tue, 25 May 2021 11:48:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27F6861260 for ; Tue, 25 May 2021 11:48:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27F6861260 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B5BFA6B006C; Tue, 25 May 2021 07:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B31266B006E; Tue, 25 May 2021 07:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D2036B0070; Tue, 25 May 2021 07:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 6D0C36B006C for ; Tue, 25 May 2021 07:48:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 043E4249A for ; Tue, 25 May 2021 11:48:29 +0000 (UTC) X-FDA: 78179580738.15.3FA3563 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP id 262FAA0001DC for ; Tue, 25 May 2021 11:48:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1621943306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8qp1mQQxgGsYBd7JwEAcG9fT9rHfyYbjsgsObBaU2qc=; b=sLyTadvciYNlE2gG/xEWXVtBX92yplamEaVUIwoiyoUXzEyuwzwBXxCUPKfgMNhb+It7XB kBKvVMwLiuQvBS5s/ZG2OwPjMpy3cj9EwpbPBcYjSGE24vm6kALTL3iJDmqSg6HfneQ676 bGwk1ubaTNyFzoMLrAvdJ+WPAeMvBvg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1621943306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8qp1mQQxgGsYBd7JwEAcG9fT9rHfyYbjsgsObBaU2qc=; b=cOCWdUcqBLQXVeewUuKGerxScWtSE7ZD+HoX0Dgmx0afV308UOEyCQme2FTrBS+pnDnYAm jYp8FWgfK+WP18Bg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C3542AF03; Tue, 25 May 2021 11:48:26 +0000 (UTC) Subject: Re: [PATCH 00/14] Clean W=1 build warnings for mm/ To: Mel Gorman , Andrew Morton Cc: Michal Hocko , David Hildenbrand , Dan Streetman , Yang Shi , Linux-MM , LKML References: <20210520084809.8576-1-mgorman@techsingularity.net> From: Vlastimil Babka Message-ID: Date: Tue, 25 May 2021 13:48:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210520084809.8576-1-mgorman@techsingularity.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 262FAA0001DC Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=sLyTadvc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cOCWdUcq; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: pscoke1b5jdoyuypeujuges8bkbht3q7 X-HE-Tag: 1621943303-811212 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/21 10:47 AM, Mel Gorman wrote: > This is a janitorial only. During development of a tool to catch build > warnings early to avoid tripping the Intel lkp-robot, I noticed that mm/ > is not clean for W=1. This is generally harmless but there is no harm in > cleaning it up. It disrupts git blame a little but on relatively obvious > lines that are unlikely to be git blame targets. > > include/asm-generic/early_ioremap.h | 9 +++++++++ > include/linux/mmzone.h | 5 ++++- > include/linux/swap.h | 6 +++++- > mm/internal.h | 3 +-- > mm/mapping_dirty_helpers.c | 2 +- > mm/memcontrol.c | 2 +- > mm/memory_hotplug.c | 6 +++--- > mm/mmap_lock.c | 2 ++ > mm/page_alloc.c | 2 +- > mm/vmalloc.c | 3 +++ > mm/vmscan.c | 2 +- > mm/z3fold.c | 2 ++ > mm/zbud.c | 2 ++ > 13 files changed, 35 insertions(+), 11 deletions(-) Thanks, looks good. patch 3/14 subject looks like it should read just "mm/page_alloc: Make should_fail_alloc_page a static function" Acked-by: Vlastimil Babka