From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA39C433F5 for ; Fri, 3 Dec 2021 19:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F6546B0075; Fri, 3 Dec 2021 14:09:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A4706B0078; Fri, 3 Dec 2021 14:09:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C656B007B; Fri, 3 Dec 2021 14:09:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 3AC476B0075 for ; Fri, 3 Dec 2021 14:09:53 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EE8797F4F3 for ; Fri, 3 Dec 2021 19:09:42 +0000 (UTC) X-FDA: 78877422204.24.66F164B Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf08.hostedemail.com (Postfix) with ESMTP id 69B2930000AC for ; Fri, 3 Dec 2021 19:09:45 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id r138so3950761pgr.13 for ; Fri, 03 Dec 2021 11:09:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1+IcsWlHKhBlBvu1qEIJjd7+fBRe9hWKiFkgC7AgVn8=; b=qMOpALv0YRVU6bM2Nhr6i3G9mvYp/1ZI4ftafuss3wOwGmLNPKdIsoygM0ucM2Fwrm OKq3jlwH0zvltJrZF3VFrCafFxRtrAkmFuf62J5OpkL99rpcKyj+gYvfPpcGr1gApfoU V/nMatv0LE9nrRRq6uQDr9IOj8lySL2OFiWBLRCNI3xUAFwjWUAhyvrsvB+/1FwKnqoc 9wzTwu231a5+XjRsoLm085ZTfI/f4FolwG6YO5SS2RwMJbuKnoQTEq4IFy4cOoBnPO0i 42kgZuNUIWUVbHZCna0R6U4RsXSiaKLnqICn+0SMMnIkoCXzxZcQshZAbSLS6Htjqb23 0GjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1+IcsWlHKhBlBvu1qEIJjd7+fBRe9hWKiFkgC7AgVn8=; b=w7/eXETi+tnRXAD/t2ZjLOc76MT3X7XpJ7EBJ4X78tV/MgoMsFnMvkG0xIPK/snMOF EHsl4+2R2wZFHj+KjvqfOlr1qAia9p+579iwmiw7pf0mP0SNSPSNaMTSE48qbCGuLBEf A5go7rWRjBbFmn9M/XCDM5FWKI1klC44eywPDJh05Y0jWu01OsKujoFQZJoQV+YqWAcc dBwcSJ6sze5NeARdQu2LVyUydsv2wYnTBJM2PjnCO8WETMhJL46uE5yH+4EH6p+fDR/m TCzz7pJMZMrjsPgLSeCIHLyZBaK3SzrIkcd8PxqxjNCfL+Eomq+AFO0FAnk5s/OKNLBX IoHQ== X-Gm-Message-State: AOAM5302AP5yStstsWPixv9owM04F4x+6bpjrZZ4DItDjO2zV4dIaXnL znAJsxMfwAsoE4688JGYnRPPw13hg8VT2w== X-Google-Smtp-Source: ABdhPJyumXfOqHJei3KoVpScj60uiK1Xgi20WATKU+zPu3LuTE5MYtc55FZjI9X6SNIWq95ZWNP8Og== X-Received: by 2002:a63:914c:: with SMTP id l73mr5962074pge.384.1638558581140; Fri, 03 Dec 2021 11:09:41 -0800 (PST) Received: from ?IPv6:2600:380:7445:97b0:c22:6d1:fc86:abf7? ([2600:380:7445:97b0:c22:6d1:fc86:abf7]) by smtp.gmail.com with ESMTPSA id g21sm4031877pfc.95.2021.12.03.11.09.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Dec 2021 11:09:40 -0800 (PST) Subject: Re: [PATCH 1/2] mm: move filemap_range_needs_writeback() into header To: Matthew Wilcox Cc: linux-block@vger.kernel.org, linux-mm@kvack.org References: <20211203153829.298893-1-axboe@kernel.dk> <20211203153829.298893-2-axboe@kernel.dk> <5e92c117-0cdb-9ea6-3f1c-912e683c4e51@kernel.dk> <89810ae4-7c9b-ec8f-5450-ef8dc51ad8a4@kernel.dk> <97e253f7-d945-0c6b-3d8b-dcf597f04f69@kernel.dk> <9cabdcc3-e760-bab5-edfe-ae225e5d4db9@kernel.dk> From: Jens Axboe Message-ID: Date: Fri, 3 Dec 2021 12:09:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: n5swaaeeoqdycwjttdf3qybr6fqnobe7 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=qMOpALv0; spf=pass (imf08.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.177 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 69B2930000AC X-HE-Tag: 1638558585-625825 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/3/21 11:14 AM, Matthew Wilcox wrote: > On Fri, Dec 03, 2021 at 11:01:14AM -0700, Jens Axboe wrote: >> On 12/3/21 10:57 AM, Jens Axboe wrote: >>>> I'm happy with this, if you just move it to pagemap.h >>> >>> OK, I'll try it out. >> >> Wasn't too bad at all, actually just highlighted that I missed removing >> the previous declaration of filemap_range_needs_writeback() in fs.h >> I'll do a full compile and test, but this seems sane. >> >> commit 63c6b3846b77041d239d5b5b5a907b5c82a21c4c >> Author: Jens Axboe >> Date: Thu Oct 28 08:47:05 2021 -0600 >> >> mm: move filemap_range_needs_writeback() into header >> >> No functional changes in this patch, just in preparation for efficiently >> calling this light function from the block O_DIRECT handling. >> >> Signed-off-by: Jens Axboe > > Reviewed-by: Matthew Wilcox (Oracle) Great, thanks for the review Willy! -- Jens Axboe