From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA12C7115B for ; Mon, 23 Jun 2025 08:09:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E0DA6B00A4; Mon, 23 Jun 2025 04:09:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B85C6B00AB; Mon, 23 Jun 2025 04:09:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE8C36B00B2; Mon, 23 Jun 2025 04:09:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D82EA6B00A4 for ; Mon, 23 Jun 2025 04:09:51 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A760F1A01A2 for ; Mon, 23 Jun 2025 08:09:51 +0000 (UTC) X-FDA: 83585941782.17.5572576 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 248A140005 for ; Mon, 23 Jun 2025 08:09:48 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h3PKdooL; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750666189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZoLkNCOIuM5JEq5J9oMA6vdOX/Go0Smb3Cqjl+UXzmI=; b=4U0FiV6n+WRVePbV/7S0gKiH4Rsrwt8grZinT1Sz5+dYDz+EOZNi1jjlimkPN/2tQ32uuV FXTc4BvPAs7TxRdiQexw85IgiJ+BBPv35Z3yTeT2sy75i0AnXWlItj7T44LY1p2QtqHSa/ OH8xH3riwMKmtmR+epuciSiISlvERLY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h3PKdooL; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750666189; a=rsa-sha256; cv=none; b=gcTCQYg4ADid0nk3fJZIO7DAkm9xiN+YuE+b1+hp0aOJALAOm/EmvGfe36O+W3MbUGYESD 1h7gxbjJIeY7OIQj7dC6IVGR1vCaJmrIaVYlrbX/ejZLP1Wp6mdZVprO2UvmVdVR4DHp90 95IPw95PfV280hEYgBc8limBcaaKieA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750666188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZoLkNCOIuM5JEq5J9oMA6vdOX/Go0Smb3Cqjl+UXzmI=; b=h3PKdooLWExd8pAu8E2XspGHjCRzADjkOsxqb7QnXXQ3gT+PEln7ODpJQpjmUPvtThUI3/ DgJRJjImSJ7tm82wsmRUTc+65AUqSOP9kaBdHDXe5ov0yopdhXdIsjIqpKs8xaSUTM3gtS wxKTStPhmKocsYpytxLHifU/788IFRw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-s1aQ9cRTO2-4fBqreeB9zQ-1; Mon, 23 Jun 2025 04:09:46 -0400 X-MC-Unique: s1aQ9cRTO2-4fBqreeB9zQ-1 X-Mimecast-MFC-AGG-ID: s1aQ9cRTO2-4fBqreeB9zQ_1750666185 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a3696a0d3aso1647781f8f.2 for ; Mon, 23 Jun 2025 01:09:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750666185; x=1751270985; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZoLkNCOIuM5JEq5J9oMA6vdOX/Go0Smb3Cqjl+UXzmI=; b=qn2yo/kAwhrOy0RHcGvfr03bfJmWZTqFEhMUO4jYdvtjiQIn3gEhVFfKkkuyt+PQVK KTQkoOJxKQ0do+DlBy9bQg50NRoJ7ThdFLYpSBcIE+Wi1Wgvcxgg+8XGWCbG2ppRlUyn ecKQC4XcHP5X5a0F3IPSXpWb42JKTfk9LhiGh5j8CmFBM4uHwVisP3L0olqIWOifJ2ps mc03qPS4SCL06suuk4bYRuIihY7NuGtLClcK+aIuTJqUxYDyv2030YXgvdO6SNfm9Tgd v+/X9FzSM4yuEGP7w7tJQkXVEx26XsxsKsXgmqhAgPsFi5cIcdpxBdBdvA1bDFEHmtUL TrUQ== X-Forwarded-Encrypted: i=1; AJvYcCUaSIJhDbYOenzbdkybEjmdmSymI6ncmxNBt7gbv5voKAAxM77m38WkCq39ZhBlQsNNmKxsWM2NUA==@kvack.org X-Gm-Message-State: AOJu0YzuEeqibwIVKvsyOsrlyE02HjSmiW4VKkJ7v/LLe6C7N5pYxP/u 6ffT+PkztZWhfNJO7V1dFMsvq5qWEPBdLmKwtMnz9T7domulv2d4EJDDCsbaRMLVpxMakZ8YAY6 pe7uDDVk8UIOGPVkNdl/MwVYSMPj+JdqvAsDvGLUa6q1zvK4htq55 X-Gm-Gg: ASbGncv/v0buX7Jz07Ocbz81+gYgiyrGwMGM5zjqEnNayDnjDU1SS2Ph+h0LYjRItIr ckOdX0OeCCyWFqCIkdCITq38UOvRD1kvrppKUvUWubCQSccYhRuUA+wTA40KJ7VdxpsIMIAz/SX 13RjfXRKZCDrd0QEG2Nrs4BDmz6ceOAvY5Tsj1a9112A9V68FUv/yMQPgSCripZhr5CFR2YXn51 hFBDfN7UDW9qAT0E9Yz72+L3yAGmsv3Isqg6MYY3RNacoNjtA9JuVESCu4AWUyPuUMoqegLpU8+ u1zYUi0eKctC5c6rxJfh2p37RaicGyMK7x9vENY05R2i56HpZargSXiImy6cALCfIqdYlYmY3H/ FnQK0BWhZYSuOLbNuO6gSCLeAnLQ7t3QusAQatcf4LvDdwxHIKg== X-Received: by 2002:a05:6000:4618:b0:3a4:f918:9db9 with SMTP id ffacd0b85a97d-3a6d12d52d0mr8203115f8f.32.1750666185374; Mon, 23 Jun 2025 01:09:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE5NMbzGns4Ud1DK8X95jr6pyg7YsHTa6Knp0H71wmbZQUUlCQ20bRY4JdQU2MDB76jFyjdw== X-Received: by 2002:a05:6000:4618:b0:3a4:f918:9db9 with SMTP id ffacd0b85a97d-3a6d12d52d0mr8203084f8f.32.1750666184934; Mon, 23 Jun 2025 01:09:44 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4536470903asm103919615e9.40.2025.06.23.01.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 01:09:44 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 10:09:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: unexport globally copy_to_kernel_nofault To: Sabyrzhan Tasbolatov , andreyknvl@gmail.com Cc: akpm@linux-foundation.org, arnd@arndb.de, dvyukov@google.com, elver@google.com, glider@google.com, hch@infradead.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com References: <20250622141142.79332-1-snovitoll@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250622141142.79332-1-snovitoll@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1FRKD0fpQBAQbnUjm91SyymxVRBz8wxMZE06yQpkRN4_1750666185 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 248A140005 X-Stat-Signature: xyi9ifonr5469necq9oxwd1jd7ict46c X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750666188-971423 X-HE-Meta: U2FsdGVkX1+bifV1ENup/WMKY+yKoSC/Ry9h/Dn0pnGGd1vzoICvuduGM3MmV6pwVf1xhip5MkiyLrqko+U/sxo0GJfW/K1lwtl3xk3VrY6KXl+wZpCD5sVOnAZrcUyi7hxbxraATeavIZteJpQbqnwK6E0mwaLib41IROfri9moxPjwyktyLbxuzkEkzjxaaC4O9gVdTQFuOLSe8dhTxxwsC/MgGK4zdnjEZqw7rSYEZhwdr6v6jYm/SdeBt5slO872fzU7TrgqsUGXH/75nL9nSrQsDBdkM4WnSRK2EDoATDR2cLBrxHrGLlx3b7d3B/qgZTO2J0FnMfMTVrkX+w8Mq+jM9qbi/4LcJy5rtTzlHre1SLJFwTzsYrS40h4zmhAZPlSGNWaLUlOpidxw/meHjkXuhfel3OcH37J0PuMHOVp0nlUyCIegd0uwmCzM8JB0sILKw9jozjzaUVTorXw3wXWFecxw8x6CqR5IR9UuXxJhkHK8eY+IzX1g5qC9B1qjwuMcKnb+Iwh68jV/jTg2FEHT51TzrbaEovZgJhn9awN1v5eKzmsgpuM+9ooWJBfdo4ckkRHT47NxTlDhAeL5un37nm5I5ZeZ77OWG1IPaqFFdh2IvhStI8XexYx0iDFZ9XMwmCPo9aO2HNGB52a6StJB8ZNZqtW1zYzLSWH546ytNYvobeNr+45oizhWeqowyJ4DtYX8UNX1dkaj+gVLjG+2Z7BL4senAwoPnoSQry8ih8cArBF2GPbSs7Q1oOX8u1e6jqQVUpwnVMvUMGujh0QFfwVu9c+BNrn+nRDsZHnNLuTzhzrLfnNgOGQa0W9cpE2fpuu0x2X+Xj7FUnLr4Wdcgu+CnQDiNrZS65gQ/hgnw5dsApnAI/MCW9pNC0FS9gwVjqUk2a9wyI4+K/GNjDU+3XQLtGlvZFw47+siE9vMQHl4sDz0JKeJDizAu1Nf8FWMNGa1mLnc+eC f+Zd7ITG pz4vRabV0IXf4yz/I1eRec0rPQGGD/vlBk9bJnVEwg13mfvjSploQgu7Dwi5aCVKTArbfoZUrRW1bQHBmOYnxea8Vt070VdD9Yy5ag4ccucFiwffE00T7Z3pDgwRWfEZvJhqqc2VzVrU8KM4A0kxdv5AUzMcZGNrMSeJFpjzSNASOtBcNBKkitsfS+jqnWT1y9DL4XEpfoYn7MADGR1WfiD4z6C1HQnvFpO/8IAce0S01hK29zr4REeqRFhibcZypL1+KJZO/Da10F4GmtVEqufV6AM1EdBF3cZ4GH9kwftHy9OiEU+CbHxnJx4UwoU1yaivheE4D3kbSpzsxFV/tJeTiYyImxfQrzvva/ZDm3RnnyC2yoCh4NDBLdMWUK6zB4umnwQbb+AfD+vLJFpUeMfIHoJp6Em0qYoeluXI80r7+byxOTDPIr2kEEfQyPhwl8F5BtqylzC/28BkjQA9j6Xvfn0EsBrYbZ5uCSPXW2+8Rl+06lPmE70yPlIggKvDU4YJDRCgJafnGKzd5h7S0CVm8UPZESqiSthajBk6fo1qvwDL/GxAKU0Vsfsbx/XBCP772avHUqFBzJ0jmuc89CVKrtll4W0a1r84CBBdEeKVSZY49hlSiCwkeHPjML3mwF/fBjKYmU6XnpfflkPpcERLtFPyFd4oLkUlB/PWveHwk5Ps= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.06.25 16:11, Sabyrzhan Tasbolatov wrote: > `copy_to_kernel_nofault()` is an internal helper which should not be > visible to loadable modules – exporting it would give exploit code a > cheap oracle to probe kernel addresses. Instead, keep the helper > un-exported and compile the kunit case that exercises it only when > `mm/kasan/kasan_test.o` is linked into vmlinux. > > Fixes: ca79a00bb9a8 ("kasan: migrate copy_user_test to kunit") > Suggested-by: Christoph Hellwig > Suggested-by: Marco Elver > Reviewed-by: Andrey Konovalov > Signed-off-by: Sabyrzhan Tasbolatov > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb