From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2777DC7619A for ; Wed, 12 Apr 2023 03:40:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98369900002; Tue, 11 Apr 2023 23:40:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 932D46B0075; Tue, 11 Apr 2023 23:40:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82230900002; Tue, 11 Apr 2023 23:40:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 739546B0074 for ; Tue, 11 Apr 2023 23:40:37 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3907CC0396 for ; Wed, 12 Apr 2023 03:40:37 +0000 (UTC) X-FDA: 80671336914.08.377156F Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf16.hostedemail.com (Postfix) with ESMTP id 4E4A8180027 for ; Wed, 12 Apr 2023 03:40:35 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="C1r+H+/T"; spf=pass (imf16.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681270835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=agvz4oF+06+P1I3Dywr9vXf4P0PNC8SN/2J0BcuAGYw=; b=opI2RZy/BVGtdaX07oh7a1J/XI6vKisyzvcjpnahluHC3Sk0Mh6RtTK+9WDmYyefXdZGJv prziFx18H1zOW/FmVPSRjw7Frs2IypDdTjfQizkjeb+3ZgUcPbwLNyYAFSLE8THhB2X2jw X+/Pm9SrZ7GktbNm7SiP84iqitJ2CeM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="C1r+H+/T"; spf=pass (imf16.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681270835; a=rsa-sha256; cv=none; b=3EwtTu0pMyBOt6iK3wdRFIVpN0B5Vz5g4wjK9va+v/oTNqTJZWy1e7s5Rs9KoczO2mtSpU szx/mCTUvcYmk56nHsnmVgUAb3imgxWpsU1vurWW0+l+NV+hKJ8XNqcfrkDM//+h3AlQl3 mCF6DSR9cvVdaTMMXZGVOBTCaKdIgbQ= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6323e4561e5so1104375b3a.1 for ; Tue, 11 Apr 2023 20:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681270834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=agvz4oF+06+P1I3Dywr9vXf4P0PNC8SN/2J0BcuAGYw=; b=C1r+H+/TJLQD3G3y1Uc2gUP54iJey7FbM8Y3Gm/xyERny5GaNri/LXtyq38HwNrz0b Pa0gWw0rGBdA6G1lP+kNl6JiOaTIAYdLzyTvWCdTryURQ7BJsb6UwTEFBCkJcLlX7MTf xXQPuFiwwqFHuHJJ1+8G767XOQSqX+aY8XXqpG6mJFeE7UCRtNTrPL+nXRGccgOpuQmI PL55yVAJTkKrv37gDRQGu8F9BLogvFc3SMHCzQQYc4TA41L7IqJVAnNtf0DmKgWT60g+ dsuqRJT/vUH+fQFrYIvzOnvVL1Ib6mzzhazM1tvqMWMBrVXCZdTdI6JhnFbyl4kyakAD 46HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681270834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=agvz4oF+06+P1I3Dywr9vXf4P0PNC8SN/2J0BcuAGYw=; b=t6mx2GcBAhosh+fG13u59AQHthPL7Vg9EpXpckBa1yfRcap3ng5p+CUlywYXPm+2zf f4FAYMOxHc0V9MJCh+0IlTJTgJfT6XEEwUAD9h/y5PcjhLdlV04cOqd3G8FIuWUBy42w qduq2et95mqoeSCiiIWrE/BF2VDFrKXqiVILLOWrsbWO2Vs6IwGy3tRx+PIlRDoanQKf exH4PECbvHkqWVFRzu2y8ai80nXLjHriHiHt1t49YqcQ0MooArbM6TJB0VmSGMpXnRIH g39kYR6gPIMAq6MrMZa5Ev5XAiL6yYt1yuJMvv+Utj+DaEK0AecTYLDBTRvlNmsScHS5 cnIg== X-Gm-Message-State: AAQBX9eaa22ca7jUksyC+Pqc3m+4aD6kj8tHc4231Z9E8RtKl3oD8L3v hFCQWHPewLjpVa6hWtUtiVk= X-Google-Smtp-Source: AKy350YGKCIOXJlzRexDQnS68PFftOgkzTAPkuZvjCnCrzkBER0080Q2HRX/lQbnmV1z/rz6ONqgWA== X-Received: by 2002:a62:5f06:0:b0:634:b231:d2ec with SMTP id t6-20020a625f06000000b00634b231d2ecmr13111740pfb.25.1681270833933; Tue, 11 Apr 2023 20:40:33 -0700 (PDT) Received: from [192.168.43.80] (subs03-180-214-233-66.three.co.id. [180.214.233.66]) by smtp.gmail.com with ESMTPSA id t15-20020a62ea0f000000b005a84ef49c63sm10485715pfh.214.2023.04.11.20.40.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 20:40:33 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 10:40:28 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2] mm: Fixed incorrect comment for _kmem_cache_create function To: zhaoxinchao Cc: akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz References: Content-Language: en-US From: Bagas Sanjaya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4E4A8180027 X-Rspam-User: X-Stat-Signature: bfk8hqpx7ytfzmsbqs76x6ntbqfkf9sk X-HE-Tag: 1681270835-70826 X-HE-Meta: U2FsdGVkX19ropZx2v1fZegAI86yhkY0KnSEL1QkfVRdDmSGnN3jP4s9251UMwBbis/YSYncJSa8bpHaapnEXg78M6zOklwKlkL5EwvsxTVrhVSvKt8cJzQZWkOhVUWxEQtz4v0PwisbEhheXEz8pPvj7cI3gB2gerGPlkijfhKgfp8nZ98as/TQhkTlpTUKAX6WlNcreUgopAhfj57rmUW5676x4HLxwJo9/aLclxPJrv/V1JhEjYATJ6ERhSThwiknheDr/M2zrSnCO0EMabzxGZaLtT5gjNcmNAU1m3rtJm2YQpN1L6jOtlc+OtDICcH4T5pOH8TeR1RJ/vGXaeELSf80BFp01eauYmARG+/fgdw8hadFzVKwbkmJplZbIz9/R12moeYeMeqGgmOo4F4srrv9PnyhHiPUx441pBw14pRO2FucHMec8+IJCtgKejv4++nlo55eoZdndrxhbLCwWlaJ0kCUzjstZvH+NNpyZMibWIWDqlrbJyP5ORwWCJ6kjBw2iSfzMNHJDu8I1A+1dBzHgwGHG3uj1TvY/LMxlN3RMk8giwLB/5ajFRKrw86nO2tdKX1K5h50DI3F1+uozBfKGKqP4+GcwOB9Tjpjjo7ohMXW72/P3f4IdFI8OMuDy6FvdBR0J6fBrdQuA/CdJcJoydK3AwPNZCaNhvn7qux8/qXBqdfAoL2EOwlxJChMwQ+77YCgGU1w6hkrxU/ByD+jVgNaTM+ai/M/4CMlxq6gXwWT+vPQzmFoIVaR4B7rvSFzO6DydX1pc0pDTDsW53h/XDb7MLPU1oXiEpktabOUuIIQXo5EPCF2SqAAEI965bcbG3ReUlYt6zdLcHJIJCypLhtdFGx6VG7r9TJioX/vO9jIWvnjSRQlrnqM/KB+kZvsa/5KQ9UF7hfkRmujmZ8koXTaH0/pi1WFA1bTAplhySVtWYTbMDuOqGQZkIeoeTGVJpXzXksVvLH WbbYN6Bz mvq5ckvtPMb8mtqkLrcFdXO1tOsjPILHb2D8Qi+Wl0M0w6/h65z9Y6kSWqTGB34YOoiJ8QW1Ij5BRdIfWuGD0Mf/RwZ6bV0Tp5+Oz1jDCVeVRNFjYpN4uHvUGQyFMQO6sRLWETXgAzZZct6QuxXcEVRSAmBbz6vK+WMqH1GnF9A5bJIsjiYiN+L5d71uMpeSkJoYGrTTyHKigVUkQzXHsCMZ2PFVpK1HlsquqmBJPNzAdDLAdLaWNL1n5L6icL3aK3n00OSF74D7O0bTynRGNYqFHJO5tWZgp3fA9ZfcNkUDTIxn83g9y9/BBGeX56v5XLK9E0VKN5JRRJkJCaZb6xG98sdAbv7wwNAkVLxnoccD7aZj6Lv4UxjW+sp2MjE6T7Em8r8zvMNnK8oyJYScQ860us39IWsUW4YrIHu5MtXnl8z3YUYf1t61IlFGldc0uYTC7rB+tBLe00Tp3Wo8mKs5RwAWBGc6Sm3cOtweZFw/Up95tVJW3Mcgnog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/11/23 16:13, zhaoxinchao wrote: > diff --git a/mm/slab.c b/mm/slab.c > index edbe722fb..399daa4d0 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1893,7 +1893,12 @@ static bool set_on_slab_cache(struct kmem_cache *cachep, > * @cachep: cache management descriptor > * @flags: SLAB flags > * > - * Returns a ptr to the cache on success, NULL on failure. > + * Returns zero on success, nonzero on failure. > + * This function has three return positions. > + * In addition to successfully return 0, the > + * first failed position will return - E2BIG, > + * and the second position will return nonzero > + * value for setup_cpu_cache function failure. > * Cannot be called within an int, but can be interrupted. > * The @ctor is run when new pages are allocated by the cache. > * I don't see any visible changes in my htmldocs build (since the kernel-doc is for inline version of kmem_cache_create()). You will also need to update kernel-doc comment for kmem_cache_create_usercopy() and kmem_cache_create() in mm/slab_common.c. Since the latter function is actually a wrapper on the former, the return value description (Return: field) should be same on both. Thanks. -- An old man doll... just what I always wanted! - Clara