From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A98D5C3ABC5 for ; Thu, 8 May 2025 14:15:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4476B0088; Thu, 8 May 2025 10:15:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 252D06B0089; Thu, 8 May 2025 10:15:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED4876B008A; Thu, 8 May 2025 10:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC87F6B0088 for ; Thu, 8 May 2025 10:15:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4B0045A1B4 for ; Thu, 8 May 2025 14:15:55 +0000 (UTC) X-FDA: 83419939470.20.A7C7B3B Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf10.hostedemail.com (Postfix) with ESMTP id A7438C0020 for ; Thu, 8 May 2025 14:15:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cagboBnB; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746713752; a=rsa-sha256; cv=none; b=rQoQPrFnD+vhEBgk5myNfk5Z5HiCRI5Q1/mgPN5C9vJEXVVqyhN/oWyoxbMZ12VWJdG7QO v3BBxDMCkGQO2PrteBA0CYLeWb1thVgNDnbURT94zFPWdIsbM6GzSultG+KGf71L1x2OeU oFJYGYes2QTixzuP69ju0lWvacvAGfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746713752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cKWqTwdZqcmbuUiqx2qKNdy+IGuUWkUCb/XtMBsVClk=; b=oNVYHy+ZornQoQcSj/bDJSvn6yEFZd/wp/JILUJ6sl1Puw7Tv85wVNLJxmm+1Q+Wm2umUZ 55tzZ6D43EoEN7JsSN5MtiBtmCeEKmstJXUOhkxNLHN8WzBEFamtncJzTikUogKXWEJivv y4uuQ8xf65cey/3/65bOekfFCfYYBoY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cagboBnB; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 548Aemc2011721; Thu, 8 May 2025 14:15:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=cKWqTwdZqcmbuUiqx 2qKNdy+IGuUWkUCb/XtMBsVClk=; b=cagboBnBNEzSAjMATXah0uh3dfktMbJlq pRwyEV4XepMrFAou0ZAxnr+S/nMt3nXuuTN2xarJ9xMqlWA7pB9nyPYoOpjB6C// q9ZAVXnrm9qp72NoVfi9FGtK85OucbnClZhPUHkT8nXNi0zJRJ49dQ9wfrBgVhS7 StIi/hrFyapBaLWM9pAOaPyhnz8YPRAVY3HqReF041P+jbNALEXkcXodZX12uMsN RA9WOxp28Y1PLycgtrmOMSchjkSUoKaA6O1qYnU9b5z3F/QvOlJdVhfL6+RSWOhl LG6Td9NXXajowgPqNX/99G7qZ+YEKTlpr+3DH9/5T8TBKrsVW/5vg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46gu2t11ap-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 May 2025 14:15:50 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 548E1HaA002523; Thu, 8 May 2025 14:15:49 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46gu2t11am-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 May 2025 14:15:49 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 548DbWpe026038; Thu, 8 May 2025 14:15:48 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46dwv069g8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 May 2025 14:15:48 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 548EFkqA51970316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 May 2025 14:15:46 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4FD620049; Thu, 8 May 2025 14:15:46 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B01D20040; Thu, 8 May 2025 14:15:46 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 8 May 2025 14:15:46 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id 3EB75E0DE3; Thu, 08 May 2025 16:15:46 +0200 (CEST) From: Alexander Gordeev To: Andrew Morton , Andrey Ryabinin , Daniel Axtens Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v6 1/1] kasan: Avoid sleepable page allocation from atomic context Date: Thu, 8 May 2025 16:15:46 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=NLnV+16g c=1 sm=1 tr=0 ts=681cbc96 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=dt9VzEwgFbYA:10 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=JPUNfvWgwyJmovPnq6kA:9 X-Proofpoint-ORIG-GUID: akX5fdkiTiZCx1fMIpNteeBvuqJGff0m X-Proofpoint-GUID: f9f6f2OzB1FHDvS_jXduA2GZbmjShWYE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA4MDEyMCBTYWx0ZWRfXz4TzQbDmsitn gudJTYSiFFa5UlGKcF/BrrrINfVdZJpgLbPKMUxjK5lsKIbJhhEowjLxv0W3RpIUetn67eKd6HF vhYdvIhHkpCJlTJZtoTx3L2p4p27ve4hdr/MjD8yu0e+963LamfYBNGkW1q1IYLX4WM7wEGDL1s ocjzse0vNdXYFURagkl4XRCIhs9kkgCMvAf9MZIA8X4NMBmsT0mB4D2LKl4ddlfp6z6xqdnQyj2 D85KP/DvUJu5H8Azp10aOKlOj/F+VtgsUe+v38eQcg5/U3s1/Lr682U4OqnW0s73x6veOnO6eCQ exbvqEyFhIkouxFkFbo1FRBGx8+SO0rYQCSYC3KpI6Dj+Lmun4/KuQMZJzyt+RmJ9hlrtxzhz4Q PLTvWabsvTPArkIrMWlHWndyuT01xx9YRfK53W7hJhrCXNgWbLxJ3pZc+KTS+vlMSLk3n0ND X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-08_05,2025-05-07_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 mlxlogscore=552 phishscore=0 mlxscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505080120 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A7438C0020 X-Stat-Signature: 3ew71sm1twotthrdn1dsrtrwtc317yzg X-Rspam-User: X-HE-Tag: 1746713752-986946 X-HE-Meta: U2FsdGVkX187zZzomfad9mcpowydOpGQoZ7cHEOf7Ee+CgQsp/J07wl8QzqKZ9UAw8608wE0aomYchr3Jq9TiVQg5Db3eUnJVu3AiCTsfSgwrgikkZjtJy32qa7iPmu+zvoRkdMopywT8o8xFtVHE9djRQeVeSLvg/xs3mP+1Tw2ozyWL7BbQQjXdRaiUyfc/mpyU+DY8s96aAbydmMocQLrZJsMDrdwhyJ5hBB7dlK2KYnAe4MyU1SDHjvcBr2wg58S3blGhRz3hlpHe0XX9ie2qunHgqnXHZXau3bIoiX4ejqFw23UwRujWVWhw0C59kCJLC9idwfHqLfjgahWURbC0VcLjC268hekkGVihBsECpgzPa3KME+Mc875NB+Bjwzu7xoaceUkvEyXXFQNIPZ/ojutLk5NdkArbm6gpW3ioCv85thAhdn1pHsK1KTpHn19QrlLKZ/jGu6PIK55Q9/6O44SJMd+DBxG2zEAuwvrq+dB6JxBJtTnwMttyQ3v4U/bZ1vLKMq99m1o8KKtaFd/PFzgtpRyowAZ1RNe5XrnD7teJRy6J3blpeami77IL3yb19YGWvT03aUV96HSucqby1SeoJfHX25Gn2MS5FGnIQ7vw+al3G50pttE2tDQHIT23yayUc3yjYN+jZHW4uy4jRqurS/w3j/4yCve3TM731GtVs1Iz8rK1hfOyEzp0hZ1KYkB2M+ynLN9hA201bXr30Vc1CKveK29Ij6LA0/hLwD1miKTpYd9YFtztGboKefkLAvyoPxH5HNRX4QLEielFRSYhVqdfD6z2L6d9HJ+WMfQ3JI53McGRwq31HKEp9sz/jP/u+EF9jdsCSNEFVzM1TiZPGrMITXJgZMXcBNX0GbD7fCHHXaVeWamxBaiFEtO31NqnszcBaNnOKDD3bjCHQmmflcjAmj3ZnaOKjw9xangD0bxz+dtRfY3LEIATXBB+3qUbPiaJES/R4K XmzMLVY0 jUIxQuU8oVJh9p0jClOmO4qr8R21W5/BkWGjPgSj6rx3DFIfYI8IWtNsZOZWudeHCf0xsQu/U8gCVpQSD8kQujPA/rJc8v1yWODrvpr7H/ZpZyRezEzbAoeu4KJIpNP/21hq6igzzqsrUGmuQZrIQXS47Q/CLnpTrBUnpzJGohjH0QHGGDkeAGrBtBW7F8eavbXTxRTIwXK3qkp5dmyPfyOA07bLgXEZhsx1V82zJBBv9Vv704+lrMDye2QSzGt5KT0Q3TiDZi/ECsOfa5eFFMtdxRo6VSwPnG0NYDZYrXhHtKLb0qSnPImmjUrSmTp12pque X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: apply_to_pte_range() enters the lazy MMU mode and then invokes kasan_populate_vmalloc_pte() callback on each page table walk iteration. However, the callback can go into sleep when trying to allocate a single page, e.g. if an architecutre disables preemption on lazy MMU mode enter. On s390 if make arch_enter_lazy_mmu_mode() -> preempt_enable() and arch_leave_lazy_mmu_mode() -> preempt_disable(), such crash occurs: [ 0.663336] BUG: sleeping function called from invalid context at ./include/linux/sched/mm.h:321 [ 0.663348] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 2, name: kthreadd [ 0.663358] preempt_count: 1, expected: 0 [ 0.663366] RCU nest depth: 0, expected: 0 [ 0.663375] no locks held by kthreadd/2. [ 0.663383] Preemption disabled at: [ 0.663386] [<0002f3284cbb4eda>] apply_to_pte_range+0xfa/0x4a0 [ 0.663405] CPU: 0 UID: 0 PID: 2 Comm: kthreadd Not tainted 6.15.0-rc5-gcc-kasan-00043-gd76bb1ebb558-dirty #162 PREEMPT [ 0.663408] Hardware name: IBM 3931 A01 701 (KVM/Linux) [ 0.663409] Call Trace: [ 0.663410] [<0002f3284c385f58>] dump_stack_lvl+0xe8/0x140 [ 0.663413] [<0002f3284c507b9e>] __might_resched+0x66e/0x700 [ 0.663415] [<0002f3284cc4f6c0>] __alloc_frozen_pages_noprof+0x370/0x4b0 [ 0.663419] [<0002f3284ccc73c0>] alloc_pages_mpol+0x1a0/0x4a0 [ 0.663421] [<0002f3284ccc8518>] alloc_frozen_pages_noprof+0x88/0xc0 [ 0.663424] [<0002f3284ccc8572>] alloc_pages_noprof+0x22/0x120 [ 0.663427] [<0002f3284cc341ac>] get_free_pages_noprof+0x2c/0xc0 [ 0.663429] [<0002f3284cceba70>] kasan_populate_vmalloc_pte+0x50/0x120 [ 0.663433] [<0002f3284cbb4ef8>] apply_to_pte_range+0x118/0x4a0 [ 0.663435] [<0002f3284cbc7c14>] apply_to_pmd_range+0x194/0x3e0 [ 0.663437] [<0002f3284cbc99be>] __apply_to_page_range+0x2fe/0x7a0 [ 0.663440] [<0002f3284cbc9e88>] apply_to_page_range+0x28/0x40 [ 0.663442] [<0002f3284ccebf12>] kasan_populate_vmalloc+0x82/0xa0 [ 0.663445] [<0002f3284cc1578c>] alloc_vmap_area+0x34c/0xc10 [ 0.663448] [<0002f3284cc1c2a6>] __get_vm_area_node+0x186/0x2a0 [ 0.663451] [<0002f3284cc1e696>] __vmalloc_node_range_noprof+0x116/0x310 [ 0.663454] [<0002f3284cc1d950>] __vmalloc_node_noprof+0xd0/0x110 [ 0.663457] [<0002f3284c454b88>] alloc_thread_stack_node+0xf8/0x330 [ 0.663460] [<0002f3284c458d56>] dup_task_struct+0x66/0x4d0 [ 0.663463] [<0002f3284c45be90>] copy_process+0x280/0x4b90 [ 0.663465] [<0002f3284c460940>] kernel_clone+0xd0/0x4b0 [ 0.663467] [<0002f3284c46115e>] kernel_thread+0xbe/0xe0 [ 0.663469] [<0002f3284c4e440e>] kthreadd+0x50e/0x7f0 [ 0.663472] [<0002f3284c38c04a>] __ret_from_fork+0x8a/0xf0 [ 0.663475] [<0002f3284ed57ff2>] ret_from_fork+0xa/0x38 Instead of allocating single pages per-PTE, bulk-allocate the shadow memory prior to applying kasan_populate_vmalloc_pte() callback on a page range. Suggested-by: Andrey Ryabinin Cc: stable@vger.kernel.org Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory") Signed-off-by: Alexander Gordeev --- mm/kasan/shadow.c | 77 ++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 63 insertions(+), 14 deletions(-) diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c index 88d1c9dcb507..660cc2148575 100644 --- a/mm/kasan/shadow.c +++ b/mm/kasan/shadow.c @@ -292,30 +292,81 @@ void __init __weak kasan_populate_early_vm_area_shadow(void *start, { } +struct vmalloc_populate_data { + unsigned long start; + struct page **pages; +}; + static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, - void *unused) + void *_data) { - unsigned long page; + struct vmalloc_populate_data *data = _data; + struct page *page; pte_t pte; + int index; if (likely(!pte_none(ptep_get(ptep)))) return 0; - page = __get_free_page(GFP_KERNEL); - if (!page) - return -ENOMEM; - - __memset((void *)page, KASAN_VMALLOC_INVALID, PAGE_SIZE); - pte = pfn_pte(PFN_DOWN(__pa(page)), PAGE_KERNEL); + index = PFN_DOWN(addr - data->start); + page = data->pages[index]; + __memset(page_to_virt(page), KASAN_VMALLOC_INVALID, PAGE_SIZE); + pte = pfn_pte(page_to_pfn(page), PAGE_KERNEL); spin_lock(&init_mm.page_table_lock); if (likely(pte_none(ptep_get(ptep)))) { set_pte_at(&init_mm, addr, ptep, pte); - page = 0; + data->pages[index] = NULL; } spin_unlock(&init_mm.page_table_lock); - if (page) - free_page(page); + + return 0; +} + +static inline void free_pages_bulk(struct page **pages, int nr_pages) +{ + int i; + + for (i = 0; i < nr_pages; i++) { + if (pages[i]) { + __free_pages(pages[i], 0); + pages[i] = NULL; + } + } +} + +static int __kasan_populate_vmalloc(unsigned long start, unsigned long end) +{ + unsigned long nr_populated, nr_pages, nr_total = PFN_UP(end - start); + struct vmalloc_populate_data data; + int ret; + + data.pages = (struct page **)__get_free_page(GFP_KERNEL | __GFP_ZERO); + if (!data.pages) + return -ENOMEM; + + while (nr_total) { + nr_pages = min(nr_total, PAGE_SIZE / sizeof(data.pages[0])); + nr_populated = alloc_pages_bulk(GFP_KERNEL, nr_pages, data.pages); + if (nr_populated != nr_pages) { + free_pages_bulk(data.pages, nr_populated); + free_page((unsigned long)data.pages); + return -ENOMEM; + } + + data.start = start; + ret = apply_to_page_range(&init_mm, start, nr_pages * PAGE_SIZE, + kasan_populate_vmalloc_pte, &data); + free_pages_bulk(data.pages, nr_pages); + if (ret) + return ret; + + start += nr_pages * PAGE_SIZE; + nr_total -= nr_pages; + } + + free_page((unsigned long)data.pages); + return 0; } @@ -348,9 +399,7 @@ int kasan_populate_vmalloc(unsigned long addr, unsigned long size) shadow_start = PAGE_ALIGN_DOWN(shadow_start); shadow_end = PAGE_ALIGN(shadow_end); - ret = apply_to_page_range(&init_mm, shadow_start, - shadow_end - shadow_start, - kasan_populate_vmalloc_pte, NULL); + ret = __kasan_populate_vmalloc(shadow_start, shadow_end); if (ret) return ret; -- 2.45.2