From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3248C6FD18 for ; Tue, 25 Apr 2023 11:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CADC6B0071; Tue, 25 Apr 2023 07:53:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17B516B0074; Tue, 25 Apr 2023 07:53:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 069A06B0075; Tue, 25 Apr 2023 07:53:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EB5526B0071 for ; Tue, 25 Apr 2023 07:53:16 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9BD6A12037B for ; Tue, 25 Apr 2023 11:53:16 +0000 (UTC) X-FDA: 80719752792.02.D5A45C3 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by imf26.hostedemail.com (Postfix) with ESMTP id A8150140011 for ; Tue, 25 Apr 2023 11:53:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.75 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682423594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91FhyrpYdK8L3NDoNITSm6az7D3ZhcH5O/0/8ugxGpg=; b=uYtmW2xMMhGQLge1SKW53Gm3LjuAPnvFvxNAEsN8NDm64IN1LgT7LoozO8ekhEp4ziZA1X efEp1NPAILNJoJL0rjY1CvGCZS8O5HWJxRqFRI+j1iHSlSRmTCtrLDUszhekv/F66D6kut 70IrW68RUm8aWrIt5nc+D2M7Pvoeowo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.75 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682423594; a=rsa-sha256; cv=none; b=7dpyVOR7cdw9AcHUJNtmiih3+KKwsBd7lNO5m32Bl+wc0rImQ8KikgjbsowZmZpKcOdyi1 4tN6SXYsuO4A6iRRAi6m4vtjzVOB+YPfjxmvhjh5XoYIwGv6QFC05CWv9P+CaR+flO/XVV V2P0Uhqi+wsmI+zsq8VosUacSnnY9TU= Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 0A34B24E257; Tue, 25 Apr 2023 19:53:06 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 25 Apr 2023 19:53:06 +0800 Received: from [192.168.125.87] (113.72.145.137) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 25 Apr 2023 19:53:05 +0800 Message-ID: Date: Tue, 25 Apr 2023 19:53:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 1/1] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Content-Language: en-US To: , , CC: Stephen Boyd , Michael Turquette , Conor Dooley , "Paul Gazzillo" , Necip Fazil Yildiran , Emil Renner Berthing , Xingyu Wu , References: <20230418123756.62495-1-hal.feng@starfivetech.com> <20230418123756.62495-2-hal.feng@starfivetech.com> From: Hal Feng In-Reply-To: <20230418123756.62495-2-hal.feng@starfivetech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.145.137] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A8150140011 X-Rspam-User: X-Stat-Signature: 3k1uebcttjasehgot9hgsfn8rdtn5pkx X-HE-Tag: 1682423592-148527 X-HE-Meta: U2FsdGVkX186s6qXtbGwkOoUFplkeH6iin5Dyymt5a3FpWBeOXFssOzqH4EL7E7p1YdjhBUEGGD+pSMr9lTobK6TSywc665DsSH+SxISl5jF3cF2tBs/dRPffSTGzfgV1jeY3o2+dw5VavTpjVVufCz3F7jTMvzuh4AswaouJTvBE9AuiyPvPGVAufA3qo5RvCZ3lL3GiQDd0n0CyV5hNb/uotfThGfHo1UDK5TtKwarpemtBYv2yomcYpCKyVuB6mcvyRSDyu9Wc9d+M+W9o75CFXDFeUzUSPcxSIrWJfO8y+l0DO6EYFMI7uisDM3r+O8dbC/XK2cb1DIkTMuh2LtJBYZeeEX2L3nMrGEEhvchcgyR4zSZ1TgTNigoHiwZOX1IL4HL/LmW6AziArwQlNZFCxgaDRx/yGwhOzIxhEJLlbSMQ2Xe7WaS89a6QTNOPtyEHAJJDZJyP0We+xzKrO+agjqnTAOO2Bm4a9t/0sw9YdgQ+X5kmIgEHsx2HEVkl8vBqDHLYEJzK132q0Sx4LuXX46PAVQWqwFnhM2iN1wx8zbaekRwogTyWSVesy2koD+zTirpu2M82eD7YOawpWBF+PNbrY5i5+aNhEbzjdzs7VyAGjGYwa90+yynTU1ccRskRsKtX1WRkRolExVnqd7uE5PzdTsYWAeLB/vl3Ct7RLZ2Ss4QVHMFez5CvAgNbG0+fm+3xAYmv5c1RSiQcLxCJB9YobOVCp/1umoZ5DA4nfvhDKklFlV1D33OzUgtz7cBc3dyg3uj4LhNegT4Yy/pXg+kjebmYo4yHb32qZPsQb0Ybs+4A/g4jau8DqKcwMPQ0l6PKJXaqB3buFOC6nLEAkCBzDs1pMXrZTBTJRNGhgiL7ANvXgTwdtGf3nXudKJza64g88m7LQgep+lncX9bvnVIilWhbBl7U9gzOFPZHvL7gdh0kgoxP/pF4ZrQlPBhVkcDgwjwaWy/TzA n4fY5aPR Mgmw4H3dVwAUAhyKQDyB2DEsIIu0ov0xPtybP/hQL+69Svv4l6RHwXUFs/KhWD7QxDbGf1HoMK5i9ZBZ+8478cZQhEXLUKj6DdvyXgSJ6gdWUF+fmaG+O1xlpU0dT3Py9046nFMuFPXjOkEYe8AxN2g4sBI0BfRwmszq8LOj5NBP0oyk7vj5M0kbAyqN8nyTInS+zR2Zbu5AHAkwh5IwpcTKU0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Apr 2023 20:37:56 +0800, Hal Feng wrote: > When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), > RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS > and CLK_STARFIVE_JH7110_AON. > > Add a condition `if RESET_CONTROLLER` to fix it. Also, delete redundant > selected options of CLK_STARFIVE_JH7110_AON because these options are > already selected by the dependency. > > Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") > Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") > Signed-off-by: Hal Feng Hi, Stephen, Could this patch be merged into v6.4? Thanks. Best regards, Hal > --- > drivers/clk/starfive/Kconfig | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig > index 71c1148ee5f6..5d2333106f13 100644 > --- a/drivers/clk/starfive/Kconfig > +++ b/drivers/clk/starfive/Kconfig > @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS > depends on ARCH_STARFIVE || COMPILE_TEST > select AUXILIARY_BUS > select CLK_STARFIVE_JH71X0 > - select RESET_STARFIVE_JH7110 > + select RESET_STARFIVE_JH7110 if RESET_CONTROLLER > default ARCH_STARFIVE > help > Say yes here to support the system clock controller on the > @@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS > config CLK_STARFIVE_JH7110_AON > tristate "StarFive JH7110 always-on clock support" > depends on CLK_STARFIVE_JH7110_SYS > - select AUXILIARY_BUS > - select CLK_STARFIVE_JH71X0 > - select RESET_STARFIVE_JH7110 > default m if ARCH_STARFIVE > help > Say yes here to support the always-on clock controller on the