Re: [PATCH v6 0/4] Convert x86/mm/pat to generic page table apis

["Vishal Moola (Oracle)" <vishal.moola@gmail.com>]

On Mon, Mar 02, 2026 at 09:33:31AM -0800, Dave Hansen wrote:
> On 2/27/26 16:44, Vishal Moola (Oracle) wrote:
> > On Fri, Feb 27, 2026 at 02:24:33PM -0800, Dave Hansen wrote:
> >> On 2/27/26 12:07, Vishal Moola (Oracle) wrote:
> >>> Do you have any more comments for this series? If not, could you please
> >>> take this through the x86 tree. Thanks 🙂
> >>
> >> From a 2-second glance, this doesn't have normal comment style and isn't
> >> using imperative voice. Quite a few "we's". Looks like it needs some
> >> more eyeballs.
> > 
> > Ok, my mistake on the comment style. I'll fix that.
> > 
> > Sorry I'm not the greatest at imperative voice, I'll pass all my comments
> > through AI to convert them all to imperative voice.
> > 
> > In regards to more eyeballs, I've realized I didn't cc ALL x86
> > maintainers. +CC the rest of the x86 maintainers and we'll hope
> > someone else looks at it as well.
> 
> I was actually kinda hoping you'd be able to actively go out and find
> some reviewers other than the maintainers.

I'd appreciate if you could give me more guidance on this. Who am I
supposed to go, if not the people from ./get_maintainers? I don't know
the x86 folks, I interact more with mm.

You've been giving valuable feedback to ensure the stylistic choices
meet your expectations. I have mentioned I'll have another version
*trying* to meet those stylistic expectations.

Mike has been very active in reviewing the ptdesc work (thanks!), and
he's provided valuable review about the code itself. I don't know about
you, but I trust his expertise on the topic of page tables.

So, I don't even know what you want from the "more eyeballs."
Do you want me to email a bunch of people unfamiliar with x86 and tell
them to catch what you (or any other specialized individual) would
catch? That doesn't sound productive *to me*.

This is on the x86 mailing list. And honestly, this current iteration is
simple enough that anyone specialized and interested could have taken a
look at it and to provide some feedback.

Please do let me know. I'd love to work with you not against you, but
that's difficult when you don't provide any guidance/pointers about the
issues you have with the patchset (or process?).