From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF27CD58E49 for ; Mon, 2 Mar 2026 03:33:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B11D76B008A; Sun, 1 Mar 2026 22:33:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABF876B008C; Sun, 1 Mar 2026 22:33:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9768E6B0093; Sun, 1 Mar 2026 22:33:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 887ED6B008A for ; Sun, 1 Mar 2026 22:33:09 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2D30F140865 for ; Mon, 2 Mar 2026 03:33:09 +0000 (UTC) X-FDA: 84499702098.04.1F7F8DE Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 8071C140007 for ; Mon, 2 Mar 2026 03:33:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=qualcomm.com header.s=qcppdkim1 header.b="p1jvc/02"; dkim=pass header.d=oss.qualcomm.com header.s=google header.b=br8MgbLw; spf=pass (imf26.hostedemail.com: domain of yuvraj.sakshith@oss.qualcomm.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=yuvraj.sakshith@oss.qualcomm.com; dmarc=pass (policy=reject) header.from=qualcomm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772422386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b2OsP/70Er+mWuJ/nMEuOkdDfzSNUXpTeUeLCE0ADeA=; b=1CEFKA+feDLj/DldMnWywZAcNebWlbh9m2Jnvo+tixOFosKYK+n1QN1vUDtLwukZetemNc R+9FJyXNCO46tTWC7GFfLDpXWr3rZASYwBRl+WWjddNugVxlewxjpdolHMMwUtLV8um2zH DCcgOTK4S+SkT65vch27pLWrebqkLAo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772422386; a=rsa-sha256; cv=none; b=U/+L6tHDzD1y7qTrkrWg5mtuUu0EnmnKImYBPleZdNT2mvXA20TP7ez7gHFkzyjjkukT47 gjSDdfPaEjZaVO/CVo9Qmr6IAkI3Dkst03uqFm2BbtCaXJuao1lKiBmfB14c83uaNjsOjB MeofJpS4EkLElQugzsD42oQSNIef7qs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=qualcomm.com header.s=qcppdkim1 header.b="p1jvc/02"; dkim=pass header.d=oss.qualcomm.com header.s=google header.b=br8MgbLw; spf=pass (imf26.hostedemail.com: domain of yuvraj.sakshith@oss.qualcomm.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=yuvraj.sakshith@oss.qualcomm.com; dmarc=pass (policy=reject) header.from=qualcomm.com Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 621JHpUD1563059 for ; Mon, 2 Mar 2026 03:33:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b2OsP/70Er+mWuJ/nMEuOkdDfzSNUXpTeUeLCE0ADeA=; b=p1jvc/02W+FH5Xdq 6BXKsYmuduBiGT62XYdrCYV5pr3T7r0I4bnRwxuhoS8gyVGBBJU57j82RtPEaHg5 KsQUlmEJIGtcq+aYtAlCoccZ+fJCeQmHLybFqGMLG4mdnF/xlWmLcfwI5+R5QCrf pERzMyIgZrwqkVrAGpLfLWBDtF9Vlb6zUAKYb+NoBdKNTDcJlHB4r841HLJbVr5i XyjAxSwzCCn2jwdUF0k08vXG/jdFUPpZdQ32uBYKA3qJBWrFi2rtHHYDJcwxApwB jBmjGTu/3u04iGQugyTTRJES4X0WeRyfLUvftB9IxYjAJx18hdyh1zzxL8GdN0Fr Vqp5HA== Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ckshkurs4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 03:33:05 +0000 (GMT) Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-463a075e177so21548288b6e.2 for ; Sun, 01 Mar 2026 19:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772422384; x=1773027184; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=b2OsP/70Er+mWuJ/nMEuOkdDfzSNUXpTeUeLCE0ADeA=; b=br8MgbLwNpZfZVNhsjqC/Y2dd2m8Ckd4gcMjF2W7OaY4UnCZS2Eaz8BV6tJkS5Jcjk 926EjLZEMDcv86c6RDqKbODmZJ7bdKwTjdCAaT8KvVKF+mK/4oKOkIpuw/rJdvqGc8ob q8egh2fx9rFenJpit7Ym8182kApaQX9BjZCpUGrUVMjAETn2Y890rv4gUimAA/1eDsix x6uxc6a/3QpV0yhPEcL+wtNfPG/g8zVC6QgCn0xsJcMoW4UHjpz3rRlmT5+wlWdjA4qD SJ/GHrXBQDoVE52cDLmMXGFrgXlQ/EpaT1KVs3QnWLTwpghifUPUx4FFk/okdGvlrCfK zhWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772422384; x=1773027184; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b2OsP/70Er+mWuJ/nMEuOkdDfzSNUXpTeUeLCE0ADeA=; b=WPeIV1f4oE4SEy/5Ma0Dvr9spu/pXdzr+E24LUYl89hshDv8Yp77gi5ZuWilj3SF0h GW4tTtHNwAknwfW4RKV4ytHydYtLewzmxCKHk9Qjzi64V/8moDwVUFixJDkKeDRaOObN lr89rBYh9n9q96V3xk6gfd4DNyM/AOOJEH2rls4Yh7HdKwZPkM57/R/73CmFAnBIQWLu 66iaVcQUPmbzLAIhOYGjr+x1QNDXS3z6rX2JlHRV6Q+5PJhj8/PmkUqG5MWMx2GZ7x7y YP//yoa7j2nhdnZydrGc5zIqRd6dCla1ZCu3wDvX5l2hin3JdRA5epIV8bsKSLi3eape VZ+Q== X-Forwarded-Encrypted: i=1; AJvYcCV6oLAlOsdIC8QyR9dOAJnBlw8Azxaa4T+I9VkgBhcn1kiGqkzApnTzLiFsw5e1G7xffcGolsvlOQ==@kvack.org X-Gm-Message-State: AOJu0Yyt097PzBX1EKeRsEIzjOw1h7O8keNdtp0DBSyEhugmU+rTJ3XQ ig/xAbStsbHSTGmHlIj5TnskJ1yNQ9OmZcOut6wNiy3m1ylgOUzRzfezsvKvCgezCQ5isPHMRaN +fA5p/wk4OnWgxj0Lbn76YMQ9FCHJ8r/440A/aC981OGA5Ge4zS+oaA== X-Gm-Gg: ATEYQzwVMY9h2poMGIu/XTNxp2OFKoHQd10Zn+/4cBE7q6DKFYt8ClYzg/LmghEAHu5 +8sW9cILv/vPN07iaMCATYARzkocy89Apl5JHsvN3r1HDIOyqhR0EG6TcKtQYK7Hpk5hf+JHW8Q 8ItcjFqKuQRTYu6Vt3H6UFETk8QlTtJLEeiKLv+C2zTZeIT2afX+YHsqJG3RHzZ5xl0NwFIkpYf sm9dGVdR7RHCVnMrq7UhtLXlI6U+Jd0w5S0eZpWYpzEguVWbojIK5jtMJ0z1QVbANnizI6R5e6b Kq+wD0Ozy1x9GqFcxJ2yyPW2vZujaR+lEIWm7wHNCsxWHrh8x72ilSAku8YoBu75FgJF5qK2YbN qW8ZeQElRgiaV6PFM0Do2SwYPUzYZVS5O5B3BzVkNyWECZVEwq2vh0ksd7+3L7XtUG5TC19Lo2h nWxmL3 X-Received: by 2002:a05:6808:5183:b0:45c:9927:3f33 with SMTP id 5614622812f47-464becb4a3amr4969473b6e.19.1772422384259; Sun, 01 Mar 2026 19:33:04 -0800 (PST) X-Received: by 2002:a05:6808:5183:b0:45c:9927:3f33 with SMTP id 5614622812f47-464becb4a3amr4969443b6e.19.1772422383785; Sun, 01 Mar 2026 19:33:03 -0800 (PST) Received: from hu-ysakshit-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4160cf9b240sm10950856fac.8.2026.03.01.19.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 19:33:03 -0800 (PST) Date: Sun, 1 Mar 2026 19:33:00 -0800 From: Yuvraj Sakshith To: "David Hildenbrand (Arm)" Cc: akpm@linux-foundation.org, mst@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 4/4] page_reporting: change PAGE_REPORTING_DEFAULT_ORDER to -1 Message-ID: References: <20260227140655.360696-1-yuvraj.sakshith@oss.qualcomm.com> <20260227140655.360696-5-yuvraj.sakshith@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDAyOSBTYWx0ZWRfX5p5ApOBBUT6F xAYKgvu/2gwdskqIFwNn4S8dECFxKAJo/1Y6ibFn+86T0Za/yBB5NGtMJBvXIlWBFHuq4GHzZIM 6VXxOTpP+MS1vyQANUBZq3RvTWFLqnmx0b3b5G4WKKFodrtn5YWUvAzEh4USxHmY0MHYOQJuNhF YC6RTvmjlgzves4wGik0eNqG59zU1M2JWYiIzx3/LutftpsfAteOUS/hQjpKf+NDMojQiUXl/aD rfhm9TdmWsoy2HzKgTAiFWVYZqol4qnz1ljIfYvBZrQJDlhVwD2WVWGDGedtuZcFanW00SmiGhB 8auJgPqb7z5oKMBnL1YAaTlrZ8p8ry4iimh0wevKbp8qui9KANKo3K48S+zsmwjqk39ER9AQUXv sZbPRAUGJronCifW12QBM8VrjSiEqWEtSMmlMhc/pvYOBSvngJYyWiRJXzPfwn9w4AgPhWn5LoM 6Pjr2U0afIoAhDFi7eA== X-Proofpoint-ORIG-GUID: fcgMeOLftloye-QdvVyMnUxFknDp1U1n X-Authority-Analysis: v=2.4 cv=EvbfbCcA c=1 sm=1 tr=0 ts=69a504f1 cx=c_pps a=WJcna6AvsNCxL/DJwPP1KA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=JqjX9IW5vOmFWWUa66MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Y9Zt4tPzoBS9L09Snn2:22 X-Proofpoint-GUID: fcgMeOLftloye-QdvVyMnUxFknDp1U1n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_01,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020029 X-Stat-Signature: n51amnh7cij3pxbiuzpkx5i4xxw36duo X-Rspam-User: X-Rspamd-Queue-Id: 8071C140007 X-Rspamd-Server: rspam12 X-HE-Tag: 1772422386-871580 X-HE-Meta: U2FsdGVkX18NfzqwBcIeebYOrG8u1jHjGajQo5QObCwpj8i7xce9f5HfmRdIhNyXBacRhDzRONmPIOYNQibEpEEbFonVF3eNhp6BX7MtY8vRIEPLdMcGdyYmHzJo0hZXM2tjWr2Ti0GZQfofIddlcVm9J4MMGqU9IcPFig56DyZ0i+HrAMvmbApZWtFZ/W2NW8Q4+mgh8F5k+TU4C9DyVjgDOl+cvdoj+AFbKeTUqfry0yEVIuMfa/qSad6UkTPDNgHmVT4V9yy5UYqr88TY2Qx1e+XzWMgRKvXUIQbEYQdMSdeLnBMvIXhMUx5WsXEVVwcX+whn0diByrlk0i1T8N5GnPsHG4eFPL3DUO8fQ/wdfXs/LrHpaPOxc1EknG1Pni5JxcVO8OTfsviaEFpTYFiA4bMEHPXm248vpgzErqCD4b68ekBLUhf+HVTPAkTqGIO5TmAsT4gu85/4X0H2SFNWcmSHDq/X8YsfPz37XIC+9rPw29ajFsOP/ojw3Y//irXxXBM2RoTaEuhD7NuKnhC9DaNNC1UcEHlLdgfMjm/vSwHJ7SAA+TSFARNY4sIZJDFfUjKjZCwTCnGzDLDoPdYW43EcNuUFqevdizA1lVzQMVknTIRc+V0usMq6wO/u/iqCQprnGAvQquHiMSOiNFO0OdFP9QECC5CH459ucZnWxJTuajJ/brIm5iZI53ICBkmuFq4CMWVMYDX/a4LkYr8O6R2xqKiP36ETCQWZ0jxfv4+Y9aXoONIHgeV5SWWo7GZ0ItPZ5Grsua5rk4eOlv8GblBIy6SV2u44fTcrJ4+F9Y9aPIAxYFfLhIhIci9X7hgllAHi+stahPH6I+EeclQGM7M1RiUeqxjVQtBfmJdsY+bw+k2X6Q/gGRDta3C4gfF5TsDcVEHnGso9wM+9Kwz/bOxq3PXScDs3yzlJwGmi7r6ajPoh6XhQVJmJtmpsrFBtWF2UGpu8xwETPuD OwwimUP/ yObK3g0+yzE6A6GSaRPH/usGjoiRN9mOgnq/FDlnGVsowIdJbeA4Gc1Ys6ktso3K2c/3daSsi10sPmYtwHTNSdqkhh2L1tZylrbZc7OVbdBZESQmZ0uUng32U0yUFXPV1PGv8ekJIkXqn2th79Ty/m68pyHYgaTQrcE2pDjWIvLDQvzwSiIBIGDZ4n8o1czUtUPnw6SmpawbbOK5Vkz7qH+/MDAylwpQEZAP7Msya+t/HxJXFIaHmin4JXP6Iun1GY00BxqXw/l5ReMiVr2walwrCXSRMPSIItK+WJf6aIGq/Z7hGbiZ50e01s0RuHtNSBFScI0/X3uciyyPUSXnrinw+Xr702pMMscsluRFvnGUSXAJ5eSOd9hY6L2ip2S7jW9zQm4Us+ybuKePII8wp9wxiG+SRQOtB3IdWfjTrPvkplTGQMojgsjxto16mr1sRPhW38dJCxOSK2bUniqe38hTN6kNrSHHoCNgCPWmPA2V0eVv8BTchjLOVF6lYaGIjqSP5cLEMXQeENNpexsQWkQKxDMK3PEwwakdWUZSjiTUxuXU0rRJAx+Mgn4648BRnOLx6IgxGgOd7fExoRPW50R7nLes2AZ7iEeXMAR0Guyj4oXP9edyBkxfDHGGI6U4nWp7R4SB6Hm5W78gh6USg702rc7MnE1fw7jzpRAiAYoNN0pU= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 27, 2026 at 09:50:15PM +0100, David Hildenbrand (Arm) wrote: > On 2/27/26 15:06, Yuvraj Sakshith wrote: > > PAGE_REPORTING_DEFAULT_ORDER is now set to zero. This means, > > pages of order zero cannot be reported to a client/driver -- as zero > > is used to signal a fallback to MAX_PAGE_ORDER. > > > > Change PAGE_REPORTING_DEFAULT_ORDER to (-1), > > so that zero can be used as a valid order with which pages can > > be reported. > > > > Signed-off-by: Yuvraj Sakshith > > --- > > include/linux/page_reporting.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/page_reporting.h b/include/linux/page_reporting.h > > index a7e3e30f2..3eb3e26d8 100644 > > --- a/include/linux/page_reporting.h > > +++ b/include/linux/page_reporting.h > > @@ -7,7 +7,7 @@ > > > > /* This value should always be a power of 2, see page_reporting_cycle() */ > > #define PAGE_REPORTING_CAPACITY 32 > > -#define PAGE_REPORTING_DEFAULT_ORDER 0 > > +#define PAGE_REPORTING_DEFAULT_ORDER (-1) > > No need for the (). > > Wondering whether we now also want to do in this patch: > > > diff --git a/mm/page_reporting.c b/mm/page_reporting.c > index f0042d5743af..d432aadf9d07 100644 > --- a/mm/page_reporting.c > +++ b/mm/page_reporting.c > @@ -11,8 +11,7 @@ > #include "page_reporting.h" > #include "internal.h" > > -/* Initialize to an unsupported value */ > -unsigned int page_reporting_order = -1; > +unsigned int page_reporting_order = PAGE_REPORTING_DEFAULT_ORDER; > > static int page_order_update_notify(const char *val, const struct > kernel_param *kp) > { > @@ -369,7 +368,7 @@ int page_reporting_register(struct > page_reporting_dev_info *prdev) > * pageblock_order. > */ > > - if (page_reporting_order == -1) { > + if (page_reporting_order == PAGE_REPORTING_DEFAULT_ORDER) { > > Sure. Now that I think of it, don’t you think the first nested if() will always be false? and can be compressed down to just one if()? - if (page_reporting_order == PAGE_REPORTING_DEFAULT_ORDER) { - if (prdev->order != PAGE_REPORTING_DEFAULT_ORDER && - prdev->order <= MAX_PAGE_ORDER) - page_reporting_order = prdev->order; - else - page_reporting_order = pageblock_order; - } + page_reporting_order = pageblock_order; + + if (prdev->order != PAGE_REPORTING_DEFAULT_ORDER && + prdev->order <= MAX_PAGE_ORDER) + page_reporting_order = prdev->order; Thanks, Yuvraj > > (and wondering whether we should have called it > PAGE_REPORTING_USE_DEFAULT_ORDER to make it clearer that it is not an > actual order. Leaving that up to you :) ) > > -- > Cheers, > > David