From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
akpm@linux-foundation.org, Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v6 0/4] Convert x86/mm/pat to generic page table apis
Date: Fri, 27 Feb 2026 16:44:06 -0800 [thread overview]
Message-ID: <aaI6Vq-uyJ6F4P7u@fedora> (raw)
In-Reply-To: <2fe139df-1764-40e5-983d-48d7f97c2e39@intel.com>
On Fri, Feb 27, 2026 at 02:24:33PM -0800, Dave Hansen wrote:
> On 2/27/26 12:07, Vishal Moola (Oracle) wrote:
> > Do you have any more comments for this series? If not, could you please
> > take this through the x86 tree. Thanks 🙂
>
> From a 2-second glance, this doesn't have normal comment style and isn't
> using imperative voice. Quite a few "we's". Looks like it needs some
> more eyeballs.
Ok, my mistake on the comment style. I'll fix that.
Sorry I'm not the greatest at imperative voice, I'll pass all my comments
through AI to convert them all to imperative voice.
In regards to more eyeballs, I've realized I didn't cc ALL x86
maintainers. +CC the rest of the x86 maintainers and we'll hope
someone else looks at it as well.
prev parent reply other threads:[~2026-02-28 0:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 2:03 Vishal Moola (Oracle)
2026-02-19 2:03 ` [PATCH v6 1/4] x86/mm/pat: Convert pte code to use " Vishal Moola (Oracle)
2026-02-19 2:03 ` [PATCH v6 2/4] x86/mm/pat: Convert pmd " Vishal Moola (Oracle)
2026-02-19 2:03 ` [PATCH v6 3/4] x86/mm/pat: Convert populate_pgd() " Vishal Moola (Oracle)
2026-02-19 2:03 ` [PATCH v6 4/4] x86/mm/pat: Convert split_large_page() to use ptdescs Vishal Moola (Oracle)
2026-02-20 10:25 ` [PATCH v6 0/4] Convert x86/mm/pat to generic page table apis Mike Rapoport
2026-02-27 20:07 ` Vishal Moola (Oracle)
2026-02-27 22:24 ` Dave Hansen
2026-02-28 0:44 ` Vishal Moola (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaI6Vq-uyJ6F4P7u@fedora \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox